Commit Graph

2121 Commits

Author SHA1 Message Date
Bruce Blaser
bfcdcf7788 fix(a11y): enhance accessibility of prismjs code examples (#48639) 2022-12-05 19:49:36 +05:30
YMatsuda
7ff99ea269 fix(UI): make 'Tests' heading translatable (#48654)
* fix(UI): make 'Tests' translatable

* fix(UI): use existing string
2022-12-05 09:23:32 +01:00
Prince Mendiratta
7b860f920f feat: add instructions to import in replit (#48374)
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/48274
2022-11-24 16:02:07 +05:30
Manabu Matsumoto
6ccbd94eff fix(UI): remove vertical scrollbar from body (#48231)
* fix: remove vertical scrollbar from body

* fix: adjust preview window with/without actionrow

* fix: delete redundant padding argument

* fix: add new props to project preview modal

* fix: adjust code and preview pane height

* fix: add flash message height adjustment for panes

* fix: refactor the code with flexbox

* fix: debug zero height of instruction panel in firefox

* fix: debug zero height of reflex elements and vertical splitter

* fix: make reflex elements vertically flexible in new RWD

* fix: remove unnecessary css properties

* fix: arrange mobile layout css selector

* fix: move styles to its related css files

* fix: refactor the code with pseudo selector and remove important

* fix: remove redundant flexbox settings

* fix: remove unnecessary css properties and revert unnecessary property name change

* fix: remove unnecessary min height zero and refactor flex properties
2022-11-22 11:18:00 +03:00
YMatsuda
df1afaa667 fix(UI): prevent Chinese & Japanese headings in lower jaw getting wrapped (#48530)
fix(UI): prevent Chinese & Japanese headings getting wrapped
2022-11-17 16:00:04 +03:00
Sem Bauke
57186bf0b6 chore(client): update algolia and conditional tags (#46222) 2022-11-14 21:03:52 +05:30
Muhammed Mustafa
f227b60c9e feat(client): change the layout of lowerjaw hint and test to flex (#48322)
* feat(client): change the layout of lowerjaw hint and test description to flex

* remove the align center, and fix the margins

* Revert mistake

* add RTL layout support

* Remove global variables, and add gap for spacing
2022-11-14 12:49:03 +05:30
Muhammed Mustafa
8b158bc314 refactor(client): space between passed icons and their sibling (#48327) 2022-11-11 18:45:40 +05:30
Ahmad Abdolsaheb
22c5533417 feat(client): add university and seasonal alerts (#48350)
* feat: add university and seasonal alerts

* feat: show university camper alerts to non donors

* feat: adjust tests

* feat: update CTA

* Apply suggestions from Oliver's code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* feat: changing learn alert to link

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-11-10 13:06:33 +00:00
Sem Bauke
8df880fa61 chore(client): update chinese redirects (#46220) 2022-11-10 01:16:45 +05:30
Naomi Carrigan
c36224b9de feat: update gatsby config for chinese (#46424) 2022-11-09 21:36:05 +02:00
Tom
5f73773cd4 feat(client): move legacy rwd button to bottom of map (#47596)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/46523
2022-11-08 21:00:46 +05:30
Oliver Eyton-Williams
ecfe09c52d fix: confirm modal (#48388)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-11-04 11:06:47 +00:00
Mrugesh Mohapatra
75f4ff10d5 feat(client): add a confirmation modal on signout (#48385)
* feat(client): add a confirmation modal on signout

* test: add and update universal nav

* chore: remove extraneous action

* chore: apply suggestions from code review
2022-11-04 10:31:06 +01:00
Mrugesh Mohapatra
12beeee067 refactor: consistent layout imports (#48378) 2022-11-04 09:40:03 +02:00
Shaun Hamilton
ec3ee856ec feat(tools): ignore no-unused-vars on underscore (#48386) 2022-11-04 10:43:46 +05:30
Muhammed Mustafa
5ef777973a feat(client): refactor the buttons leading to the certifcations intro (#48320) 2022-10-31 18:11:51 -05:00
Prince Mendiratta
deca35257b feat: disable find hotkey in editor (#48241)
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-28 22:45:18 -07:00
Muhammed Mustafa
52953a5b95 feat(client): add rtl direction attribute to html element (#48245)
* feat(client): add rtl direction attribute to html element

* WIP: add LangDirection as base for direction attribute selection

* DRY rtlLanguages for easier future usage

Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>

* Remove urdu, to avoid unknown bugs

* Fix merge conflict, by clearing import values

Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
2022-10-28 08:13:09 +02:00
Muhammed Mustafa
3279ab161e feat(client): refactor universal nav missing types (#48144)
* feat(client): refactor universal nav missing types

* extends link type from gatsby link types


Co-authored-by: auchynnikau <viachaslau_auchynnikau@epam.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 20:20:59 +05:30
Atir Nayab
f92a851a0a feat(client): add icon in setting page button (#48268) 2022-10-27 20:06:47 +05:30
Jagruti Tiwari
af156fdfe4 feat(client): add "completed x of y" in completion modal (#47022)
* feat: wrote a new function and updated the test case

* fix: lint errors

* fix: Fixed the changes not being reflected in the code. And undid unwanted commits from the last time

* fix: removing unwanted updates to the package-lock.json

* fix: Removing unwanted changes from package-lock.json

* fix: removing unwanted changes from package-lock.json

* fix: updating snapshots to fix the test case

* chore: update snapshot

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update client/src/templates/Challenges/components/completion-modal.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: removed hard coded english words from translation text

* fix: only show output when id is cert project

* fix: correctly count completed challenges

* fix: update test and snapshot

[skip ci]

* fix: at least one challenge is always completed

When the modal pops-up, there is always at least one challenge counted as "complete"

* refactor: slightly improve readability

Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 14:26:45 +00:00
Vaibhav Gupta
e2da8dae3c chore(client): Don't re-create preview iframe from scratch on each test run (#48178)
* remove unnecessary call

* Remove unused variable: previewTask

* review comments
2022-10-27 09:41:47 +02:00
Mrugesh Mohapatra
b393d88b9e refactor: s/all-langs/i18n/g (#48258) 2022-10-26 10:08:27 -07:00
Muhammed Mustafa
6074cdf9c1 feat(client): clear ESLint comment in learn layout (#48154)
feat(client): clear enlist comment in learn layout
2022-10-24 11:00:02 +02:00
Sawjan Gurung
8ea0401c0a fix(client): preserve scroll position of preview iframe (#47870)
* fix(client): preserve scroll position of preview iframe

* use existing frameContext instead of getting element

* do not use type guard

* remove unused type, add es2022 to ts-lib

* move scroll functions into a class

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-10-21 22:52:15 +05:30
Prince Mendiratta
12828fa497 feat(client): replace preview icon with a clearer one (#48169) 2022-10-21 22:47:03 +05:30
Muhammed Mustafa
b05c99d720 feat(client): link Arabic new articles to freeCodeCamp searchbar (#48129)
* feat(client): link Arabic new articles to freeCodeCamp searchbar

* Point to english articles, instead of arabic articles

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* link the search bar to Arabic news

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-10-21 19:30:49 +09:00
Mehdi Bouaziz
818568376d fix(UI): replace button with icons in challenge lower jaw (#48014)
* fix: replace button with icons in challenge lower jaw

* fix: update icon buttons to add data-cy, align right, and cleaner conditional display

* fix: update cypress test with correct selector, update conditional button syntax

* fix: add reset and help icon components, move lowerjaw.css to editor.css

* feat: adjust icon buttons order

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-10-20 14:08:56 +02:00
Oliver Eyton-Williams
129c110368 fix: only fetch growthbookUri in browser contexts (#48112) 2022-10-19 01:13:54 -07:00
Ahmad Abdolsaheb
0df7ee430d feat(client): add growthbook (#48003)
* feat: initial set up

* feat: useFeature setup

* feat: adjust attributes

* chore(client): remove ts-disables in growth-book-wrapper

* feat: pull growthbook uri from env

* feat: adjust the staff atribute

* feat: make linter happy

* feat: update recruitment message

* refactor: simplify types

* chore: delete unused config

* fix: update copy

* fix: add growthbookUri to expected env vars

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-17 14:53:25 +02:00
PakkuDon
e5f54cab5f chore(client): remove exports for unused types (#48004)
* chore(client): remove exports for unused types

* chore(client): remove unused type
2022-10-14 19:10:21 +05:30
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Mrugesh Mohapatra
06765555c1 feat(client): add page for users blocked by okta (#47991) 2022-10-12 20:21:19 +05:30
Prince Mendiratta
567de3bedb fix: do not display breadcrumbs with iframe (#47989)
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-12 12:36:01 +02:00
Prathamesh Gawas
e42907a40c fix(client): prevent submitting forms in iframe (#47799)
Co-authored-by: Muhammed Mustafa <MuhammedElruby@gmail.com>
2022-10-12 04:24:26 +05:30
Derryk Boyd
d380f13172 chore(client): ts migrate builders.js (#47813)
* Rename builders.js > builderst.ts

* Chore: Migrate builders.js to typescript

* Replace _concatHtml with concatHtml

Co-authored-by: Derryk Boyd <derryk@redmantech.com>
2022-10-11 11:42:08 -07:00
Mrugesh Mohapatra
0885f4f4e4 fix: update url and status in sd-markup (#47978) 2022-10-11 20:27:34 +05:30
Hdanzo
e935d75edc feat(client,seo): add structured data for courses (#47659)
Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 16:51:23 +05:30
Prince Mendiratta
314f0e4ba6 fix: separate string to view code/project (#47890)
* fix: separate string to view code/project

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* feat: add test for certification rendering

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* chore(lint): trailing newline at EOF

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-08 10:11:21 +02:00
Danny Greenberg
93347ea285 fix(font): Replace Roboto Mono with Hack-ZeroSlash (#47767)
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-10-06 15:57:40 +00:00
Bruce Blaser
15da8ffcb2 fix(a11y): make console pane output keyboard accessible (#47764) 2022-10-06 21:14:16 +05:30
Divyansh Singh
6dd8c6241b feat: add hidden skip-to-content button (#47577)
* feat: add skip-to-content button

* fix: remove content start ids from everywhere and add to default layout

* chore: format landing-top.tsx

* use single quotes in skip-to-content component

* include breadcrumbs in navigation

* linting fail fix

* use anchor tag instead of new component

* update challenge title snap

* fix(test): reliably move focus onto the editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-05 20:43:00 +02:00
Niraj Nandish
53164e71f1 fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00
Oliver Eyton-Williams
7d77a202ec feat(client): use updateMySocials not updateUserFlag (#46380)
* feat: use updateMySocials not updateUserFlag

* fix: replace updateUserFlag with updateMyTheme

* fix: show social icons

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: delete social booleans from client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-09-30 16:18:23 +03:00
Hdanzo
c4f7e45832 feat: standardize view button text (#47525)
* feat: standardize view button text

Add new translation keys Delete unused translation keys Fix tests broken with new functionalities

* Delete View variations in translations.json
Delete buttons tittle
Modify buttons text to be "View" or translated equivalent
Modify tests to query the buttons by role and name

Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
2022-09-30 10:39:33 +03:00
Oliver Eyton-Williams
d879e1df21 fix: stop mutating store when toggling settings (#47654) 2022-09-29 10:44:11 -05:00
Shaun Hamilton
73c3edb56a fix: certification to private on private timeline (#45562)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-29 00:00:22 +05:30
Muhammed Mustafa
afb861be9d fix(client): making misclicking sign out harder (#46644)
* added hover and focus effect on signout

* increase spacing by increasing the height

* I remembered why I hated react so much

* will come back after the meeting

* cleared 10 types error

* fix: make lang menu more keyboard accessible

* increased button specificity and switch to navlink to focus better

* added className for future style when the fuction is functional

* this is funny

* slowly comming together

* will create the function tomorrow morning

* signout is read only bug

* Removed the need for enlist

* Update client/src/components/Header/components/nav-links.tsx

* Update client/src/components/Header/components/nav-links.tsx

* Props fails, I am removing enlist errors and implementing types

* Update client/src/components/Header/components/nav-links.tsx

Co-authored-by: Moshe <shootermv@gmail.com>

* half of eslint no unsafe call

* No issue without this eslint as well

* Couldn't fix enlist issue

* same error

* Removed eslint error

* no-unsafe-member enlist error

* Clear enlist error

* cleared type errors

* remove eslint no unsafe memeber access

* no unsafe return eslint

* I have opened pandora box

* npm errors

* I am really lost

* Cleared some typescript errors, hopefully I can create the modal now

* added basic style and a plan

* modal show and hide functionality

Co-authored-by: wongwinnie198@gmail.com

* Revert "modal show and hide functionality"

This reverts commit 237e0b00c4.

* modal show and hide functionality

Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>

* clear type error

* interesting my first animation attempt failed

* removed the modal

* added color, it may be damaging accessiblity

* revert translation.json changes

* cleared unused types and type mistake I added before

* Revert key press naming changes

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* changed hover effect to danger variables and fix change language hover

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* add lang manu height to gerenic selector

* remove redundant code, make cansel change stay color stay blue

* Revert me mess around

* prettier format

* test cypress interaction and if it accounts for mobile design

* Revert "test cypress interaction and if it accounts for mobile design"

This reverts commit 9b01e78156.

* refactor search form

* add missing value units

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Moshe <shootermv@gmail.com>
Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>
Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-28 15:57:14 +02:00
Shaun Hamilton
79c232c586 fix(client): prevent sound on every render (#47640) 2022-09-28 15:15:49 +09:00