Commit Graph

25 Commits

Author SHA1 Message Date
Sem Bauke
cfc9b7258d fix(client): cert rendering temporarily (#43335)
* fix: require login as step

* fix: cert rendering temporary

* fix: remove keys from other translation files

* fix: cypress test

* chore: shauns suggestions

* fix: remove steps

* fix: use a seperate UseEffect function

* Suggestions from Shaun

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: certification temp rendering

* fix: cert temp rendering hopefully

* fix: button visibility and cert test

* fix: condition

* test: improve claim cert tests

Without npm run seed, retries will be in a different state.

Check the scroll position to (hopefully) catch the weird cert claim bug.

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-10-01 10:00:14 +05:30
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Shaun Hamilton
6ca6d9950c feat(client): improve SuperBlock cert claiming UX (#41147)
* feat(client): improve SuperBlock cert claiming UX

* broken: add certCard foundation

* broken: add TODO comments for scatter-brain

* restructure stepsToClaimSelector

* add api-server verifyCanClaimCert logic

* temp: correct verifyCanClaim URL

* move GET logic to CertificationCard, remove console.logs

* add error handling, and navigation logic

* correct verification logical flow

* fix completion-epic updates, fix cert verify

* update widget to button, disable button unless verified

* working: refactor CertChallenge with hook state

* add StepsType

* update Honesty snapshot

* add DonationModal to SuperBlockIntro

* disable Claim Cert button unless also isHonest

* prevent warning when viewing cert

* test: use navigate in Modal to return to hash

* test: replace gatsby.navigate with reach/router.navigate

* add propTypes

* fix: rename propTypes -> prop-types

* use react-scrollable-anchor to squash modal bug

* update location parser type

* open-source Oliver's suggestion

* fix superblock title

* add claim-cert-from-learn tests

* use larger tests

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix some cypress stuff

* fix ShowCertification cypress test

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-07-15 23:51:27 +09:00
Kristofer Koishigawa
e82f5f4425 feat: update titles for certification pages (#42252)
* feat: update titles for certification pages

* fix: update titles in Cypress tests

* fix: change "certificate" to "certification" in intro-page.js test file

* fix: prevent adding "Certification" to title for interview prep, make variable name more clear

* feat: add test for coding interview prep page title
2021-06-04 12:04:02 +02:00
Shaun Hamilton
24be225fa4 feat(client): refactor propTypes to TS types (#42278) 2021-06-03 14:23:46 +03:00
Mrugesh Mohapatra
7c4676d0a4 fix(client): quick-fix for cert claiming (#42055)
* chore: reinstate the quick-fix for cert claiming

This reverts commit d80d093c8b.

* feat: add progress to claim cert card
2021-05-07 12:39:42 -07:00
Oliver Eyton-Williams
9be2fb9a10 fix: use lodash-es in the client (#41931) 2021-04-28 16:11:20 -05:00
Shaun Hamilton
d3f59e6d5d fix(dev): rename superBlock with v7 to certSlug (#41738)
* fix(dev): rename superBlock with v7 to slug

* improve name slug -> certSlug

* superBlockTitle -> superBlock

* correct teeny, tiny mistake

* fix: correct slug to certSlug in certLocation

* refactor currentCerts

* rename showCert cert -> certSlug and various
2021-04-23 22:29:17 +03:00
Mrugesh Mohapatra
ad9b1f89d8 fix(api, client): update Gatsby, webpack & related things (#41452)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-25 12:13:43 -07:00
Shaun Hamilton
3aad0808ed fix(client): fix v7 certlocation (#41565) 2021-03-24 20:28:13 +05:30
Oliver Eyton-Williams
f8699a8d55 refactor: simplify challenge.block usage (#41185) 2021-02-23 09:52:48 +05:30
Oliver Eyton-Williams
97fcaa693f refactor: only use dasherized superBlock (#41067) 2021-02-13 10:36:04 +05:30
Shaun Hamilton
73f8377d68 fix(client): add key to Fragment in SuperBlockIntro (#41091) 2021-02-13 10:35:07 +05:30
Tom
32eade41b1 feat(client): improve navigation experience with scrolling (#41042) 2021-02-11 23:52:04 +05:30
Oliver Eyton-Williams
6c1f6bebed feat: label un-audited challenges (#41002)
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2021-02-11 18:10:32 +05:30
Kristofer Koishigawa
3b0ebb3dcb feat(client): translation status banner (#41001)
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-09 13:26:18 +05:30
Tom
1875984423 fix(client): remove auto scroll on superBlock page (#40828) 2021-01-31 12:15:41 +05:30
Ahmad Abdolsaheb
df014a4715 fix(client): add visual hierarchy to card blocks (#40822) 2021-01-31 12:15:41 +05:30
Kristofer Koishigawa
9ec8aa3db4 fix: update intro pages and learn map (#40745) 2021-01-31 12:15:39 +05:30
Kristofer Koishigawa
2615490bac fix(learn): update copy for cert landing pages
* fix: update copy for certification landing pages (#40744)

* fix: broken ci tests (#40746)

Co-authored-by: Quincy Larson <QuincyLarson@users.noreply.github.com>
2021-01-31 12:15:39 +05:30
Tom
625469c82f feat: improve ui/ux learn map (#40579)
Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2021-01-31 12:15:39 +05:30
Kabindra Shrestha
ac3d762bb5 fix(learn): split and simplified learn map (#39154) 2021-01-31 12:15:35 +05:30
Mrugesh Mohapatra
d2c017d821 fix(title): make consistent main title 2019-02-21 16:50:29 +00:00
Bouncey
b13e5fb41a feat: Use prettier-eslint to format code 2019-02-19 14:30:27 +05:30
Bouncey
5b254f3ad6 chore(learn): Merge learn in to the client app 2018-09-30 12:42:40 +01:00