Commit Graph

834 Commits

Author SHA1 Message Date
Manabu Matsumoto
95b724a3a2 feat(UI): visualize input clear button (#48702)
* feat: visualize search bar inputs clear button

* chore: remove redundant empty lines

* fix: make search bar input horizontally responsive

* fix: make search bar input width follow suggestion items

* fix: moving clear button to right of the searchbar

* feat: add search bar clear button in LP

* fix: add a bigger spacing between the icons and the text

* fix: make the clear button show visible focus indicator

* chore: refactor the css code to avoid redundancy

* fix: make the buttons in search bar accessible for screen reader

* fix: make the buttons and input in search bar more accessible
2022-12-23 17:00:38 -06:00
Mrugesh Mohapatra
25f0fc5d93 fix(client): add loader to default layouts (#48830) 2022-12-23 13:38:50 -06:00
Niraj Nandish
acd74472f8 fix(client): i18n project and certification titles in settings, profile and certification page (#48785)
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/40998
2022-12-22 10:54:46 +05:30
Muhammed Mustafa
8cc575c9b9 feat: swap to logical properties for spacing (#48769) 2022-12-22 10:51:19 +05:30
Ahmad Abdolsaheb
bff61255f9 feat(donation): simplify donation client (#46379)
* feat: unify post payment actions

* feat: handle stripe card error and add donation after auth

* feat: add donation saga stripe test

* feat: add more coverage to stripe tests

* feat: add initial stripe card saga test

* feat: finalize initial stripe card saga test

* feat: add patreon test saga

* feat: test clean up

* feat: do not show processing for Patreon

* feat: normalize donation settings

* feat: turn payment provider/contex to enum

* feat: remove donation-settings.js

* fix: git ignore generated config

* fix: ignore the generate config from everything

* fix: remove types.js

* fix: update linting to include types.js

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-12-20 18:03:06 +05:30
Muhammed Mustafa
4291e153f7 feat: add RTL language layout (#48287)
* add the previous layout

* add the import logic

Co-authored-by: Nestor <elnestinatorHD@gmail.com>

* WIP: RTL layout

* WIP: code snippet

* WIP: RTL layout

* WIP: RTL layout

* WIP: add selector that don't work

* WIP: fix code in tables direction

* change the dynamic import to static import

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* remove redundant imports

* fix the broken splitter and broken code element

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* revert the wrapper editor layout

* WIP: Timeline RTL layout

* add row reverse to account for splitter direction reverse

* Revert "add row reverse to account for splitter direction reverse"

This reverts commit f67ad002c8.

* add row reverse to account for splitter direction reverse

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* mirrior the nav bar by placing the logo in the right

* Use notosans as RTL font family

* Remove Arabic from the hiddenLangs

* fix(feedbac): the search and table alignment

Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>

* fix(feedback): text alignment, icons rotation

Co-authered-by: moT01 <20648924+moT01@users.noreply.github.com>

* Revert "fix(feedback): text alignment, icons rotation"

This reverts commit 0c6dc4f909.

* fix(feedback): text-alignment, and icon rotation

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

Co-authored-by: Nestor <elnestinatorHD@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-12-16 18:03:18 +02:00
Bryan Moore
628764f270 feat: use system theme if default (#48568)
* feat: use system theme if default

* feat: add system to theme

* feat: detect if system theme should be used

* fix: remove system from Themes

* fix: change 'system' to 'default'

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: change 'system' to 'default'

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: check if user is logged in for system theme

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2022-12-14 15:20:10 +01:00
Atir Nayab
0a0be525b2 fix(bug): Make table and button consistent in settings and certification page. (#48211)
* fix(bug): Make table and button consistent

Affected page
- certification page
- settings page

* fix(bug): changed certification button text to View

* fix(bug): Timeline table width increased

* Update client/src/client-only-routes/show-project-links.tsx

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* Update client/src/client-only-routes/show-project-links.tsx

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix(curriculum): remoeve stripe props from certification table

* fix(curriculum): time line table width reverted to original

* fix(client): use buttons.view from translation.json

* fix(client): use normal font weight for project title

* fix(client): certification page table button

* fix(client): remove child anchor tag from menuItem

* fix(client): updated cerification page button width

* feat: relocate the styles

* feat: clean up styles

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-09 12:08:52 +02:00
Muhammed Mustafa
b5371f56ce refactor(client): searchbar - remove float values (#48292)
* feat(client): refactor searchbar by removing float values

* polish the style by adding border radius and removing padding

* Polish the style and account for donation text

* WIP: remove float values

* Revert "WIP: remove float values"

This reverts commit c1c32aa9d1.

* adjust magic numbers

* Adjust spacing to account and add position absolute

* revert the deletion of ais hits values

* move the padding value to searchbar file

* Remove RTL Values

* feat: allow for hint expansions

* Remove the left value on submit icon

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* add display none and remove their values

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-08 14:31:05 +01:00
Manabu Matsumoto
6ccbd94eff fix(UI): remove vertical scrollbar from body (#48231)
* fix: remove vertical scrollbar from body

* fix: adjust preview window with/without actionrow

* fix: delete redundant padding argument

* fix: add new props to project preview modal

* fix: adjust code and preview pane height

* fix: add flash message height adjustment for panes

* fix: refactor the code with flexbox

* fix: debug zero height of instruction panel in firefox

* fix: debug zero height of reflex elements and vertical splitter

* fix: make reflex elements vertically flexible in new RWD

* fix: remove unnecessary css properties

* fix: arrange mobile layout css selector

* fix: move styles to its related css files

* fix: refactor the code with pseudo selector and remove important

* fix: remove redundant flexbox settings

* fix: remove unnecessary css properties and revert unnecessary property name change

* fix: remove unnecessary min height zero and refactor flex properties
2022-11-22 11:18:00 +03:00
Ahmad Abdolsaheb
22c5533417 feat(client): add university and seasonal alerts (#48350)
* feat: add university and seasonal alerts

* feat: show university camper alerts to non donors

* feat: adjust tests

* feat: update CTA

* Apply suggestions from Oliver's code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* feat: changing learn alert to link

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-11-10 13:06:33 +00:00
Sem Bauke
8df880fa61 chore(client): update chinese redirects (#46220) 2022-11-10 01:16:45 +05:30
Tom
5f73773cd4 feat(client): move legacy rwd button to bottom of map (#47596)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/46523
2022-11-08 21:00:46 +05:30
Oliver Eyton-Williams
ecfe09c52d fix: confirm modal (#48388)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-11-04 11:06:47 +00:00
Mrugesh Mohapatra
75f4ff10d5 feat(client): add a confirmation modal on signout (#48385)
* feat(client): add a confirmation modal on signout

* test: add and update universal nav

* chore: remove extraneous action

* chore: apply suggestions from code review
2022-11-04 10:31:06 +01:00
Mrugesh Mohapatra
12beeee067 refactor: consistent layout imports (#48378) 2022-11-04 09:40:03 +02:00
Muhammed Mustafa
5ef777973a feat(client): refactor the buttons leading to the certifcations intro (#48320) 2022-10-31 18:11:51 -05:00
Muhammed Mustafa
3279ab161e feat(client): refactor universal nav missing types (#48144)
* feat(client): refactor universal nav missing types

* extends link type from gatsby link types


Co-authored-by: auchynnikau <viachaslau_auchynnikau@epam.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 20:20:59 +05:30
Atir Nayab
f92a851a0a feat(client): add icon in setting page button (#48268) 2022-10-27 20:06:47 +05:30
Mrugesh Mohapatra
b393d88b9e refactor: s/all-langs/i18n/g (#48258) 2022-10-26 10:08:27 -07:00
Muhammed Mustafa
6074cdf9c1 feat(client): clear ESLint comment in learn layout (#48154)
feat(client): clear enlist comment in learn layout
2022-10-24 11:00:02 +02:00
Oliver Eyton-Williams
129c110368 fix: only fetch growthbookUri in browser contexts (#48112) 2022-10-19 01:13:54 -07:00
Ahmad Abdolsaheb
0df7ee430d feat(client): add growthbook (#48003)
* feat: initial set up

* feat: useFeature setup

* feat: adjust attributes

* chore(client): remove ts-disables in growth-book-wrapper

* feat: pull growthbook uri from env

* feat: adjust the staff atribute

* feat: make linter happy

* feat: update recruitment message

* refactor: simplify types

* chore: delete unused config

* fix: update copy

* fix: add growthbookUri to expected env vars

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-17 14:53:25 +02:00
PakkuDon
e5f54cab5f chore(client): remove exports for unused types (#48004)
* chore(client): remove exports for unused types

* chore(client): remove unused type
2022-10-14 19:10:21 +05:30
Anubhav Jain
88c54192b9 fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Mrugesh Mohapatra
0885f4f4e4 fix: update url and status in sd-markup (#47978) 2022-10-11 20:27:34 +05:30
Hdanzo
e935d75edc feat(client,seo): add structured data for courses (#47659)
Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 16:51:23 +05:30
Prince Mendiratta
314f0e4ba6 fix: separate string to view code/project (#47890)
* fix: separate string to view code/project

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* feat: add test for certification rendering

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

* chore(lint): trailing newline at EOF

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
2022-10-08 10:11:21 +02:00
Danny Greenberg
93347ea285 fix(font): Replace Roboto Mono with Hack-ZeroSlash (#47767)
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-10-06 15:57:40 +00:00
Divyansh Singh
6dd8c6241b feat: add hidden skip-to-content button (#47577)
* feat: add skip-to-content button

* fix: remove content start ids from everywhere and add to default layout

* chore: format landing-top.tsx

* use single quotes in skip-to-content component

* include breadcrumbs in navigation

* linting fail fix

* use anchor tag instead of new component

* update challenge title snap

* fix(test): reliably move focus onto the editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-05 20:43:00 +02:00
Niraj Nandish
53164e71f1 fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00
Oliver Eyton-Williams
7d77a202ec feat(client): use updateMySocials not updateUserFlag (#46380)
* feat: use updateMySocials not updateUserFlag

* fix: replace updateUserFlag with updateMyTheme

* fix: show social icons

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: delete social booleans from client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-09-30 16:18:23 +03:00
Hdanzo
c4f7e45832 feat: standardize view button text (#47525)
* feat: standardize view button text

Add new translation keys Delete unused translation keys Fix tests broken with new functionalities

* Delete View variations in translations.json
Delete buttons tittle
Modify buttons text to be "View" or translated equivalent
Modify tests to query the buttons by role and name

Co-authored-by: HDAnzo <hdanzoategui@softwarenatura.com>
2022-09-30 10:39:33 +03:00
Oliver Eyton-Williams
d879e1df21 fix: stop mutating store when toggling settings (#47654) 2022-09-29 10:44:11 -05:00
Shaun Hamilton
73c3edb56a fix: certification to private on private timeline (#45562)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-29 00:00:22 +05:30
Muhammed Mustafa
afb861be9d fix(client): making misclicking sign out harder (#46644)
* added hover and focus effect on signout

* increase spacing by increasing the height

* I remembered why I hated react so much

* will come back after the meeting

* cleared 10 types error

* fix: make lang menu more keyboard accessible

* increased button specificity and switch to navlink to focus better

* added className for future style when the fuction is functional

* this is funny

* slowly comming together

* will create the function tomorrow morning

* signout is read only bug

* Removed the need for enlist

* Update client/src/components/Header/components/nav-links.tsx

* Update client/src/components/Header/components/nav-links.tsx

* Props fails, I am removing enlist errors and implementing types

* Update client/src/components/Header/components/nav-links.tsx

Co-authored-by: Moshe <shootermv@gmail.com>

* half of eslint no unsafe call

* No issue without this eslint as well

* Couldn't fix enlist issue

* same error

* Removed eslint error

* no-unsafe-member enlist error

* Clear enlist error

* cleared type errors

* remove eslint no unsafe memeber access

* no unsafe return eslint

* I have opened pandora box

* npm errors

* I am really lost

* Cleared some typescript errors, hopefully I can create the modal now

* added basic style and a plan

* modal show and hide functionality

Co-authored-by: wongwinnie198@gmail.com

* Revert "modal show and hide functionality"

This reverts commit 237e0b00c4.

* modal show and hide functionality

Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>

* clear type error

* interesting my first animation attempt failed

* removed the modal

* added color, it may be damaging accessiblity

* revert translation.json changes

* cleared unused types and type mistake I added before

* Revert key press naming changes

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* changed hover effect to danger variables and fix change language hover

Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>

* add lang manu height to gerenic selector

* remove redundant code, make cansel change stay color stay blue

* Revert me mess around

* prettier format

* test cypress interaction and if it accounts for mobile design

* Revert "test cypress interaction and if it accounts for mobile design"

This reverts commit 9b01e78156.

* refactor search form

* add missing value units

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Bruce B <bbsmooth@gmail.com>
Co-authored-by: Moshe <shootermv@gmail.com>
Co-authored-by: wongwinnie198 <wongwinnie198@gmail.com>
Co-authored-by: mmatsumoto1026 <mmatsumoto1026@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-09-28 15:57:14 +02:00
Shaun Hamilton
79c232c586 fix(client): prevent sound on every render (#47640) 2022-09-28 15:15:49 +09:00
Oliver Eyton-Williams
a2790190b2 refactor: saving portfolio items (#47635) 2022-09-27 21:10:01 +05:30
abe
67217160f6 fix: allow user to add one unsaved item at a time (#47567)
Co-authored-by: kravmaguy <flex4lease@gmail.com>
2022-09-27 12:17:58 +05:30
Sem Bauke
8c83a96e93 feat: volume slider campfire mode (#47259)
* feat: volume slider campire mode

* fix: set a play sound interval

* fix: set volume to 50% if there is no volume key

* fix: add correct colors to progress bar

* fix: remove IE support

* fix: get slide value working in Chrome

* fix: remove space

* fix: actually use volume in the editor

* fix: add aria-label

* fix: set volume if not present in store

* fix: use label instead

* Apply Naomi's review on Toms suggestion

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: linting

* Update client/i18n/locales/english/translations.json

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

Co-authored-by: root <root@DESKTOP-EMNPVBP.localdomain>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-09-15 15:42:03 +03:00
renovate[bot]
5ff719a4c8 fix(deps): update font awesome to v6.2.0 (#47443)
* fix(deps): update font awesome to v6.2.0

* fix: update snapshots

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-09-12 17:16:32 +05:30
kulraj chavda
acc966ac31 add visual separation in Change language menu UI (#47418)
add visual seperation in Change language menu UI
2022-09-08 13:16:27 +05:30
Manabu Matsumoto
145521b3d4 fix(UI): restore keyboard accessibility (#47427)
* fix: restore keyboard accessibility

* fix/ make code easier to maintain
2022-09-06 19:21:38 +02:00
Naomi Carrigan
5e402e6955 feat: allow languages to be hidden (#47362) 2022-08-23 20:53:47 +02:00
Tom
136f60bbef feat: move rdb order to middle of superblocks (#46138)
feat: move rdb out of beta
2022-08-10 18:48:39 +02:00
Naomi Carrigan
836ccb79b1 chore: resolve type coercion todo comment (#47036) 2022-07-28 09:18:08 +02:00
Bruce Blaser
0345244c43 fix(a11y): change headings in footer to h2 (#46932)
fix: change headings in footer to h2
2022-07-17 09:59:15 -07:00
renovate[bot]
f6f252eba8 chore(deps): update dependency eslint-plugin-react to v7.30.1 (#46664)
* chore(deps): update dependency eslint-plugin-react to v7.30.1

* fix: prettier

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-07-14 21:07:56 +05:30
Moshe
8d4d4d79e8 fix(ui): "sign in" button hidden at small devices (#46561)
* fix(UI): missing sign-in button at small devices

* feat: replace menu and sign-in buttons text with images

* refactor: svg icons replaced by fortawesome ones

* test: fix e2e test of navigation menu button

* feat: display sign in button and hide all

* feat: display sign in icon on nav for small screens

* feat: add accessibility span for menu icon

* fix: lint errors

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-07-12 08:15:52 -05:00
Oliver Eyton-Williams
9046d70b67 fix: use certification hours consistently (#46442)
* fix: use certification hours consistently

Since the value appearing on the /learn map was hardcoded, it could have
gone out of sync with the certifications, which were relying on
certification-settings.

Also, for simplicity (and because it's hard to estimate accurately), all
the certifications are set to 300 hours.  Fullstack being the exception,
as it is a set of certifications.

* feat: remove the hours from the map
2022-06-23 14:24:33 +03:00