Commit Graph

226 Commits

Author SHA1 Message Date
hbar1st
f975728c63 fix(curriculum): remove instruction about run button click (#49415) 2023-02-18 00:19:08 +00:00
Sriparno Roy
b5fcc389f0 fix(curriculum): Fix awkward phrasing (#49358)
* Fix awkward phrasing

* Remove sentence
2023-02-13 21:38:27 +01:00
MhemedAbderrahmen
33c5bc9406 fix: removed special characters from RTL titles (english) (#48998)
fix: removed special characters from RTL titles
2023-01-24 11:43:41 +02:00
mdnavarro21
0126389f18 fix(curriculum): update javascript challenge description (#48989)
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/48928
2023-01-11 10:39:12 +01:00
Oliver Eyton-Williams
4054cf8d06 fix: update comment to match dictionary (#48900) 2023-01-03 16:13:56 +05:30
ctbaird
7d90b9a179 fix(curriculum): replace instance of var with let (#48610)
fix(curriculum): replace var with let in scope challege english only

Co-authored-by: Catherine Baird <bairdc@cua.edu>
2022-11-28 13:46:50 +00:00
Jeremy L Thompson
8a01079b7a fix(curriculum): typo in example (#48534)
fix - typo in example
2022-11-17 17:24:47 -08:00
Atir Nayab
9b95c2d95e fix(curriculum): update object example in Using Objects for Lookups (#48422)
* fix(curriculum): update object example in Using Objects for Lookups

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/using-objects-for-lookups.md

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* fix(curriculum): description update in Using Objects for Lookups

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-11-09 01:37:22 +05:30
Andrew Dawes
95561b0cb4 fix(curriculum): several typos and grammar errors (#48210)
* Fixed several typos and grammar errors

* Revert to an because the context is english US

* Fixed some weird wording

* Switch a to an

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-25 13:38:21 +02:00
Niraj Nandish
441f11db38 feat: mobile curriculum testing (#47586)
* feat: first draft of action and cypress spec

* feat: test all generated challenges

* fix: better identification of block

* action: update cypress config

* action: upload to dashboard

* action: testing js cert challenges

* fix: unnecessary after user code for Make a Person

* feat: capture console log output for assert test

* fix: remove after seed code

* fix: change const to let

* fix: test

* action: disable js certification

* action: stop checking out branch in action

* action: check out right mobile repo

Co-authored-by: sembauke <semboot699@gmail.com>
2022-10-14 16:57:34 -07:00
abe
4ab1dd8926 fix(curriculum): recursion challenges that abuse global space (#47680)
* fix: recursion challenges that abuse global space #43516

* fix challenge phrasing and create separate test

* fix: challenges which pollute/impure functions should not pass

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects/cash-register.md

allow users to ab(use) global space in cash register

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/build-a-roman-numeral-converter-project/roman-numeral-converter.md

allow users to abuse global space in roman numeral converter

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 15:00:24 -05:00
Alekzandriia
a02cd6448c fix(learn): update verbiage to emphasize on \n instead of \r (#47841)
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 20:02:47 +02:00
Maciej Bąba
533c0345e4 fix(learn): lack of block code declaration (#47506)
Fix lack of block code declaration
2022-09-12 15:46:20 -07:00
Tuukka Hastrup
14076cbde0 fix(curriculum): Clarify understand-string-immutability (#47448)
* Clarify understand-string-immutability

Remove some misleading explanation (immutability is orthogonal to literals).

* Remove extraneous whitespace

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Improve explanation per review suggestion

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-09-07 19:35:41 +02:00
mjh
ab82857ab2 fix(curriculum): Made output for sample code in snippet clearer - Multidimensional Array Access (#47222)
* Made output for sample code in snippet clearer

* Made formatting more consistent

* Fixed names for formatting fix
2022-08-09 20:39:56 +00:00
Jeremy L Thompson
d0e42982f0 fix(curriculum) - simplify example of property access (#46967)
minor - simplify challenge examples
2022-07-21 09:05:26 -07:00
Randell Dawson
55b3fcef3b fix(curriculum): Add new tests to check for space between result strings for two JavaScript challenges involving string concatenation (#46833) 2022-07-10 19:39:52 +07:00
Dhruv Gajjar
a18639dc07 fix(curriculum): Dead code example in (#46825)
fix(curriculum): Dead code example in #46813
2022-07-10 09:06:12 +02:00
Randell Dawson
c7c9a5492d fix: remove duplicate test and make small change to recently added test for Counting Cards challenge (#46790)
fix: remove duplicate test
2022-07-07 08:50:29 -07:00
Randell Dawson
eca650dc69 fix: add test to validate result format has space between count value and text - Counting Cards challenge (#46782)
fix: add test to validate result format
2022-07-06 21:57:18 -07:00
Muhammed Mustafa
3e3da4ec0f fix(curriculum): standardize links in curriculum (#46564)
* fix(curriculum): standradize links in curriculum

* Data analiysis links

* CIP links

* fixed links in s-expressions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-hex-code-for-specific-colors.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* added space before target attribute

* standarize external and .rock example links

* wrap "check out the projects" around the links

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-06-26 11:13:38 -05:00
Ilenia
59abda3ff2 fix(curriculum, i18n): solve issues in crowdin comments (#46597) 2022-06-21 19:53:13 +05:30
Ivan Pavičić
258e9d0130 fix(curriculum): var keyword to global-scope-and-functions (#46553)
fix(curriculum): var to global-scope-and-functions

Added the `var` keyword in global-scope-and-functions challenge instructions to avoid confusion
2022-06-18 16:34:51 -07:00
Muhammed Mustafa
e474d4cd17 chore(curriculum): Front End catagories links standardized (#46418) 2022-06-13 20:18:23 -05:00
sidemt
6d7b49ffe0 fix(curriculum): remove reference to Mad Libs (#46490) 2022-06-13 20:56:38 +02:00
Muhammed Mustafa
5282994ad8 Chore(curriculum): removing copywriten wiki content (#46436)
* remove mad-labs link

* changed similar to wiki text in legacy JS

* let's go Sam got my back here as well

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-06-10 08:54:51 -05:00
Bill Cheng
8397129aaa fix(curriculum): Add test output to not change strings assigned to variables (#46353) 2022-06-05 10:51:36 -05:00
Titi
14bf77d3b8 chore: removed unneeded check for semicolon 2022-06-04 11:09:55 -05:00
Muhammed Mustafa
924fd04760 fix(curriculum): external golf wiki link in JS (#46170) 2022-05-27 10:51:40 +02:00
Muhammed Mustafa
864f4a199a fix(curriculum): removed link in JS basic-JavaScript (#46143)
* fix(curriculum): removed link in JS basic-javascript

* removed JSON and its example
2022-05-26 16:36:21 +02:00
Muhammed Mustafa
5b4dc4ab6d fix(curriculum): external Mad Libs link in JS steps (#46157) 2022-05-26 12:43:20 +05:30
Muhammed Mustafa
93f32b45e2 fix(curriculum): external card counting link in JS (#46158) 2022-05-26 12:42:39 +05:30
Muhammed Mustafa
f2592999f3 fix(curriculum): external floating link in JS (#46159)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-05-26 12:41:58 +05:30
Muhammed Mustafa
ddc55af8de fix(curriculum): external link in words blank JS (#46145) 2022-05-26 00:14:37 +07:00
Benjamin Lu
2da688fbfe fix(curriculum): add switch statement spaces for consistency (#46141)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2022-05-25 22:37:00 +05:30
Luke Harrison
e4c6883a20 fix(curriculum): updated wording on understanding uninitialized variables (#45860)
* updated wording on understanding uninitialized variables

* updated wording for case b to match case a

* updated case c to match the wording of both case a and b
2022-05-05 19:05:30 +02:00
Naomi Archibong
4ff9c2a6fc feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
JuumanBeing
c92a71e11e fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
Lenin Kennedy
a6d2660c7c fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
Suph
405675261d fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
Radi Totev
4d620dea1a fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
Naomi Carrigan
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
Kai Wei Mo
ce5b9b8aba fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
HenMoshe
d3304276ca fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
Naomi Carrigan
1c65d5d34a fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
HenMoshe
ea416b6dc2 fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
zelf0
3668422083 fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
Jagruti Tiwari
9b7d7ba716 fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
Madhu Sudhan Reddy Vinta
0a895dad47 fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
sanberkzulfikar
50b554470d fix(curriculum): wording consistency in counting-cards.md (#44390) 2021-12-08 07:32:56 -08:00