Commit Graph

63 Commits

Author SHA1 Message Date
JeevaRamanathan
d4e65df8b0 fix(curriculum): Updated tests to allow local variables to end with first/last (#52200) 2023-11-03 22:27:11 +07:00
Krzysztof G
3b25ed538b fix(curriculum): typos in curriculum code parts (#51884)
Co-authored-by: Viktor Szépe <viktor@szepe.net>
2023-10-10 10:12:37 +03:00
Jeremy L Thompson
e0036a1aaa Fix: Update Arguments Optional test to match instructions (#51510) 2023-09-19 13:51:21 -05:00
Lasse Jørgensen
18922fabe1 fix(curriculum): clarify challenge instructions (#51475) 2023-09-04 22:21:19 +07:00
Riya Dhawan
46596c54e4 fix(curriculum): test variable collision with common user variable (#51355) 2023-08-23 08:17:53 +02:00
Naomi Carrigan
d99a209123 feat: rewrite make a person challenge (#50942) 2023-07-11 14:06:40 -05:00
Faris Soliman
2d85fb6c71 fix(curriculum): added test case and resorted tests for arguments-optional page (#50404)
* fix: added test case and resorted tests

* fix: added test case and resorted tests

* updated test cases to match issue
2023-05-17 19:08:34 +02:00
EggSaled
69cd028cfc fix(curriculum): test suite no longer dependent on user variable (#50395)
* fix(curriculum): test cases no longer depends on variable accessible to user

* fix (curriculum): removed comments from seed code
2023-05-16 11:46:09 -07:00
Santiago Pereyra Vázquez
f25c89fa68 fix(curriculum): fix Fibonacci sequence text (#49452)
Fixed sum-all-odd-fibonacci-numbers.md text
2023-02-21 08:47:23 +01:00
Bryan Moore
d268822fe4 fix(curriculum): remove comments and extra code (#48531) 2022-11-17 15:15:12 -08:00
Niraj Nandish
441f11db38 feat: mobile curriculum testing (#47586)
* feat: first draft of action and cypress spec

* feat: test all generated challenges

* fix: better identification of block

* action: update cypress config

* action: upload to dashboard

* action: testing js cert challenges

* fix: unnecessary after user code for Make a Person

* feat: capture console log output for assert test

* fix: remove after seed code

* fix: change const to let

* fix: test

* action: disable js certification

* action: stop checking out branch in action

* action: check out right mobile repo

Co-authored-by: sembauke <semboot699@gmail.com>
2022-10-14 16:57:34 -07:00
abe
4ab1dd8926 fix(curriculum): recursion challenges that abuse global space (#47680)
* fix: recursion challenges that abuse global space #43516

* fix challenge phrasing and create separate test

* fix: challenges which pollute/impure functions should not pass

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects/cash-register.md

allow users to ab(use) global space in cash register

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/build-a-roman-numeral-converter-project/roman-numeral-converter.md

allow users to abuse global space in roman numeral converter

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 15:00:24 -05:00
Jeremy L Thompson
d1e65cfafa fix(curriculum): faster solution for primes (#47990) 2022-10-12 09:05:43 +02:00
Sameer Supe
3cc300127e fix(curriculum): test case for arguments optional (#47059)
* added test case for curriculum

* Revert "added test case for curriculum"

This reverts commit a23ee9d3cd.

* added test case for curriculum
2022-07-28 15:11:06 +02:00
Randell Dawson
2de9458c5b fix: added extra test to prevent incorrect solution from passing for the Wherefore art thou challenge (#46959)
fix: added extra test to stop incorrect solution
2022-07-20 08:58:42 -05:00
Ilenia
237f11be8b chore: change type of challenges to type 1 js (#46826) 2022-07-11 11:06:08 +02:00
Dario-DC
1bba1b15e7 fix(curriculum): inaccuracy in dna pairing challenge (#46647)
fix inaccuracy in dna pairing challenge
2022-06-24 17:20:58 +02:00
Muhammed Mustafa
e15889a53e fix(curriculum): external orbital link in legacy JSA (#46266)
* fix(curriculum): external orbital link in legacy JSA

* Shaun for the rescue

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-06-01 07:53:44 -07:00
Muhammed Mustafa
9f73059c03 fix(curriculum): external wiki link in JS A&DS (#46144)
* fix(curriculum): external wiki link in JS A&DS

* reorder the phrases
2022-05-25 10:50:19 -07:00
Anjum Iqbal
aa7c58f7e5 fix(curriculum): add missing quotation marks (#45460) 2022-03-18 18:28:42 +01:00
Naomi Carrigan
dab600b4b1 chore: refactor the everything be true challenge (#45433) 2022-03-16 08:29:46 -07:00
Poonkuzhali
f4077cab7f feat: added new test case to argument optional challenge (#45076) 2022-02-10 17:17:07 -06:00
Vaibhav
9ffc7b4711 fix(curriculum): add two edge test cases to the sorted union problem (#44860)
* fix: fixed solution of sorted union

* fix: improved solution of sorted union problem
2022-02-02 19:28:31 +01:00
Kristofer Koishigawa
bcc9beff1f feat(curriculum): introduce let and const earlier (#43133)
* fix: move "Explore Differences Between..." to basic JS, update seed and tests

* fix: resequence "Declare String Variables"

* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests

* fix: revert changes to non-English "Explore Differences Between..." test text

* fix: revert test strings, solutions, and seeds for non-English challenges

* fix: update "Declare String Variables" description

* fix: sync quotation marks in description and seed

* fix: modify note in "Declare a Read-Only..." challenge

* fix: update operator and compound assignment challenges

* fix: update string challenges

* fix: update array and array method challenges

* fix: update function and scope challenges, resequence slightly

* fix: "Word Blanks" solution

* fix: add spacing to seed

* fix: concatenating += challenge spacing

* fix: appending variables to strings spacing

* fix: find the length of a string spacing

* fix: removed instances of removedFromMyArray = 0

* fix: switch challenges

* fix: function argument and param spacing

* fix: update counting cards, object challenges, and record collection

* fix: finish rest of Basic JS section

* fix: introducing else statements solution

* fix: update spacing and wording

* fix: update wording for const challenge

* fix: update functional programming challenges

* fix: intermediate algorithms and cert challenges

* fix: revert some spacing and remove comments for fp challenge solutions

* feat: add notes with links to moved let and const challenges in first two es6 challenges

* fix: update es6 intro text

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: concatenating strings with plus operator seed

* fix: add comments back to Declare a Read-Only Variable... seed

* feat: add es6 to basic javascript redirect tests for let and const challenges

* fix: revert "Concatenating Strings with Plus Operator" seed

* fix: move test file to cypress/integration/learn/redirects, separate redirect tests

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-25 17:55:58 +01:00
Jeremy L Thompson
b8b86a65b8 fix issue #42850, test for setters adding properties (#43813) 2021-10-14 15:58:13 +02:00
Kristofer Koishigawa
8c9ca6a2fa fix: replace JS algorithms and data structures bitly links (#41813) 2021-09-21 16:46:25 +01:00
Randell Dawson
b5ed2619eb fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
Nicholas Carrigan (he/him)
7117919d36 chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams
0bd52f8bd1 Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Oliver Eyton-Williams
2b9e38a17b fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Sky020
a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Oliver Eyton-Williams
bd68b70f3d Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
dyneskye
f52baa51be fix(learn): Added test for Capitalized -> uncapitalized variants
* myReplace("I think we should look up there", "up", "Down")
* Checks for previously unchecked scanarios of the 'after' input being capitalized and 'before' word being uncapitalized.
2020-08-03 14:52:40 +03:00
Kushagra
be4070a73d fix(curriculum): improve test robustness (#39004)
* Add: // Only change code...comments

* Allow user to modify bob
2020-06-13 11:47:06 +02:00
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Rajat Singh
bdbf5bfd8d fix:Added extra test cases for 'arguments-optional' problem (#38827) 2020-05-21 14:56:06 +05:30
Twaha Rahman
c0e2b65864 Wrapped all the test results with quotation (#38706) 2020-05-02 09:25:55 -05:00
Ashraf Nazar
c2558b3816 fix(Curriculum): ensure code that includes and is not equal to the fl… (#38497)
* fix(Curriculum): ensure code that includes and is not equal to the flat or flatMap methods do not fail the test suite

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/steamroller.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update steamroller.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-23 14:59:58 -05:00
Joseph Crandal
f142eed6ef Fix pig latin challenge description (#38018)
* Fix pig latin challenge description

Added statement for beginning with consonants and if a vowel does not begin with a vowel.

* fix: update description/instructions

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-26 23:38:07 +01:00
Hassaan Pasha
4fbce07792 fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise (#38214)
* fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise

* fix: fixing regex pattern
2020-03-26 08:13:34 -07:00
Tom
17a55c6e18 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Josh Soref
004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Kiara Barias
afd467f5dc Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
Hassaan Pasha
d89eae392f fix: adding test to check if flat or flatMap method was used in the steamroller challenge (#38158)
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge

* Addressed comments and acknowledged suggestions
2020-02-04 17:00:33 -05:00
Tom
da99033b77 fix: sum all primes description (#37750)
* fix: sum all primes description

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-30 16:33:37 -06:00
Mo Zargham
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753)
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
2019-11-19 19:54:48 -05:00
Randell Dawson
3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson
ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson
d78168f7db fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 03 (#36403)
* fix: rm assert msg basic-data-structures

* fix: rm assert msg intermed-algo-scripting

* fix: rm assert msg data-structures projects
2019-07-24 10:56:38 +02:00