mirror of
https://github.com/google/glazier.git
synced 2025-12-19 18:27:35 -05:00
Split helpers tests between windows-specific and generic.
PiperOrigin-RevId: 437767984
This commit is contained in:
Matt LaPlante
committed by
Copybara-Service
Copybara-Service
parent
25552b8222
commit
914b189bff
@@ -15,193 +15,11 @@
|
||||
package helpers
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"regexp"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/google/go-cmp/cmp"
|
||||
so "github.com/iamacarpet/go-win64api/shared"
|
||||
)
|
||||
|
||||
func TestVerify(t *testing.T) {
|
||||
err1 := errors.New("direct error")
|
||||
def := NewExecVerifier()
|
||||
tests := []struct {
|
||||
ver ExecVerifier
|
||||
res ExecResult
|
||||
want error
|
||||
}{
|
||||
{*def, ExecResult{ExitErr: err1}, err1},
|
||||
{*def, ExecResult{ExitCode: 1}, ErrExitCode},
|
||||
{ExecVerifier{SuccessCodes: []int{2, 3, 4}}, ExecResult{ExitCode: 3}, nil},
|
||||
{ExecVerifier{SuccessCodes: []int{2, 3, 4}}, ExecResult{ExitCode: 5}, ErrExitCode},
|
||||
{*def, ExecResult{
|
||||
Stdout: []byte("This is harmless output."),
|
||||
Stderr: []byte("This too."),
|
||||
}, nil},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stdout: []byte("This is harmless output."),
|
||||
Stderr: []byte("This too."),
|
||||
}, nil},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stdout: []byte("This is harmful output."),
|
||||
Stderr: []byte("This isn't."),
|
||||
}, ErrStdOut},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stderr: []byte("This is harmful output."),
|
||||
Stdout: []byte("This isn't."),
|
||||
}, ErrStdErr},
|
||||
}
|
||||
for i, tt := range tests {
|
||||
testID := fmt.Sprintf("Test%d", i)
|
||||
t.Run(testID, func(t *testing.T) {
|
||||
_, got := verify(testID, tt.res, tt.ver)
|
||||
if !errors.Is(got, tt.want) {
|
||||
t.Errorf("got %v; want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestExecWithRetry(t *testing.T) {
|
||||
tests := []struct {
|
||||
inConf *ExecConfig
|
||||
inErr []error
|
||||
inRes []ExecResult
|
||||
wantErr error
|
||||
wantRes ExecResult
|
||||
}{
|
||||
// defaults used; success on first try
|
||||
{nil, []error{nil},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
}, nil,
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
},
|
||||
// defaults used; error on first try
|
||||
{nil, []error{ErrStdErr},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
}, ErrStdErr,
|
||||
ExecResult{},
|
||||
},
|
||||
// success on third try
|
||||
{&ExecConfig{RetryCount: 3},
|
||||
[]error{ErrStdErr, ErrStdErr, nil},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
ExecResult{Stdout: []byte("Result 2")},
|
||||
ExecResult{Stdout: []byte("Result 3")},
|
||||
}, nil,
|
||||
ExecResult{Stdout: []byte("Result 3")},
|
||||
},
|
||||
}
|
||||
fnSleep = func(time.Duration) {}
|
||||
for i, tt := range tests {
|
||||
testID := fmt.Sprintf("Test%d", i)
|
||||
t.Run(testID, func(t *testing.T) {
|
||||
ci := -1
|
||||
fnExec = func(string, []string, *ExecConfig) (ExecResult, error) {
|
||||
ci++
|
||||
if ci >= len(tt.inErr) {
|
||||
t.Fatalf("ran out of return values...")
|
||||
}
|
||||
return tt.inRes[ci], tt.inErr[ci]
|
||||
}
|
||||
got, err := Exec("test-process", []string{}, tt.inConf)
|
||||
if !errors.Is(err, tt.wantErr) {
|
||||
t.Errorf("Exec(%s): got %v; want %v", testID, err, tt.wantErr)
|
||||
}
|
||||
diff := cmp.Diff(got, tt.wantRes)
|
||||
if err == nil && diff != "" {
|
||||
t.Errorf("Exec(%s): returned unexpected differences (-want +got):\n%s", testID, diff)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestWaitForProcessExit(t *testing.T) {
|
||||
tests := []struct {
|
||||
match string
|
||||
plists [][]so.Process
|
||||
timeout time.Duration
|
||||
want error
|
||||
}{
|
||||
// not running
|
||||
{"proc1", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
}, 20 * time.Second, nil},
|
||||
// stops within timeout
|
||||
{"proc2", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "otherproc"},
|
||||
so.Process{Executable: "proc2"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "otherproc"},
|
||||
so.Process{Executable: "proc1"},
|
||||
},
|
||||
}, 20 * time.Second, nil},
|
||||
// never stops
|
||||
{"proc2", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
}, 15 * time.Second, ErrTimeout},
|
||||
}
|
||||
for i, tt := range tests {
|
||||
t.Run(fmt.Sprintf("Test%d", i), func(t *testing.T) {
|
||||
ci := -1
|
||||
fnProcessList = func() ([]so.Process, error) {
|
||||
ci++
|
||||
if ci >= len(tt.plists) {
|
||||
t.Fatalf("ran out of return values...")
|
||||
}
|
||||
return tt.plists[ci], nil
|
||||
}
|
||||
re := regexp.MustCompile(tt.match)
|
||||
got := WaitForProcessExit(re, tt.timeout)
|
||||
if !errors.Is(got, tt.want) {
|
||||
t.Errorf("got %v; want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestContainsString(t *testing.T) {
|
||||
tests := []struct {
|
||||
in []string
|
||||
|
||||
206
go/helpers/helpers_windows_test.go
Normal file
206
go/helpers/helpers_windows_test.go
Normal file
@@ -0,0 +1,206 @@
|
||||
// Copyright 2021 Google LLC
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
//go:build windows
|
||||
// +build windows
|
||||
|
||||
package helpers
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"regexp"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/google/go-cmp/cmp"
|
||||
so "github.com/iamacarpet/go-win64api/shared"
|
||||
)
|
||||
|
||||
func TestVerify(t *testing.T) {
|
||||
err1 := errors.New("direct error")
|
||||
def := NewExecVerifier()
|
||||
tests := []struct {
|
||||
ver ExecVerifier
|
||||
res ExecResult
|
||||
want error
|
||||
}{
|
||||
{*def, ExecResult{ExitErr: err1}, err1},
|
||||
{*def, ExecResult{ExitCode: 1}, ErrExitCode},
|
||||
{ExecVerifier{SuccessCodes: []int{2, 3, 4}}, ExecResult{ExitCode: 3}, nil},
|
||||
{ExecVerifier{SuccessCodes: []int{2, 3, 4}}, ExecResult{ExitCode: 5}, ErrExitCode},
|
||||
{*def, ExecResult{
|
||||
Stdout: []byte("This is harmless output."),
|
||||
Stderr: []byte("This too."),
|
||||
}, nil},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stdout: []byte("This is harmless output."),
|
||||
Stderr: []byte("This too."),
|
||||
}, nil},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stdout: []byte("This is harmful output."),
|
||||
Stderr: []byte("This isn't."),
|
||||
}, ErrStdOut},
|
||||
{ExecVerifier{
|
||||
SuccessCodes: []int{0},
|
||||
StdOutMatch: regexp.MustCompile(".*harmful.*"),
|
||||
StdErrMatch: regexp.MustCompile(".*harmful.*"),
|
||||
}, ExecResult{
|
||||
Stderr: []byte("This is harmful output."),
|
||||
Stdout: []byte("This isn't."),
|
||||
}, ErrStdErr},
|
||||
}
|
||||
for i, tt := range tests {
|
||||
testID := fmt.Sprintf("Test%d", i)
|
||||
t.Run(testID, func(t *testing.T) {
|
||||
_, got := verify(testID, tt.res, tt.ver)
|
||||
if !errors.Is(got, tt.want) {
|
||||
t.Errorf("got %v; want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestExecWithRetry(t *testing.T) {
|
||||
tests := []struct {
|
||||
inConf *ExecConfig
|
||||
inErr []error
|
||||
inRes []ExecResult
|
||||
wantErr error
|
||||
wantRes ExecResult
|
||||
}{
|
||||
// defaults used; success on first try
|
||||
{nil, []error{nil},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
}, nil,
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
},
|
||||
// defaults used; error on first try
|
||||
{nil, []error{ErrStdErr},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
}, ErrStdErr,
|
||||
ExecResult{},
|
||||
},
|
||||
// success on third try
|
||||
{&ExecConfig{RetryCount: 3},
|
||||
[]error{ErrStdErr, ErrStdErr, nil},
|
||||
[]ExecResult{
|
||||
ExecResult{Stdout: []byte("Result 1")},
|
||||
ExecResult{Stdout: []byte("Result 2")},
|
||||
ExecResult{Stdout: []byte("Result 3")},
|
||||
}, nil,
|
||||
ExecResult{Stdout: []byte("Result 3")},
|
||||
},
|
||||
}
|
||||
fnSleep = func(time.Duration) {}
|
||||
for i, tt := range tests {
|
||||
testID := fmt.Sprintf("Test%d", i)
|
||||
t.Run(testID, func(t *testing.T) {
|
||||
ci := -1
|
||||
fnExec = func(string, []string, *ExecConfig) (ExecResult, error) {
|
||||
ci++
|
||||
if ci >= len(tt.inErr) {
|
||||
t.Fatalf("ran out of return values...")
|
||||
}
|
||||
return tt.inRes[ci], tt.inErr[ci]
|
||||
}
|
||||
got, err := Exec("test-process", []string{}, tt.inConf)
|
||||
if !errors.Is(err, tt.wantErr) {
|
||||
t.Errorf("Exec(%s): got %v; want %v", testID, err, tt.wantErr)
|
||||
}
|
||||
diff := cmp.Diff(got, tt.wantRes)
|
||||
if err == nil && diff != "" {
|
||||
t.Errorf("Exec(%s): returned unexpected differences (-want +got):\n%s", testID, diff)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestWaitForProcessExit(t *testing.T) {
|
||||
tests := []struct {
|
||||
match string
|
||||
plists [][]so.Process
|
||||
timeout time.Duration
|
||||
want error
|
||||
}{
|
||||
// not running
|
||||
{"proc1", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
}, 20 * time.Second, nil},
|
||||
// stops within timeout
|
||||
{"proc2", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "otherproc"},
|
||||
so.Process{Executable: "proc2"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "otherproc"},
|
||||
so.Process{Executable: "proc1"},
|
||||
},
|
||||
}, 20 * time.Second, nil},
|
||||
// never stops
|
||||
{"proc2", [][]so.Process{
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
[]so.Process{
|
||||
so.Process{Executable: "proc2"},
|
||||
so.Process{Executable: "otherproc"},
|
||||
},
|
||||
}, 15 * time.Second, ErrTimeout},
|
||||
}
|
||||
for i, tt := range tests {
|
||||
t.Run(fmt.Sprintf("Test%d", i), func(t *testing.T) {
|
||||
ci := -1
|
||||
fnProcessList = func() ([]so.Process, error) {
|
||||
ci++
|
||||
if ci >= len(tt.plists) {
|
||||
t.Fatalf("ran out of return values...")
|
||||
}
|
||||
return tt.plists[ci], nil
|
||||
}
|
||||
re := regexp.MustCompile(tt.match)
|
||||
got := WaitForProcessExit(re, tt.timeout)
|
||||
if !errors.Is(got, tt.want) {
|
||||
t.Errorf("got %v; want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user