From 0ea4a666dc12e093cc12ca4cd640f0ede51661a2 Mon Sep 17 00:00:00 2001 From: Jim Apple Date: Fri, 11 Nov 2016 12:05:30 -0800 Subject: [PATCH] IMPALA-4433: Always generate testdata using the same time zone setting Before this change, testdata was generated using the java.util.TimeZone.getDefault() TimeZone of the machine it was running on. This patch standardizes on "America/Los_Angeles", which matches the existing expected results in the end-to-end tests. Change-Id: Iaf7cc796e44e9ff64880f9ae852f40961592f279 Reviewed-on: http://gerrit.cloudera.org:8080/5058 Reviewed-by: Jim Apple Tested-by: Internal Jenkins --- .../org/apache/impala/datagenerator/TestDataGenerator.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java b/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java index 7753ac064..29fd0d7a1 100644 --- a/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java +++ b/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java @@ -25,6 +25,7 @@ import java.math.BigDecimal; import java.text.SimpleDateFormat; import java.util.Calendar; import java.util.GregorianCalendar; +import java.util.TimeZone; class TestDataGenerator { // 2 years @@ -152,6 +153,10 @@ class TestDataGenerator { System.err.println("Usage: " + "TestDataGenerator BaseOutputDirectory"); } + // The TimeZone should be the same no matter what the TimeZone is of the computer + // running this code, in order to ensure the generated data is always the same. + TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles")); + // Generate AllTypes String dirName = args[0] + "/AllTypes"; File dir = new File(dirName);