jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 09:58:28 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14180: Fix imported query profiles navbar and datetime

Browse Source 
This change corrects the improper rendering of nanosecond walltime
event timestamps in the text profile section of imported query profiles.

The timestamps are now displayed in minutes and seconds, instead of
being displayed in date format. (i.e. 2s120ms, 2ms498us)

The navbar rendering from incorrect declaration in webUI ES6 refactor
IMPALA-13389 has also been corrected.

Incorrectly added columns "Coordinator Slots" and "Executor Slots" in
IMPALA-13726: Add admission control slots to /queries page in webui
have been removed from the imported query profile section.

Change-Id: Id1ad10f469aec085e5b485b4c20d6ab89fe58034
Reviewed-on: http://gerrit.cloudera.org:8080/23067
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Surya Hebbar
2025-06-18 19:54:26 +05:30
committed by Impala Public Jenkins
parent 85a2211bfb
commit 1144d728d7
5 changed files with 53 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
www/queries.tmpl
View File

@@ -270,8 +270,6 @@ command line parameter.</p>
<th title="{{tips_state}}">State</th>
<th title="{{tips_rows_fetched}}"># rows fetched</th>
<th title="{{tips_resource_pool}}">Resource Pool</th>
<th title="{{tips_coordinator_slots}}">Coordinator Slots</th>
<th title="{{tips_executor_slots}}">Executor Slots</th>
<th title="{{tips_statement}}">Statement</th>
<th>Delete</th>
</tr>

2
www/query_plan_text.tmpl
View File

@@ -39,7 +39,7 @@ if (window.location.search.includes("imported")) {
if (alert_message) {
alert_message.remove();
}
const nav_links = document.getElementsByClassName("nav nav-tabs")[0];
let nav_links = document.getElementsByClassName("nav nav-tabs")[0];
nav_links = nav_links.getElementsByClassName("nav-link");
for (let i = 0; i < nav_links.length;) {
if (supported_tabs.includes(nav_links[i].textContent)) {

52
www/query_profile.tmpl
View File

@@ -54,6 +54,54 @@ let db;
const supported_tabs = ["Query", "Timeline", "Text plan", "Profile"];
function formatNanoseconds(ns) {
const NS_IN_US = 1_000;
const NS_IN_MS = 1_000_000;
const NS_IN_SEC = 1_000_000_000;
const NS_IN_MIN = 60 * NS_IN_SEC;
const NS_IN_HOUR = 60 * NS_IN_MIN;
let remaining = ns;
const parts = [];
const hours = Math.floor(remaining / NS_IN_HOUR);
if (hours > 0) {
parts.push(`${hours}h`);
remaining %= NS_IN_HOUR;
}
const minutes = Math.floor(remaining / NS_IN_MIN);
if (minutes > 0) {
parts.push(`${minutes}m`);
remaining %= NS_IN_MIN;
}
const seconds = Math.floor(remaining / NS_IN_SEC);
if (parts.length < 2 && seconds > 0) {
parts.push(`${seconds}s`);
remaining %= NS_IN_SEC;
}
const milliseconds = Math.floor(remaining / NS_IN_MS);
if (parts.length < 2 && milliseconds > 0) {
parts.push(`${milliseconds}ms`);
remaining %= NS_IN_MS;
}
const microseconds = Math.floor(remaining / NS_IN_US);
if (parts.length < 2 && microseconds > 0) {
parts.push(`${microseconds}us`);
remaining %= NS_IN_US;
}
if (parts.length < 2 && remaining > 0) {
parts.push(`${remaining}ns`);
}
// If input was 0 ns
return parts.length ? parts.join('') : '0ns';
}
function profileToString(profile, indent="") {
let info_strings = "";
if (profile.info_strings) {
@@ -68,7 +116,7 @@ function profileToString(profile, indent="") {
event_sequences = `${event_sequences}${indent} Offset: ${eventSeq.offset}\n`;
event_sequences = `${event_sequences}${indent} Events:\n`;
eventSeq.events.forEach(event => {
event_sequences = `${event_sequences}${indent} ${event.label}: ${new Date(event.timestamp).toISOString()}\n`;
event_sequences = `${event_sequences}${indent} ${event.label}: ${formatNanoseconds(event.timestamp)}\n`;
});
});
}
@@ -98,7 +146,7 @@ if (window.location.search.includes("imported")) {
if (alert_message) {
alert_message.remove();
}
const nav_links = document.getElementsByClassName("nav nav-tabs")[0];
let nav_links = document.getElementsByClassName("nav nav-tabs")[0];
nav_links = nav_links.getElementsByClassName("nav-link");
for (let i = 0; i < nav_links.length;) {
if (supported_tabs.includes(nav_links[i].textContent)) {

2
www/query_stmt.tmpl
View File

@@ -49,7 +49,7 @@ if (window.location.search.includes("imported")) {
if (alert_message) {
alert_message.remove();
}
const nav_links = document.getElementsByClassName("nav nav-tabs")[0];
let nav_links = document.getElementsByClassName("nav nav-tabs")[0];
nav_links = nav_links.getElementsByClassName("nav-link");
for (let i = 0; i < nav_links.length;) {
if (supported_tabs.includes(nav_links[i].textContent)) {

2
www/query_timeline.tmpl
View File

@@ -200,7 +200,7 @@ if (window.location.search.includes("imported")) {
if (alert_message) {
alert_message.remove();
}
const nav_links = document.getElementsByClassName("nav nav-tabs")[0];
let nav_links = document.getElementsByClassName("nav nav-tabs")[0];
nav_links = nav_links.getElementsByClassName("nav-link");
for (let i = 0; i < nav_links.length;) {
if (supported_tabs.includes(nav_links[i].textContent)) {