jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2026-01-04 09:00:56 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-6435: Disable codegen for CHAR literals.

Browse Source 
Currently we do not codegen CHAR types. This change checks
for CHAR literals in a expr and disables codegen.

Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73
Reviewed-on: http://gerrit.cloudera.org:8080/9102
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
This commit is contained in:
aphadke
2018-01-23 09:58:44 -08:00
committed by Impala Public Jenkins
parent 674d29d71d
commit 11d1784c0a
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test vendored
View File

@@ -28,3 +28,19 @@ bigint
# Verify that codegen was disabled
row_regex: .*Codegen Disabled: disabled due to optimization hints.*
====
---- QUERY
# IMPALA-6435: We do not codegen char columns. This fix checks for a
# CHAR type literal in the expr and disables codegen. This query will crash
# impala without the fix.
select count(*) from (
select cast('a' as char(4)) as s from functional.alltypestiny
union all
select cast('a' as char(4)) as s from functional.alltypestiny
union all
select cast(NULL as char(4)) as s from functional.alltypestiny
) t
---- RESULTS
24
---- TYPES
bigint
====