mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
IMPALA-11952 (part 2): Fix print function syntax
Python 3 now treats print as a function and requires
the parenthesis in invocation.
print "Hello World!"
is now:
print("Hello World!")
This fixes all locations to use the function
invocation. This is more complicated when the output
is being redirected to a file or when avoiding the
usual newline.
print >> sys.stderr , "Hello World!"
is now:
print("Hello World!", file=sys.stderr)
To support this properly and guarantee equivalent behavior
between python 2 and python 3, all files that use print
now add this import:
from __future__ import print_function
This also fixes random flake8 issues that intersect with
the changes.
Testing:
- check-python-syntax.sh shows no errors related to print
Change-Id: Ib634958369ad777a41e72d80c8053b74384ac351
Reviewed-on: http://gerrit.cloudera.org:8080/19552
Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com>
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Tested-by: Michael Smith <michael.smith@cloudera.com>
This commit is contained in:
@@ -19,6 +19,7 @@
|
||||
# A collection of useful Python GDB modules and commands for
|
||||
# debugging Impala core dumps.
|
||||
#
|
||||
from __future__ import print_function
|
||||
import gdb
|
||||
from collections import defaultdict
|
||||
|
||||
|
||||
@@ -21,6 +21,7 @@ A script for generating arbitrary junit XML reports while building Impala.
|
||||
These files will be consumed by jenkins.impala.io to generate reports for
|
||||
easier triaging of build and setup errors.
|
||||
"""
|
||||
from __future__ import print_function
|
||||
import argparse
|
||||
import codecs
|
||||
import errno
|
||||
|
||||
@@ -18,6 +18,7 @@
|
||||
|
||||
# This file contains library functions to decode and access Impala query profiles.
|
||||
|
||||
from __future__ import print_function
|
||||
import base64
|
||||
import datetime
|
||||
import zlib
|
||||
@@ -30,7 +31,7 @@ def decode_profile_line(line):
|
||||
space_separated = line.split(" ")
|
||||
if len(space_separated) == 3:
|
||||
ts = int(space_separated[0])
|
||||
print datetime.datetime.fromtimestamp(ts / 1000.0).isoformat(), space_separated[1]
|
||||
print(datetime.datetime.fromtimestamp(ts / 1000.0).isoformat(), space_separated[1])
|
||||
base64_encoded = space_separated[2]
|
||||
elif len(space_separated) == 1:
|
||||
base64_encoded = space_separated[0]
|
||||
|
||||
Reference in New Issue
Block a user