jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13617: Rename c_last_review_date to c_last_review_date_sk

Browse Source 
TPC-DS v2.11.0, section 2.4.7, rename column customer.c_last_review_date
to customer.c_last_review_date_sk to align with other surrogate key
columns. impala-tpcds-kit has been modified to reflect this column name
change in
086d7113c8
However, the tpcds dataset schema in Impala test data remains unchanged.

This patch did such a rename to align closer to TPC-DS v2.11.0. This
patch contains no data type adjustment because such adjustment requires
larger changes.

customer_multiblock_page_index.parquet added by IMPALA-10310 is
regenerated to follow the new schema of table customer. The SQL used to
create the file is ordered more specifically over both
c_current_cdemo_sk and c_customer_sk columns. The associated test
assertion in parquet-page-index.test is also updated.

A workaround in test_file_parser.py added by IMPALA-13543 is now removed
after this change is applied.

Testing:
- Pass core tests.

Change-Id: Ie446b3c534cb8f6f54265cd9b2f705cad91dd4ac
Reviewed-on: http://gerrit.cloudera.org:8080/22223
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Riza Suminto
2024-12-16 15:53:42 -08:00
committed by Impala Public Jenkins
parent f8f2020391
commit 2f5aef64a5
18 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/topics/impala_show.xml
View File

@@ -1121,7 +1121,7 @@ show table stats store_sales;
| c_birth_country | STRING | -1 | -1 | -1 | -1 |
| c_login | STRING | -1 | -1 | -1 | -1 |
| c_email_address | STRING | -1 | -1 | -1 | -1 |
| c_last_review_date | STRING | -1 | -1 | -1 | -1 |
| c_last_review_date_sk | STRING | -1 | -1 | -1 | -1 |
+------------------------+--------+------------------+--------+----------+----------+
show column stats store_sales;
@@ -1196,7 +1196,7 @@ show column stats customer;
| c_birth_country | STRING | 205 | -1 | 20 | 8.4001 |
| c_login | STRING | 1 | -1 | 0 | 0 |
| c_email_address | STRING | 94492 | -1 | 46 | 26.485 |
| c_last_review_date | STRING | 349 | -1 | 7 | 6.7561 |
| c_last_review_date_sk | STRING | 349 | -1 | 7 | 6.7561 |
+------------------------+--------+------------------+--------+----------+--------+
show column stats store_sales;

4
docs/topics/impala_tutorial.xml
View File

@@ -250,7 +250,7 @@ Welcome to the Impala shell. Press TAB twice to see a list of available commands
| c_birth_country | string | |
| c_login | string | |
| c_email_address | string | |
| c_last_review_date | string | |
| c_last_review_date_sk | string | |
+------------------------+--------+---------+
[localhost:21000] > select count(*) from customer;
+----------+
@@ -724,7 +724,7 @@ create external table customer
c_birth_country string,
c_login string,
c_email_address string,
c_last_review_date string
c_last_review_date_sk string
)
row format delimited fields terminated by '|'
location '/user/hive/tpcds/customer';