jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-23 21:08:39 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-7783: Skip test_default_timezone when testing a real cluster.

Browse Source 
test_shell_commandline.py::test_default_timezone assumes that the
cluster is running on the same platform as the test process, but
that's only guaranteed when the testing a local minicluster. When
run against a real cluster, the test executor can be a completely
different OS.

Change-Id: Ia4d4c503d2c77136cedd8f3fd830b6ce70d4457f
Reviewed-on: http://gerrit.cloudera.org:8080/11820
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
David Knupp
2018-10-29 14:59:35 -07:00
committed by Impala Public Jenkins
parent 932bf2dd81
commit 4c923b29d8
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/shell/test_shell_commandline.py
View File

@@ -730,11 +730,17 @@ class TestImpalaShell(ImpalaTestSuite):
finally:
os.remove(sql_path)
@pytest.mark.skipif(pytest.config.option.testing_remote_cluster,
reason='Test assumes a minicluster.')
def test_default_timezone(self):
"""Test that the default TIMEZONE query option is a valid timezone.
It would be nice to check that the default timezone is the system's timezone,
but doing this reliably on different Linux distributions is quite hard.
We skip this test on non-local clusters because the result_set from the
cluster is platform specific, but there's no guarantee the local machine
is the same OS, and the assert fails if there's a mismatch.
"""
result_set = run_impala_shell_cmd('-q "set;"')
tzname = find_query_option("TIMEZONE", result_set.stdout)