jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14454: Exclude log4j 2 dependencies

Browse Source 
While we use reload4j, we can safely exclude log4j 2 dependencies to
reduce the size of our artifacts.

Change-Id: Ic060bdd969a6e5cd01646376b27c7355ce841819
Reviewed-on: http://gerrit.cloudera.org:8080/23439
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Csaba Ringhofer <csringhofer@cloudera.com>
Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com>
This commit is contained in:
Michael Smith
2025-09-18 14:10:40 -07:00
parent 16c350ce5a
commit 52b87fcefd
4 changed files with 9 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bin/impala-config.sh
View File

@@ -283,7 +283,6 @@ export IMPALA_JACKSON_DATABIND_VERSION=2.15.3
export IMPALA_JSON_SMART_VERSION=2.4.11 export IMPALA_JSON_SMART_VERSION=2.4.11
export IMPALA_JUNIT_VERSION=4.12 export IMPALA_JUNIT_VERSION=4.12
export IMPALA_KITE_VERSION=1.1.0 export IMPALA_KITE_VERSION=1.1.0
export IMPALA_LOG4J2_VERSION=2.18.0
export IMPALA_ORC_JAVA_VERSION=1.7.6 export IMPALA_ORC_JAVA_VERSION=1.7.6
export IMPALA_PAC4J_VERSION=4.5.5 export IMPALA_PAC4J_VERSION=4.5.5
export IMPALA_RELOAD4j_VERSION=1.2.22 export IMPALA_RELOAD4j_VERSION=1.2.22

24
fe/pom.xml
View File

@@ -369,18 +369,15 @@ under the License.
<groupId>org.apache.hbase</groupId> <groupId>org.apache.hbase</groupId>
<artifactId>*</artifactId> <artifactId>*</artifactId>
</exclusion> </exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion>
<exclusion> <exclusion>
<groupId>log4j</groupId> <groupId>log4j</groupId>
<artifactId>log4j</artifactId> <artifactId>log4j</artifactId>
</exclusion> </exclusion>
<!-- Exclude log4j 2.x, we use reload4j -->
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>*</artifactId>
</exclusion>
<!-- We should exclude hive-serde since it brings along a <!-- We should exclude hive-serde since it brings along a
different version of flatbuffers causing problems for loading tables --> different version of flatbuffers causing problems for loading tables -->
<exclusion> <exclusion>
@@ -425,14 +422,10 @@ under the License.
<artifactId>hive-standalone-metastore</artifactId> <artifactId>hive-standalone-metastore</artifactId>
<version>${hive.version}</version> <version>${hive.version}</version>
<exclusions> <exclusions>
<!-- Impala uses log4j v1; avoid pulling in slf4j handling for log4j2 --> <!-- Impala uses reload4j v1; avoid pulling in log4j2 -->
<exclusion> <exclusion>
<groupId>org.apache.logging.log4j</groupId> <groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId> <artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
</exclusion> </exclusion>
<exclusion> <exclusion>
<groupId>org.apache.hive</groupId> <groupId>org.apache.hive</groupId>
@@ -795,8 +788,7 @@ under the License.
<exclude>org.apache.ant:*</exclude> <exclude>org.apache.ant:*</exclude>
<exclude>org.eclipse.jetty:*</exclude> <exclude>org.eclipse.jetty:*</exclude>
<!-- We use reload4j, exclude log4j 1.x and 2.x --> <!-- We use reload4j, exclude log4j 1.x and 2.x -->
<exclude>org.apache.logging.log4j:log4j-slf4j-impl</exclude> <exclude>org.apache.logging.log4j:*</exclude>
<exclude>org.apache.logging.log4j:log4j-1.2-api</exclude>
<exclude>log4j:*</exclude> <exclude>log4j:*</exclude>
<exclude>org.slf4j:slf4j-log4j12</exclude> <exclude>org.slf4j:slf4j-log4j12</exclude>
<!-- IMPALA-9108: Avoid pulling in leveldbjni, which is unneeded. --> <!-- IMPALA-9108: Avoid pulling in leveldbjni, which is unneeded. -->

2
java/executor-deps/pom.xml
View File

@@ -87,7 +87,7 @@ under the License.
</exclusion> </exclusion>
<exclusion> <exclusion>
<groupId>org.apache.logging.log4j</groupId> <groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId> <artifactId>*</artifactId>
</exclusion> </exclusion>
</exclusions> </exclusions>
</dependency> </dependency>

12
java/pom.xml
View File

@@ -85,7 +85,6 @@ under the License.
<velocity-engine-core.version>${env.IMPALA_VELOCITY_ENGINE_CORE_VERSION}</velocity-engine-core.version> <velocity-engine-core.version>${env.IMPALA_VELOCITY_ENGINE_CORE_VERSION}</velocity-engine-core.version>
<json-smart.version>${env.IMPALA_JSON_SMART_VERSION}</json-smart.version> <json-smart.version>${env.IMPALA_JSON_SMART_VERSION}</json-smart.version>
<commons-dbcp2.version>${env.IMPALA_DBCP2_VERSION}</commons-dbcp2.version> <commons-dbcp2.version>${env.IMPALA_DBCP2_VERSION}</commons-dbcp2.version>
<log4j2.version>${env.IMPALA_LOG4J2_VERSION}</log4j2.version>
<dropwizard-metrics.version>${env.IMPALA_DROPWIZARD_METRICS_VERSION}</dropwizard-metrics.version> <dropwizard-metrics.version>${env.IMPALA_DROPWIZARD_METRICS_VERSION}</dropwizard-metrics.version>
<aircompressor.version>${env.IMPALA_AIRCOMPRESSOR_VERSION}</aircompressor.version> <aircompressor.version>${env.IMPALA_AIRCOMPRESSOR_VERSION}</aircompressor.version>
<datasketches.version>${env.IMPALA_DATASKETCHES_VERSION}</datasketches.version> <datasketches.version>${env.IMPALA_DATASKETCHES_VERSION}</datasketches.version>
@@ -383,17 +382,6 @@ under the License.
<version>${jackson.version}</version> <version>${jackson.version}</version>
</dependency> </dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
<version>${log4j2.version}</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
<version>${log4j2.version}</version>
</dependency>
<dependency> <dependency>
<groupId>org.apache.datasketches</groupId> <groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-java</artifactId> <artifactId>datasketches-java</artifactId>