jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts

Browse Source 
The insert command was broken for impala-shell in the strict_hs2
mode. The return parameter for close_dml should return two parameters.

The parameters returned by close_dml are rows returned and error
rows. These are not supported by strict hs2 mode since the close
does not return the TDmlResult structure. So the message to
the end user also had to be changed.

Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Reviewed-on: http://gerrit.cloudera.org:8080/18176
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Csaba Ringhofer <csringhofer@cloudera.com>
This commit is contained in:
Steve Carlin
2022-01-28 14:41:42 -08:00
committed by Csaba Ringhofer
parent d59ec73990
commit 5cfdff03f7
3 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/shell/test_shell_commandline.py
View File

@@ -755,8 +755,6 @@ class TestImpalaShell(ImpalaTestSuite):
assert msg not in result_stderr, result_stderr
def test_query_time_and_link_message(self, vector, unique_database):
if vector.get_value('strict_hs2_protocol'):
pytest.skip("IMPALA-10827: Messages not sent back is strict hs2 mode.")
shell_messages = ["Query submitted at: ", "(Coordinator: ",
"Query progress can be monitored at: "]
# CREATE statements should not print query time and webserver address.
@@ -797,13 +795,15 @@ class TestImpalaShell(ImpalaTestSuite):
self._validate_shell_messages(results.stderr, shell_messages, should_exist=False)
def test_insert_status(self, vector, unique_database):
if vector.get_value('strict_hs2_protocol'):
pytest.skip("No message sent back in strict hs2 mode.")
run_impala_shell_cmd(
vector, ['--query=create table %s.insert_test (id int)' % unique_database])
results = run_impala_shell_cmd(
vector, ['--query=insert into %s.insert_test values (1)' % unique_database])
assert "Modified 1 row(s)" in results.stderr
if vector.get_value('strict_hs2_protocol'):
assert "Time elapsed" in results.stderr
else:
assert "Modified 1 row(s)" in results.stderr
def _validate_dml_stmt(self, vector, stmt, expected_rows_modified, expected_row_errors):
results = run_impala_shell_cmd(vector, ['--query=%s' % stmt])