IMPALA-7399: Emit a junit xml report when trapping errors

This patch will cause a junitxml file to be emitted in the case of
errors in build scripts. Instead of simply echoing a message to the
console, we set up a trap function that also writes out to a
junit xml report that can be consumed by jenkins.impala.io.

Main things to pay attention to:

- New file that gets sourced by all bash scripts when trapping
  within bash scripts:

  https://gerrit.cloudera.org/c/11257/1/bin/report_build_error.sh

- Installation of the python lib into impala-python venv for use
  from within python files:

  https://gerrit.cloudera.org/c/11257/1/bin/impala-python-common.sh

- Change to the generate_junitxml.py file itself, for ease of
  https://gerrit.cloudera.org/c/11257/1/lib/python/impala_py_lib/jenkins/generate_junitxml.py

Most of the other changes are to source the new report_build_error.sh
script to set up the trap function.

Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc
Reviewed-on: http://gerrit.cloudera.org:8080/11257
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>

bin/clean-cmake.sh

@@ -20,8 +20,8 @@
 # Removes artifacts generated by cmake.
 
 set -euo pipefail
-trap 'echo Error in ${0} at line ${LINENO}: $(cd "'${PWD}'" && awk "NR == ${LINENO}" \
-  ${0})' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 if [[ -z "${IMPALA_HOME}" || ! -d "${IMPALA_HOME}" ]]; then
   echo IMPALA_HOME=${IMPALA_HOME} is not valid. 1>&2

bin/clean.sh

@@ -22,8 +22,8 @@
 # branch to a non-toolchain branch due to caching in CMake generated files.
 
 set -euo pipefail
-trap 'echo Error in ${0} at line ${LINENO}: $(cd "'${PWD}'" && awk "NR == ${LINENO}" \
-  ${0})' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # If the project was never build, no Makefile will exist and thus make clean will fail.
 # Combine the make command with the bash noop to always return true.

bin/create-test-configuration.sh

@@ -22,7 +22,8 @@
 # as creation of the Hive metastore.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 CREATE_METASTORE=0
 CREATE_SENTRY_POLICY_DB=0

bin/create_testdata.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 bin=`dirname "$0"`
 bin=`cd "$bin"; pwd`

bin/distcc/distcc_server_setup.sh

@@ -39,7 +39,8 @@
 # CCACHE_DIR: directory to use for distccd's ccache.
 # CCACHE_SIZE: size of ccache, passed to ccache's -M option
 set -eu -o pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 if [[ $# != 1 ]]; then
   echo "Usage: $0 <allowed IP address range>"

bin/impala-python-common.sh

@@ -19,7 +19,8 @@
 # $IMPALA_HOME/bin/impala-py* executables.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 LD_LIBRARY_PATH+=":$(python "$IMPALA_HOME/infra/python/bootstrap_virtualenv.py" \
   --print-ld-library-path)"

bin/jenkins/all-tests.sh

@@ -19,7 +19,8 @@
 # Run all Impala tests.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 cd "${IMPALA_HOME}"
 

bin/jenkins/build-all-flag-combinations.sh

@@ -25,7 +25,8 @@
 # Usage: build-all-flag-combinations.sh [--dryrun]
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 export IMPALA_MAVEN_OPTIONS="-U"
 

bin/jenkins/build-only.sh

@@ -19,7 +19,8 @@
 # Only run an Impala build.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 cd "${IMPALA_HOME}"
 

bin/make_impala.sh

@@ -20,7 +20,8 @@
 # Incrementally compiles the frontend and backend.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 : ${IMPALA_TOOLCHAIN=}
 

bin/report_build_error.sh

@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+report_build_error() {
+  ERROR_MSG=$(cd "$PWD" && awk "NR == $1" $0)
+  FILENAME=$(basename -- "$0")
+  echo ERROR in $0 at line $1: $ERROR_MSG
+  $IMPALA_HOME/bin/generate_junitxml.py --step "${FILENAME%.*}" \
+    --error "Error in $0 at line $1: $ERROR_MSG"
+}
+
+setup_report_build_error() {
+  trap 'report_build_error $LINENO' ERR
+}

bin/run-all-tests.sh

@@ -22,7 +22,8 @@
 
 # Exit on reference to uninitialized variables and non-zero exit codes
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . "$IMPALA_HOME/bin/set-pythonpath.sh"
 

bin/run-backend-tests.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 export GTEST_OUTPUT="xml:$IMPALA_BE_TEST_LOGS_DIR/"
 

bin/start-catalogd.sh

@@ -21,7 +21,8 @@
 # -build_type parameter can be passed to determine the build type to use.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 BUILD_TYPE=latest
 CATALOGD_ARGS=""

bin/start-impalad.sh

@@ -21,7 +21,8 @@
 # parameter can be passed to determine the build type to use for the impalad instance.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 BUILD_TYPE=latest
 IMPALAD_ARGS=""

bin/start-statestored.sh

@@ -20,7 +20,8 @@
 # Starts up the StateStored with the specified command line arguments.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 BUILD_TYPE=latest
 STATESTORED_ARGS=""

buildall.sh

@@ -18,6 +18,8 @@
 # under the License.
 
 set -euo pipefail
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # run buildall.sh -help to see options
 ROOT=`dirname "$0"`
@@ -29,8 +31,6 @@ then
    exit 1
 fi
 
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
-
 # Grab this *before* we source impala-config.sh to see if the caller has
 # kerberized environment variables already or not.
 NEEDS_RE_SOURCE_NOTE=1

infra/python/bootstrap_virtualenv.py

@@ -140,29 +140,37 @@ def exec_pip_install(args, cc="no-cc-available", env=None):
   # Don't call the virtualenv pip directly, it uses a hashbang to to call the python
   # virtualenv using an absolute path. If the path to the virtualenv is very long, the
   # hashbang won't work.
-  #
+  impala_pip_base_cmd = [os.path.join(ENV_DIR, "bin", "python"),
+                         os.path.join(ENV_DIR, "bin", "pip"), "install", "-v"]
+
   # Passes --no-binary for IMPALA-3767: without this, Cython (and
   # several other packages) fail download.
   #
   # --no-cache-dir is used to prevent caching of compiled artifacts, which may be built
   # with different compilers or settings.
-  cmd = [os.path.join(ENV_DIR, "bin", "python"), os.path.join(ENV_DIR, "bin", "pip"),
-      "install", "-v", "--no-binary", ":all:", "--no-cache-dir"]
+  third_party_pkg_install_cmd = \
+      impala_pip_base_cmd[:] + ["--no-binary", ":all:", "--no-cache-dir"]
 
   # When using a custom mirror, we also must use the index of that mirror.
   if "PYPI_MIRROR" in os.environ:
-    cmd.extend(["--index-url", "%s/simple" % os.environ["PYPI_MIRROR"]])
+    third_party_pkg_install_cmd.extend(["--index-url",
+                                        "%s/simple" % os.environ["PYPI_MIRROR"]])
   else:
     # Prevent fetching additional packages from the index. If we forget to add a package
     # to one of the requirements.txt files, this should trigger an error. However, we will
     # still access the index for version/dependency resolution, hence we need to change it
     # when using a private mirror.
-    cmd.append("--no-index")
+    third_party_pkg_install_cmd.append("--no-index")
 
-  cmd.extend(["--find-links",
+  third_party_pkg_install_cmd.extend(["--find-links",
       "file://%s" % urllib.pathname2url(os.path.abspath(DEPS_DIR))])
-  cmd.extend(args)
-  exec_cmd(cmd, env=env)
+  third_party_pkg_install_cmd.extend(args)
+  exec_cmd(third_party_pkg_install_cmd, env=env)
+
+  # Finally, we want to install the packages from our own internal python lib
+  local_package_install_cmd = impala_pip_base_cmd + \
+      ['-e', os.path.join(os.getenv('IMPALA_HOME'), 'lib', 'python')]
+  exec_cmd(local_package_install_cmd)
 
 
 def find_file(*paths):

lib/python/impala_py_lib/jenkins/generate_junitxml.py

@@ -32,18 +32,30 @@ from datetime import datetime as dt
 
 IMPALA_HOME = os.getenv('IMPALA_HOME', '.')
 SCRIPT_NAME, _ = os.path.splitext(os.path.basename(__file__))
+JUNITXML_LOGDIR = os.path.join(os.getenv("IMPALA_LOGS_DIR", "."), 'extra_junit_xml_logs')
 
 
 class JunitReport(object):
   """A Junit XML style report parseable by Jenkins for reporting build status.
 
-  Generally, a caller who invokes this script doesn't need to do anything
+  Generally, a caller who invokes this script from bash doesn't need to do
   more than supply the necessary command line parameters. The JunitReport
   class is instantiated using those initial inputs, and a timestamped XML
   file is output to the $IMPALA_HOME/logs/extra_junit_xml_logs/.
 
   Log files are timestamped, so they will not overwrite previous files containing
   output of the same step.
+
+  For use from within a python script (must be invoked with impala-python), an
+  example might look like:
+
+  >>> from impala_py_lib.jenkins.generate_junitxml import JunitReport
+  >>> report = JunitReport(phase='load_data', step='load_hbase', error_msg='oops')
+  >>> report.tofile()
+
+  For now, the class does not support adding more than one step (analogous to a
+  test case) to the same phase (analogous to a test suite). Each report should
+  be unique for a given junit XML file. This may be enhanced at some point.
   """
 
   def __init__(self, phase, step, error_msg=None, stdout=None, stderr=None,
@@ -124,7 +136,7 @@ class JunitReport(object):
     output = ET.SubElement(self.testcase_element, "system-{}".format(output_type))
     output.text = JunitReport.get_xml_content(file_or_string)
 
-  def to_file(self, junitxml_logdir='.'):
+  def to_file(self, junitxml_logdir=JUNITXML_LOGDIR):
     """
     Create a timestamped XML report file.
 
@@ -134,6 +146,15 @@ class JunitReport(object):
     Return:
       junit_log_file: path to the generated file
     """
+    # The equivalent of mkdir -p
+    try:
+      os.makedirs(junitxml_logdir)
+    except OSError as e:
+      if e.errno == errno.EEXIST and os.path.isdir(junitxml_logdir):
+        pass
+      else:
+        raise
+
     filename = '{}.{}.xml'.format(
         self.testsuite_element.attrib['name'],
         self.utc_time.strftime('%Y%m%d_%H_%M_%S')
@@ -226,17 +247,6 @@ def main():
   Phase can be repeated in a given test run, but the step leaf node, which is
   equivalent to a "test case", must be unique within each phase.
   """
-  junitxml_logdir = os.path.join(IMPALA_HOME, 'logs', 'extra_junit_xml_logs')
-
-  # The equivalent of mkdir -p
-  try:
-    os.makedirs(junitxml_logdir)
-  except OSError as e:
-    if e.errno == errno.EEXIST and os.path.isdir(junitxml_logdir):
-      pass
-    else:
-      raise
-
   options = get_options()
 
   junit_report = JunitReport(phase=options.phase,
@@ -246,8 +256,8 @@ def main():
                              stderr=options.stderr,
                              elapsed_time=options.time)
 
-  xml_report = junit_report.to_file(junitxml_logdir)
-  print("Generated: {}".format(xml_report))
+  junit_log_file = junit_report.to_file()
+  print("Generated: {0}".format(junit_log_file))
 
 
 if "__main__" == __name__:

shell/make_shell_tarball.sh

@@ -23,7 +23,8 @@
 # ${IMPALA_HOME}/shell/build.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 if [ "x${IMPALA_HOME}" == "x" ]; then
   echo "\$IMPALA_HOME must be set"

testdata/bin/check-schema-diff.sh

@@ -24,6 +24,10 @@
 #  - 1 implies that the schemas have changed.
 
 set -euo pipefail
+
+# We don't want to generate a junit xml report for errors generated here,
+# since exit code 1 here denotes something useful. So in the case of this
+# script, we don't call setup_report_build_error.
 trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1

testdata/bin/compute-table-stats.sh

@@ -20,7 +20,8 @@
 # Runs compute table stats over a curated set of Impala test tables.
 #
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 

testdata/bin/copy-data-sources.sh

@@ -20,7 +20,8 @@
 # This script copies the test data source library into hdfs.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 

testdata/bin/copy-udfs-udas.sh

@@ -20,7 +20,8 @@
 # This script copies udf/uda binaries into hdfs.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 if [ x${JAVA_HOME} == x ]; then
   echo JAVA_HOME not set

testdata/bin/create-load-data.sh

@@ -29,7 +29,8 @@
 # bin/load-data.py
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 . ${IMPALA_HOME}/testdata/bin/run-step.sh

testdata/bin/create-table-many-blocks.sh

@@ -25,7 +25,8 @@
 # blocks/files.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 

testdata/bin/generate-load-nested.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 SHELL_CMD=${IMPALA_HOME}/bin/impala-shell.sh
 

testdata/bin/kill-all.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # Shutdown Impala if it is alive
 ${IMPALA_HOME}/bin/start-impala-cluster.py --kill

testdata/bin/kill-hbase.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 DIR=$(dirname "$0")
 echo Stopping Hbase

testdata/bin/kill-hive-server.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 DIR=$(dirname "$0")
 echo Stopping Hive

testdata/bin/kill-java-service.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 CLASSES=()
 EXTRA_SHUTDOWN_TIME_SECS=1

testdata/bin/kill-sentry-service.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 DIR=$(dirname "$0")
 echo Stopping Sentry

testdata/bin/load-hive-builtins.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 

testdata/bin/load-metastore-snapshot.sh

@@ -22,7 +22,8 @@
 # full data load build.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 

testdata/bin/load-test-warehouse-snapshot.sh

@@ -25,7 +25,8 @@
 # to backup any data you need before running this script.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/impala-config.sh > /dev/null 2>&1
 : ${REMOTE_LOAD:=}

testdata/bin/run-all.sh

@@ -20,7 +20,8 @@
 # Starts up a mini-dfs test cluster and related services
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # If -format is passed, format the mini-dfs cluster.
 

testdata/bin/run-hbase.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 CLUSTER_BIN=${IMPALA_HOME}/testdata/bin
 HBASE_JAAS_CLIENT=${HBASE_CONF_DIR}/hbase-jaas-client.conf

testdata/bin/run-hive-server.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/set-pythonpath.sh
 

testdata/bin/run-mini-dfs.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 if [[ $# -eq 1 && "$1" == -format ]]; then
   SHOULD_FORMAT=true

testdata/bin/run-sentry-service.sh

@@ -18,7 +18,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 . ${IMPALA_HOME}/bin/set-classpath.sh
 

testdata/bin/setup-hdfs-env.sh

@@ -18,7 +18,8 @@
 # under the License.
 #
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 : ${REMOTE_LOAD:=}
 

testdata/cluster/admin

@@ -28,7 +28,8 @@
 # TODO: Run each node on its own IP address, e.g. 127.0.0.1, 127.0.0.2, and so on.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 : ${IMPALA_KERBERIZE=}
 : ${INCLUDE_YARN=}

testdata/datasets/tpcds/preload

@@ -17,7 +17,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 IMPALA_DATA=${IMPALA_HOME}/testdata/impala-data
 TPC_DS_DATA=${IMPALA_DATA}/tpcds

testdata/datasets/tpch/preload

@@ -17,7 +17,8 @@
 # under the License.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 IMPALA_DATA=${IMPALA_HOME}/testdata/impala-data
 TPC_H_DATA=${IMPALA_DATA}/tpch

tests/run-custom-cluster-tests.sh

@@ -21,7 +21,8 @@
 # clusters will be restarted.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # Disable HEAPCHECK for the process failure tests because they can cause false positives.
 # TODO: Combine with run-process-failure-tests.sh

tests/run-process-failure-tests.sh

@@ -20,7 +20,8 @@
 # Runs the Impala process failure tests.
 
 set -euo pipefail
-trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)' ERR
+. $IMPALA_HOME/bin/report_build_error.sh
+setup_report_build_error
 
 # Disable HEAPCHECK for the process failure tests because they can cause false positives.
 export HEAPCHECK=