jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-23 21:08:39 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-12997: Use graceful shutdown for query log tests

Browse Source 
Uses graceful shutdown for all tests that might insert into
'sys.impala_query_log' to avoid leaving the table locked in HMS by a
SIGTERM. That's primarily any test that lowers
'query_log_write_interval_s' or 'query_log_max_queued'.

Lowers grace period on test_query_log_table_flush_on_shutdown because
ShutdownWorkloadManagement() is not started until the grace period ends.

Updates "Adding/Removing local backend" to only apply to executors. It
was only added for executors, but would be removed on dedicated
coordinators as well (resulting in a DFATAL message during graceful
shutdown).

Change-Id: Ia123c53a952a77ff4a9c02736b5717ccaa3566dc
Reviewed-on: http://gerrit.cloudera.org:8080/21345
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Michael Smith
2024-04-22 16:05:09 -07:00
committed by Impala Public Jenkins
parent ba32d70891
commit 712a37bce4
3 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/custom_cluster/test_query_log.py
View File

@@ -407,7 +407,7 @@ class TestQueryLogTableBeeswax(TestQueryLogTableBase):
cluster_size=3,
num_exclusive_coordinators=2,
catalogd_args="--enable_workload_mgmt",
impalad_graceful_shutdown=False)
impalad_graceful_shutdown=True)
def test_query_log_table_query_select_dedicate_coordinator(self, vector):
"""Asserts the values written to the query log table match the values from the
query profile when dedicated coordinators are used."""
@@ -436,7 +436,7 @@ class TestQueryLogTableBeeswax(TestQueryLogTableBase):
cluster_size=3,
num_exclusive_coordinators=2,
catalogd_args="--enable_workload_mgmt",
impalad_graceful_shutdown=False)
impalad_graceful_shutdown=True)
def test_query_log_table_query_select_mt_dop(self, vector):
"""Asserts the values written to the query log table match the values from the
query profile when dedicated coordinators are used along with an MT_DOP setting
@@ -694,13 +694,13 @@ class TestQueryLogTableHS2(TestQueryLogTableBase):
@CustomClusterTestSuite.with_args(impalad_args="--enable_workload_mgmt "
"--query_log_write_interval_s=9999 "
"--shutdown_grace_period_s=30 "
"--shutdown_grace_period_s=1 "
"--shutdown_deadline_s=30",
catalogd_args="--enable_workload_mgmt",
impalad_graceful_shutdown=False)
catalogd_args="--enable_workload_mgmt")
def test_query_log_table_flush_on_shutdown(self, vector):
"""Asserts that queries that have completed but are not yet written to the query
log table are flushed to the table before the coordinator exits."""
log table are flushed to the table before the coordinator exits. Graceful shutdown
for 2nd coordinator not needed because query_log_write_interval_s is very long."""
impalad = self.cluster.get_first_impalad()
client = self.get_client(vector.get_value('protocol'))