jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2026-01-30 15:00:18 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-11549: Support Hive GenericUdfs that return primitive java types

Browse Source 
Before this patch only the Writable* types were accepted in GenericUdfs
as return types, while some GenericUdfs in the wild return primitive java
types (e.g. Integer instead of IntWritable). For legacy Hive UDFs these
return types were already handled, so the only change needed was to
map the ObjectInspector subclasses (e.g. JavaIntObjectInspector) to the
correct JavaUdfDataType in Impala.

Testing:
- Added a subclass for TestGenericUdf (TestGenericUdfWithJavaReturnTypes)
  that returns primitive java types (probably inheriting in the opposite
  direction would be more logical, but the diff is smaller this way).
- Changed EE tests to also use TestGenericUdfWithJavaReturnTypes.
- Changed FE tests (UdfExecutorTest) to check both
  TestGenericUdfWithJavaReturnTypes and TestGenericUdf.
- Also added a test with BINARY type to UdfExecutorTest as this was
  forgotten during the original BINARY patch.

Change-Id: I30679045d6693ebd35718b6f1a22aaa4963c1e63
Reviewed-on: http://gerrit.cloudera.org:8080/19304
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Csaba Ringhofer
2022-12-01 18:49:43 +01:00
committed by Impala Public Jenkins
parent a469a9cf19
commit 86740a7d35
10 changed files with 740 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test vendored
View File

@@ -22,53 +22,76 @@ STRING
====
---- QUERY
#Test GenericUDF functions
select generic_identity(true), generic_identity(cast(NULL as boolean));
select generic_identity(true), generic_identity(cast(NULL as boolean)),
generic_identity_java_ret_type(true),
generic_identity_java_ret_type(cast(NULL as boolean));
---- TYPES
boolean, boolean
boolean, boolean, boolean, boolean
---- RESULTS
true,NULL
true,NULL,true,NULL
====
---- QUERY
select generic_identity(cast(10 as tinyint)), generic_identity(cast(NULL as tinyint));
select generic_identity(cast(10 as tinyint)), generic_identity(cast(NULL as tinyint)),
generic_identity_java_ret_type(cast(10 as tinyint)),
generic_identity_java_ret_type(cast(NULL as tinyint));
---- TYPES
tinyint, tinyint
tinyint, tinyint, tinyint, tinyint
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast(10 as smallint)), generic_identity(cast(NULL as smallint));
select generic_identity(cast(10 as smallint)), generic_identity(cast(NULL as smallint)),
generic_identity_java_ret_type(cast(10 as smallint)),
generic_identity_java_ret_type(cast(NULL as smallint));
---- TYPES
smallint, smallint
smallint, smallint, smallint, smallint
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast(10 as int)), generic_identity(cast(NULL as int));
select generic_identity(cast(10 as int)), generic_identity(cast(NULL as int)),
generic_identity_java_ret_type(cast(10 as int)),
generic_identity_java_ret_type(cast(NULL as int));
---- TYPES
int, int
int, int, int, int
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast(10 as bigint)), generic_identity(cast(NULL as bigint));
select generic_identity(cast(10 as bigint)), generic_identity(cast(NULL as bigint)),
generic_identity_java_ret_type(cast(10 as bigint)),
generic_identity_java_ret_type(cast(NULL as bigint));
---- TYPES
bigint, bigint
bigint, bigint, bigint, bigint
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast(10.0 as float)), generic_identity(cast(NULL as float));
select generic_identity(cast(10.0 as float)), generic_identity(cast(NULL as float)),
generic_identity_java_ret_type(cast(10.0 as float)),
generic_identity_java_ret_type(cast(NULL as float));
---- TYPES
float, float
float, float, float, float
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast(10.0 as double)), generic_identity(cast(NULL as double));
select generic_identity(cast(10.0 as double)), generic_identity(cast(NULL as double)),
generic_identity_java_ret_type(cast(10.0 as double)),
generic_identity_java_ret_type(cast(NULL as double));
---- TYPES
double, double
double, double, double, double
---- RESULTS
10,NULL
10,NULL,10,NULL
====
---- QUERY
select generic_identity(cast("a" as binary)), generic_identity(cast(NULL as binary)),
generic_identity_java_ret_type(cast("a" as binary)),
generic_identity_java_ret_type(cast(NULL as binary))
---- TYPES
binary, binary, binary, binary
---- RESULTS
'a','NULL','a','NULL'
====
---- QUERY
# IMPALA-1134. Tests that strings are copied correctly
@@ -81,11 +104,24 @@ int, int, int
10,20,30
====
---- QUERY
select generic_identity(cast("a" as binary)), generic_identity(cast(NULL as binary));
# IMPALA-1134. Tests that binaries are copied correctly
select length(generic_identity(cast("0123456789" as binary))),
length(generic_add(cast("0123456789" as binary), cast("0123456789" as binary))),
length(generic_add(cast("0123456789" as binary), cast("0123456789" as binary),
cast("0123456789" as binary)));
---- TYPES
binary, binary
int, int, int
---- RESULTS
'a','NULL'
10,20,30
====
---- QUERY
# Test UDFs with java return types with multiple arguements.
select generic_add_java_ret_type(1, 2),
generic_add_java_ret_type("a", "bc", "d");
---- TYPES
int, string
---- RESULTS
3,'abcd'
====
---- QUERY
# IMPALA-1392: Hive UDFs that throw exceptions should return NULL