jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

Browse Source 
This change fixes a regression introduced by "IMPALA-2195 Improper
handling of comments in queries."

The Impala Shell parses input text into several strings using the
sqlparse library. One of the returned strings is the sql command, this
is used to determine the correct do_<command> method to call. Another of
the returned strings is the leading comment, which is a comment that
appears before legal sql text.

Python2 has strings with multiple encodings. The strings returned from
the sqlparse library have the Unicode encoding. Impala Shell converts
the sql command string to utf-8 encoding before using it.

If the Impala Shell needs to send the sql command to an Impala
Coordinator then it (re)constructs the query out of the strings
returned by the sqlparse library. This query is sent to the Coordinator
via Beeswax protocol. The query is converted to an ascii string before
being sent. The conversion can fail if the leading comment string
contains Unicode characters, which can't be directly converted to ascii.
So the trigger for the bug is that the leading comment contains Unicode.

The fix is that the leading comment string should be converted to utf-8
in the same way as the sql command.

TESTING:

Ran all end -to-end tests.
Added two test cases to tests/shell/test_shell_interactive.py

Change-Id: I8633935b6e0ca33594afd32ad242779555e09944
Reviewed-on: http://gerrit.cloudera.org:8080/12812
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Andrew Sherman
2019-03-20 09:33:31 -07:00
committed by Impala Public Jenkins
parent 5c2ee58066
commit 9ad9a1624a
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/shell/test_shell_interactive.py
View File

@@ -538,7 +538,12 @@ class TestImpalaShellInteractive(object):
result = run_impala_shell_interactive('-- comment\n'
'select * from leading_comment;')
assert 'Fetched 1 row(s)' in result.stderr
result = run_impala_shell_interactive('--한글\n'
'select * from leading_comment;')
assert 'Fetched 1 row(s)' in result.stderr
result = run_impala_shell_interactive('/* 한글 */\n'
'select * from leading_comment;')
assert 'Fetched 1 row(s)' in result.stderr
result = run_impala_shell_interactive('/* comment */\n'
'select * from leading_comment;')
assert 'Fetched 1 row(s)' in result.stderr