jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2026-01-06 06:01:03 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-3378/IMPALA-3379: fix various JNI issues

Browse Source 
This patch:

1) Removes JniUtil::Cleanup() and JniUtil::global_refs_. We never
called Cleanup(), and all the jobjects in global_refs_ are meant to
have the lifetime of the impalad process. This makes
JniUtil::GetGlobalClassRef() and JniUtil::LocalToGlobalRef()
thread-safe (which fixes IMPALA-3379).

2) Introduces a new JniUtil::FreeGlobalRef() method, which is a
wrapper around the JNI DeleteGlobalRef() method.

3) Change JNI users to use the JniUtil methods instead of the JNI
methods directly where appropriate. This makes error checking more
consistent, and makes it easier to find all JNI uses. This is possible
since GetGlobalClassRef() and LocalToGlobalRef() are now thread-safe
and don't leak jobjects.

4) Removes HiveUdfCall::JniContext::cl, as well as other JNI
constants, and replaces them with process-wide static singletons. It
then moves the initialization to a new HiveUdfCall::Init() method
which is once called in the main thread at the beginning of the
process. This fixes IMPALA-3378.

5) Deletes the JniContext created for each HiveUdfCall

Unfortunately I am not able to repro IMPALA-3378 so there is no test
case (I didn't attempt IMPALA-3379 but it's similar).

Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941
Reviewed-on: http://gerrit.cloudera.org:8080/2820
Reviewed-by: Skye Wanderman-Milne <skye@cloudera.com>
Tested-by: Internal Jenkins
This commit is contained in:
Skye Wanderman-Milne
2016-04-25 16:02:11 -07:00
committed by Tim Armstrong
parent b4a9dfcc92
commit 9f366645ab
12 changed files with 160 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
testdata/workloads/functional-query/queries/QueryTest/java-udf.test vendored
View File

@@ -234,3 +234,59 @@ string
---- RESULTS
'abc'
====
---- QUERY
# IMPALA-3378: test many Java UDFs being opened and run concurrently
select * from
(select max(int_col) from functional.alltypesagg
where udf_test.identity(bool_col) union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(tinyint_col) > 1 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(smallint_col) > 1 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(int_col) > 1 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(bigint_col) > 1 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(float_col) > 1.0 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(double_col) > 1.0 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(string_col) > '1' union all
(select max(int_col) from functional.alltypesagg
where not udf_test.identity(bool_col) union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(tinyint_col) > 2 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(smallint_col) > 2 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(int_col) > 2 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(bigint_col) > 2 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(float_col) > 2.0 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(double_col) > 2.0 union all
(select max(int_col) from functional.alltypesagg
where udf_test.identity(string_col) > '2'
)))))))))))))))) v
---- TYPES
INT
---- RESULTS
998
999
999
999
999
999
999
999
999
999
999
999
999
999
999
999
====