jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13926: Remove teardown in TestWorkloadManagementInitNoWait

Browse Source 
test_start_invalid_version and test_start_unknown_version of
TestWorkloadManagementInitNoWait hit assertion error during teardown.
These tests are set up with expect_startup_fail=True.

This patch attempts to deflake the issue by removing the
teardown_method() and moves wait_for_wm_idle() at the end of tests that
are not set up with expect_startup_fail=True.

Testing:
Loop TestWorkloadManagementInitNoWait 10 times and pass them all.

Change-Id: I03c748dc100f5447820a9a77c527facb832521d6
Reviewed-on: http://gerrit.cloudera.org:8080/22725
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Riza Suminto
2025-04-02 13:10:10 -07:00
committed by Impala Public Jenkins
parent bd3486c051
commit b9c074d283
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/custom_cluster/test_workload_mgmt_init.py
View File

@@ -529,10 +529,6 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase):
def setup_method(self, method):
super(TestWorkloadManagementInitNoWait, self).setup_method(method)
def teardown_method(self, method):
self.wait_for_wm_idle()
super(TestWorkloadManagementInitNoWait, self).teardown_method(method)
@CustomClusterTestSuite.with_args(
cluster_size=1, log_symlinks=True,
impalad_args="--query_log_write_interval_s=3",
@@ -562,6 +558,7 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase):
res = self.client.execute("select * from functional.alltypes")
assert res.success
impalad.wait_for_metric_value("impala-server.completed-queries.written", 1, 15)
self.wait_for_wm_idle()
@CustomClusterTestSuite.with_args(
cluster_size=1, expect_startup_fail=True,
@@ -617,6 +614,7 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase):
# Assert the standby catalog skipped workload management initialization.
self.assert_catalogd_log_contains("INFO", r"workload management initialization",
expected_count=0, node_index=1)
self.wait_for_wm_idle()
class TestWorkloadManagementCatalogHA(TestWorkloadManagementInitBase):