jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-10778: Allow impala-shell to connect directly to HS2

Browse Source 
Impala-shell already uses HS2 protocol to connect to Impalad.
This commit allows impala-shell to connect to any server (for
example, Hive) using the hs2 protocol. This will be done via
the "--strict_hs2_protocol" option.

When the "--strict_hs2_protocol" option is turned on, only features
supported by hs2 will work. For instance, "runtime-profile" is an
impalad specific feature and will be disabled.

The "--strict_hs2_protocol" will only work on servers that abide
by the strict definition of what is supported by HS2. So one will
be able to connect to Hive in this mode, but connections to Impala
will not work. Any feature supported by Hive (e.g. kerberos
authentication) should work as well.

Note: While authentication should work, the test framework is not
set up to create an HS2 server that does authentication at this point
so this feature should be used with caution.
Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e
Reviewed-on: http://gerrit.cloudera.org:8080/17660
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Steve Carlin
2021-02-17 16:06:03 -08:00
committed by Csaba Ringhofer
parent e977014fa7
commit bb9fb663ce
13 changed files with 334 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/shell/util.py
View File

@@ -35,7 +35,8 @@ from tests.common.environ import (IMPALA_LOCAL_BUILD_VERSION,
ImpalaTestClusterProperties)
from tests.common.impala_service import ImpaladService
from tests.common.impala_test_suite import (IMPALAD_BEESWAX_HOST_PORT,
IMPALAD_HS2_HOST_PORT, IMPALAD_HS2_HTTP_HOST_PORT)
IMPALAD_HS2_HOST_PORT, IMPALAD_HS2_HTTP_HOST_PORT,
STRICT_HS2_HOST_PORT, STRICT_HS2_HTTP_HOST_PORT)
LOG = logging.getLogger('tests/shell/util.py')
LOG.addHandler(logging.StreamHandler())
@@ -197,10 +198,17 @@ def run_impala_shell_cmd_no_expect(vector, shell_args, env=None, stdin_input=Non
def get_impalad_host_port(vector):
"""Get host and port to connect to based on test vector provided."""
protocol = vector.get_value("protocol")
strict = vector.get_value_with_default("strict_hs2_protocol", False)
if protocol == 'hs2':
return IMPALAD_HS2_HOST_PORT
if strict:
return STRICT_HS2_HOST_PORT
else:
return IMPALAD_HS2_HOST_PORT
elif protocol == 'hs2-http':
return IMPALAD_HS2_HTTP_HOST_PORT
if strict:
return STRICT_HS2_HTTP_HOST_PORT
else:
return IMPALAD_HS2_HTTP_HOST_PORT
else:
assert protocol == 'beeswax', protocol
return IMPALAD_BEESWAX_HOST_PORT
@@ -214,9 +222,17 @@ def get_impalad_port(vector):
def get_shell_cmd(vector):
"""Get the basic shell command to start the shell, given the provided test vector.
Returns the command as a list of string arguments."""
return [IMPALA_SHELL_EXECUTABLE,
"--protocol={0}".format(vector.get_value("protocol")),
"-i{0}".format(get_impalad_host_port(vector))]
if vector.get_value_with_default("strict_hs2_protocol", False):
protocol = vector.get_value("protocol")
return [IMPALA_SHELL_EXECUTABLE,
"--protocol={0}".format(protocol),
"--strict_hs2_protocol",
"--use_ldap_test_password",
"-i{0}".format(get_impalad_host_port(vector))]
else:
return [IMPALA_SHELL_EXECUTABLE,
"--protocol={0}".format(vector.get_value("protocol")),
"-i{0}".format(get_impalad_host_port(vector))]
def spawn_shell(shell_cmd):