mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
IMPALA-12337: Implement delete orphan files for Iceberg table
This patch implements delete orphan files query for Iceberg table. The following statement becomes available for Iceberg tables: - ALTER TABLE <tbl> EXECUTE remove_orphan_files(<timestamp>) The bulk of implementation copies Hive's implementation of org.apache.iceberg.actions.DeleteOrphanFiles interface (HIVE-27906, 6b2e21a93ef3c1776b689a7953fc59dbf52e4be4), which this patch rename to ImpalaIcebergDeleteOrphanFiles.java. Upon execute(), ImpalaIcebergDeleteOrphanFiles class instance will gather all URI of valid data files and Iceberg metadata files using Iceberg API. These valid URIs then will be compared to recursive file listing obtained through Hadoop FileSystem API under table's 'data' and 'metadata' directory accordingly. Any unmatched URI from FileSystem API listing that has modification time less than 'olderThanTimestamp' parameter will then be removed via Iceberg FileIO API of given Iceberg table. Note that this is a destructive query that will wipe out any files within Iceberg table's 'data' and 'metadata' directory that is not addressable by any valid snapshots. The execution happens in CatalogD via IcebergCatalogOpExecutor.alterTableExecuteRemoveOrphanFiles(). CatalogD supplied CatalogOpExecutor.icebergExecutorService_ as executor service to execute the Iceberg API planFiles and FileIO API for deletion. Also fixed toSql() implementation for all ALTER TABLE EXECUTE queries. Testing: - Add FE and EE tests. Change-Id: I5979cdf15048d5a2c4784918533f65f32e888de0 Reviewed-on: http://gerrit.cloudera.org:8080/23042 Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Reviewed-by: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
This commit is contained in:
@@ -444,6 +444,11 @@ struct TAlterTableExecuteRollbackParams {
|
||||
3: optional i64 snapshot_id
|
||||
}
|
||||
|
||||
// Parameters for ALTER TABLE EXECUTE REMOVE_ORPHAN_FILES operations.
|
||||
struct TAlterTableExecuteRemoveOrphanFilesParams {
|
||||
1: required i64 older_than_millis
|
||||
}
|
||||
|
||||
// Parameters for ALTER TABLE EXECUTE ... operations.
|
||||
struct TAlterTableExecuteParams {
|
||||
// Parameters for ALTER TABLE EXECUTE EXPIRE_SNAPSHOTS
|
||||
@@ -451,6 +456,9 @@ struct TAlterTableExecuteParams {
|
||||
|
||||
// Parameters for ALTER TABLE EXECUTE ROLLBACK
|
||||
2: optional TAlterTableExecuteRollbackParams execute_rollback_params
|
||||
|
||||
// Parameters for ALTER TABLE EXECUTE REMOVE_ORPHAN_FILES
|
||||
3: optional TAlterTableExecuteRemoveOrphanFilesParams remove_orphan_files_params
|
||||
}
|
||||
|
||||
// Parameters for all ALTER TABLE commands.
|
||||
|
||||
Reference in New Issue
Block a user