jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14392: Fix a crash in AdmissionD in GetQueryStatus PrintId()

Browse Source 
The GetQueryStatus RPC could crash due to a use-after-free error
when accessing the reqest. When a query was rejected, the
function would call RespondAndReleaseRpc(), which can free the "req"
object, and then attempt to access req->query_id() for logging and
to delete the entry from the admission_state_map_.

This commit fixes the crash by moving the call to
RespondAndReleaseRpc() to the end of the function. This change
aligns this function with others like
AdmissionControlService::ReleaseQuery(), which also deletes from
admission_state_map_ before RespondAndReleaseRpc(), it ensures
that all logic is completed before the RPC resources are released.

Tests:
Reproduced the issue by running 100 times
TestAdmissionControllerStressWithACService::test_mem_limit, and
after the change, it can successfully run 100 times.
Passed exhaustive tests.

Change-Id: I688954c5c671671cc2dc669ecfdf2405476302d7
Reviewed-on: http://gerrit.cloudera.org:8080/23379
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Tested-by: Michael Smith <michael.smith@cloudera.com>
This commit is contained in:
Yida Wu
2025-09-03 17:17:48 -07:00
committed by Michael Smith
parent edd5ff6e2a
commit c78f7a7290
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
be/src/scheduling/admission-control-service.cc
View File

@@ -211,7 +211,6 @@ void AdmissionControlService::GetQueryStatus(const GetQueryStatusRequestPB* req,
}
}
RespondAndReleaseRpc(status, resp, rpc_context);
if (admission_state->admission_done && !admission_state->admit_status.ok()) {
LOG(INFO) << "Query " << req->query_id()
<< " was rejected. Removing admission state to free resources.";
@@ -222,6 +221,7 @@ void AdmissionControlService::GetQueryStatus(const GetQueryStatusRequestPB* req,
discard_result(admission_state_map_.Delete(req->query_id()));
VLOG(3) << "Current admission state map size: " << admission_state_map_.Count();
}
RespondAndReleaseRpc(status, resp, rpc_context);
}
void AdmissionControlService::ReleaseQuery(const ReleaseQueryRequestPB* req,