jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-23 21:08:39 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13912: Use SHARED_CLUSTER_ARGS in more custom cluster tests

Browse Source 
In addition to IMPALA-13503 which allowed having the single cluster
running for the entire test class, this attempts to minimize restarting
between the existing tests without modifying any of their code.

This changeset saves the command line with which
'start-impala-cluster.py' has been run and skips the restarting if the
command line is the same for the next test.

Some tests however do require restart due to the specific metrics being
tested. Such tests are defined with the 'force_restart' flag within the
'with_args' decorator. NOTE: there might be more tests like that
revealed after running the tests in different order resulting in test
failures.

Experimentally, this results in ~150 fewer restarts, mostly coming from
restarts between tests. As for restarts between different variants of
the same test, most of the cluster tests are restricted to single
variant, although multi-variant tests occur occasionally.

Change-Id: I7c9115d4d47b9fe0bfd9dbda218aac2fb02dbd09
Reviewed-on: http://gerrit.cloudera.org:8080/22901
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Mihaly Szjatinya
2025-06-13 15:20:17 +02:00
committed by Impala Public Jenkins
parent 594912f636
commit e0cb533c25
12 changed files with 90 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/custom_cluster/test_query_log.py
View File

@@ -279,7 +279,8 @@ class TestQueryLogTableBasic(WorkloadManagementTestSuite):
@CustomClusterTestSuite.with_args(cluster_size=3,
num_exclusive_coordinators=2,
workload_mgmt=True,
disable_log_buffering=True)
disable_log_buffering=True,
force_restart=True)
def test_dedicated_coordinator_with_mt_dop(self, vector):
"""Asserts the values written to the query log table match the values from the
query profile when dedicated coordinators are used along with an MT_DOP setting
@@ -671,7 +672,8 @@ class TestQueryLogTableAll(WorkloadManagementTestSuite):
@CustomClusterTestSuite.with_args(impalad_args="--cluster_id=test_query_hist_2",
workload_mgmt=True,
disable_log_buffering=True)
disable_log_buffering=True,
force_restart=True)
def test_invalid_query(self, vector):
"""Asserts correct values are written to the completed queries table for a failed
query. The query profile is used as the source of expected values."""
@@ -792,7 +794,8 @@ class TestQueryLogTableAll(WorkloadManagementTestSuite):
"impala-server.completed-queries.failure") == 0
@CustomClusterTestSuite.with_args(workload_mgmt=True,
disable_log_buffering=True)
disable_log_buffering=True,
force_restart=True)
def test_sql_injection_attempts(self, vector):
client = self.get_client(vector.get_value('protocol'))
impalad = self.cluster.get_first_impalad()