jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-12925: Fix decimal data type for external JDBC table

Browse Source 
Decimal type is a primitive data type for Impala. Current code returns
wrong values for columns with decimal data type in external JDBC tables.

This patch fixes wrong values returned from JDBC data source, and
supports pushing down decimal type of predicates to remote database
and remote Impala.
The decimal precision and scale of the columns in external JDBC table
must be no less than the decimal precision and scale of the
corresponding columns in the table of remote database. Otherwise,
Impala fails with an error since it may cause truncation of decimal
data.

Testing:
 - Added Planner test for pushing down decimal type of predicates.
 - Added end-to-end unit-tests for tables with decimal type of columns
   for Postgres, MySQL, and Impala-to-Impala.
 - Passed core-tests.

Change-Id: I8c9d2e0667c42c0e52436b158e3dfe3ec14b9e3b
Reviewed-on: http://gerrit.cloudera.org:8080/21218
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Reviewed-by: Abhishek Rawat <arawat@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
wzhou-code
2024-03-23 17:18:35 -07:00
committed by Impala Public Jenkins
parent 4be5fd8896
commit e50bfa8376
14 changed files with 576 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/thrift/generate_error_codes.py
View File

@@ -487,7 +487,9 @@ error_codes = (
("STATESTORE_INCOMPATIBLE_PROTOCOL", 158,
"Subscriber '$0' has incompatible protocol version V$1 conflicting with statestored's "
"version V$2")
"version V$2"),
("JDBC_CONFIGURATION_ERROR", 159, "Error in JDBC table configuration: $0.")
)
import sys