jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-23 21:08:39 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13411: Fix DCHECK fires for scan nodes that produce zero-length tuples

Browse Source 
Removed the DCHECK assertion that tuple_data_len must be greater
than zero in tuple-file-writer.cc and tuple-file-reader.cc,
because in certain cases, such as count(*), tuple_data_len can
be zero, as no column data is returned and only the row count
matters.

Tests:
Adds TestTupleCacheCountStar for the regression test.

Change-Id: I264b537f0eb678b65081e90c21726198f254513d
Reviewed-on: http://gerrit.cloudera.org:8080/21953
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Yida Wu
2024-10-16 19:33:59 -07:00
committed by Impala Public Jenkins
parent e4c05fce59
commit f5a8771a98
3 changed files with 31 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/custom_cluster/test_tuple_cache.py
View File

@@ -675,3 +675,31 @@ class TestTupleCacheRuntimeKeys(TestTupleCacheBase):
assert len(before_result_set) + 1 == len(after_insert_result_set)
different_rows = before_result_set.symmetric_difference(after_insert_result_set)
assert len(different_rows) == 1
class TestTupleCacheCountStar(TestTupleCacheBase):
@classmethod
def add_test_dimensions(cls):
super(TestTupleCacheCountStar, cls).add_test_dimensions()
add_exec_option_dimension(cls, 'mt_dop', [0, 2])
@CustomClusterTestSuite.with_args(
start_args=CACHE_START_ARGS, cluster_size=1)
@pytest.mark.execute_serially
def test_tuple_cache_count_star(self, vector, unique_database):
"""
This test is a regression test for IMPALA-13411 to see whether it hits
the DCHECK.
"""
self.client.set_configuration(vector.get_value('exec_option'))
fq_table = "{0}.tuple_cache_count_star".format(unique_database)
# Create a table.
self.create_table(fq_table, scale=1)
# Run twice and see if it hits the DCHECK.
query = "select count(*) from {0}".format(fq_table)
result1 = self.execute_query(query)
result2 = self.execute_query(query)
assert result1.success and result2.success