jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-23 21:08:39 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13929: Make 'functional-query' the default workload in tests

Browse Source 
This change adds get_workload() to ImpalaTestSuite and removes it
from all test suites that already returned 'functional-query'.
get_workload() is also removed from CustomClusterTestSuite which
used to return 'tpch'.

All other changes besides impala_test_suite.py and
custom_cluster_test_suite.py are just mass removals of
get_workload() functions.

The behavior is only changed in custom cluster tests that didn't
override get_workload(). By returning 'functional-query' instead
of 'tpch', exploration_strategy() will no longer return 'core' in
'exhaustive' test runs. See IMPALA-3947 on why workload affected
exploration_strategy. An example for affected test is
TestCatalogHMSFailures which was skipped both in core and exhaustive
runs before this change.

get_workload() functions that return a different workload than
'functional-query' are not changed - it is possible that some of
these also don't handle exploration_strategy() as expected, but
individually checking these tests is out of scope in this patch.

Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115
Reviewed-on: http://gerrit.cloudera.org:8080/22726
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
Reviewed-by: Daniel Becker <daniel.becker@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Csaba Ringhofer
2025-04-03 12:40:05 +02:00
parent bad56af62c
commit f98b697c7b
189 changed files with 12 additions and 1282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/custom_cluster/test_logging.py
View File

@@ -28,10 +28,6 @@ LOG = logging.getLogger(__name__)
class TestLoggingCore(CustomClusterTestSuite):
"""Test existence of certain log lines under some scenario."""
@classmethod
def get_workload(cls):
return 'functional-query'
def _test_max_errors(self, max_error_logs_per_instance, max_errors, expect_downgraded):
"""Test that number of non-fatal error printed to INFO log is limited by
max_errors and max_error_logs_per_instance."""
@@ -73,10 +69,6 @@ class TestLogFlushPermissionDenied(CustomClusterTestSuite):
"""Test logging of failures to open log files with cause Permission denied."""
LOG_FLUSH_FAILURES_DIR = "log_flush_failures_dir"
@classmethod
def get_workload(cls):
return 'functional-query'
def setup_method(self, method):
# Override parent
super(TestLogFlushPermissionDenied, self).setup_method(method)