Commit Graph

2 Commits

Author SHA1 Message Date
ishaan
d3ffdbea15 IMPALA-644 The shell takes too long to parse a query file.
The shell uses an external module called sqlparse to strip the comments from a query file.
When sqlparse.format() is invoked, it runs several grouping functions on the
tokenized query text; some of these methods are very slow, and not needed for comment
removal. This change restricts sqlparse to only invoke the grouping function for removing
comments.

Change-Id: I3a067187667fcd3cd331156a325960a3de2db9c2
Reviewed-on: http://gerrit.ent.cloudera.com:8080/944
Reviewed-by: Ishaan Joshi <ishaan@cloudera.com>
Tested-by: jenkins
2014-01-08 10:54:11 -08:00
ishaan
1656e779b9 Improved comment parsing in query file passed to the shell 2014-01-08 10:50:03 -08:00