mirror of
https://github.com/apache/impala.git
synced 2025-12-23 21:08:39 -05:00
There is not much benefit in printing the stack trace when Thrift RPC hits an error. As long as we print enough info about the error and identify the caller, that should be sufficient. In fact, it has been observed that stack crawl caused unnecessary CPU spikes in the past. This change replaces Status() with Status::Expected() in DoRpc(), RetryRpc(), RetryRpcRecv() and Coordinator::BackendState::Exec() to avoid unnecessary stack crawls. Testing done: private core build. Verified error strings with test_rpc_timeout.py and test_rpc_exception.py Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Reviewed-on: http://gerrit.cloudera.org:8080/8788 Reviewed-by: Michael Ho <kwho@cloudera.com> Tested-by: Impala Public Jenkins