mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
749d664c60
Impala Shell gets cookies from an HTTMessage object formed from a
response to an HTTP message. The format of cookies in the message
differs across the python versions. In Python 2 the HTTPMessage is a
mimetools.Message object, and the Set-Cookie values all appear in a
single header, separated by newlines. In Python 3 the HTTPMessage is an
email.message.Message, and the Set-Cookie values appear as duplicate
headers.
Add platform dependent code to get_all_matching_cookies() that loads
cookies from all the Set-Cookie headers.
TESTING:
Changed test_get_all_matching_cookies() to build the HTTPMessage
using a new utility method that creates Set-Cookie headers in
the appropriate format for the platform.
Validated that the KNOX_BACKEND-IMPALA cookies is correctly set in
Impala Shell on a Red Hat 9 system using Python 3 (which is how
the problem was first observed).
Change-Id: I057b5c2b9d78e36f32865537d091c4ac0e80d37f
Reviewed-on: http://gerrit.cloudera.org:8080/20216
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
76 lines
2.2 KiB
Python
76 lines
2.2 KiB
Python
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import datetime
|
|
import os.path
|
|
import sys
|
|
|
|
from six.moves import http_cookies
|
|
|
|
|
|
def cookie_matches_path(c, path):
|
|
if 'path' not in c or not c['path']:
|
|
return True
|
|
cookie_path = c['path'].strip()
|
|
if not cookie_path.startswith('/'):
|
|
cookie_path = '/' + cookie_path
|
|
cookie_path = os.path.normpath(cookie_path)
|
|
if cookie_path == '/':
|
|
return True
|
|
if not path.startswith('/'):
|
|
path = '/' + path
|
|
path = os.path.normpath(path)
|
|
return path == cookie_path or path.startswith(cookie_path + '/')
|
|
|
|
|
|
def get_cookie_expiry(c):
|
|
if 'max-age' in c and c['max-age']:
|
|
try:
|
|
max_age_sec = int(c['max-age'])
|
|
return datetime.datetime.now() + datetime.timedelta(seconds=max_age_sec)
|
|
except Exception:
|
|
pass
|
|
# TODO: implement support for 'expires' cookie attribute as well.
|
|
return None
|
|
|
|
|
|
def get_all_matching_cookies(cookie_names, path, resp_headers):
|
|
matching_cookies = None
|
|
if 'Set-Cookie' not in resp_headers:
|
|
return None
|
|
|
|
cookies = http_cookies.SimpleCookie()
|
|
try:
|
|
if sys.version_info.major == 2:
|
|
cookies.load(resp_headers['Set-Cookie'])
|
|
else:
|
|
cookie_headers = resp_headers.get_all('Set-Cookie')
|
|
for header in cookie_headers:
|
|
cookies.load(header)
|
|
except Exception:
|
|
return None
|
|
|
|
matching_cookies = []
|
|
for cn in cookie_names:
|
|
if cn in cookies:
|
|
c = cookies[cn]
|
|
if c and cookie_matches_path(c, path):
|
|
matching_cookies.append(c)
|
|
return matching_cookies
|