mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
1f3160b4c0
This wraps each command executed by CMake with a wrapper that generates a JUnitXML file if the command fails. If the command succeeds, the wrapper does nothing. The wrapper applies to C++ compilation, linking, and custom shell commands (such as building the frontend via maven). It does not apply to failures coming from CMake itself. It can be disabled by setting DISABLE_CMAKE_JUNITXML. The command output can include Unicode (e.g. smart quotes for g++), so this also updates generate_junitxml.py to handle Unicode. The wrapper interacts poorly with add_custom_command/add_custom_target CMake commands that use 'cd directory && do_something', so this switches those locations (in /docker) to use CMake's WORKING_DIRECTORY. Testing: - Verified it does not impact a successful build (including with ccache and/or distcc). - Verified it generates JUnitXML for C++ and Java compilation failures. - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML is set. Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23 Reviewed-on: http://gerrit.cloudera.org:8080/12668 Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
62 lines
2.9 KiB
Bash
Executable File
62 lines
2.9 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# This is a simple wrapper that runs the shell command specified by the arguments
|
|
# and generates a JUnitXML file if the command fails. It incorporates the output
|
|
# of the command into the JUnitXML file.
|
|
#
|
|
# This works best when it is invoking a single executable with arguments. There
|
|
# are some known limitations when invoked from the shell (as it would be if invoked
|
|
# by Make):
|
|
# 1. For a string of commands 'junitxml_command_wrapper.sh A && B && C', it only sees
|
|
# the first one (A). The command A runs in its own shell, so any state it sets for
|
|
# the shell is not seen in B && C. For example, if A = "cd directory", then B and
|
|
# C would not see the changed directory.
|
|
# 2. For output piping 'junitxml_command_wrapper.sh A | B", again it only sees the
|
|
# first one (A). It does leave the output unchanged (stdout remains stdout, stderr
|
|
# remains stderr), but if command B fails, it will not generate JUnitXML.
|
|
|
|
COMMAND=("$@")
|
|
|
|
# Run the command, piping output to temporary files. Note that this output can
|
|
# contain Unicode characters, because g++ (and likely others) can generate smart
|
|
# quotes.
|
|
STDOUT_TMP_FILE=$(mktemp)
|
|
STDERR_TMP_FILE=$(mktemp)
|
|
# The command's stdout and stderr need to remain separate, and we tee them to separate
|
|
# files. Some CMake build steps have a command like "command1 | command2"
|
|
# and command2 should not see stderr. That also means that this script must not produce
|
|
# its own output when the command runs successfully.
|
|
"${COMMAND[@]}" > >(tee "${STDOUT_TMP_FILE}") 2> >(tee "${STDERR_TMP_FILE}" >&2)
|
|
COMMAND_RET_CODE=${PIPESTATUS[0]}
|
|
if [[ ${COMMAND_RET_CODE} -ne 0 ]]; then
|
|
# Use a hash of the command to make sure multiple build failures generate distinct
|
|
# symptoms
|
|
# TODO: It would make sense to do some better parsing of the command to produce
|
|
# a better filename.
|
|
HASH=$(echo "${COMMAND[*]}" | md5sum | cut -d" " -f1)
|
|
"${IMPALA_HOME}"/bin/generate_junitxml.py --phase build --step "${HASH}" \
|
|
--error "Build command failed: ${COMMAND[*]}" \
|
|
--stdout "$(head -n 1000 ${STDOUT_TMP_FILE})" \
|
|
--stderr "$(head -n 1000 ${STDERR_TMP_FILE})"
|
|
fi
|
|
rm "${STDOUT_TMP_FILE}"
|
|
rm "${STDERR_TMP_FILE}"
|
|
exit "${COMMAND_RET_CODE}"
|