mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
56ee90c598
The locations for native-toolchain packages in IMPALA_TOOLCHAIN currently do not include the compiler version. This means that the toolchain can't distinguish between native-toolchain packages built with gcc 4.9.2 versus gcc 7.5.0. The collisions can cause issues when switching back and forth between branches. This introduces the IMPALA_TOOLCHAIN_PACKAGES_HOME environment variable, which is a location inside IMPALA_TOOLCHAIN that would hold native-toolchain packages. Currently, it is set to the same as IMPALA_TOOLCHAIN, so there is no difference in behavior. This lays the groundwork to add the compiler version to this path when switching to GCC7. Testing: - The only impediment to building with IMPALA_TOOLCHAIN_PACKAGES_HOME=$IMPALA_TOOLCHAIN/test is Impala-lzo. With a custom Impala-lzo, compilation succeeds. Either Impala-lzo will be fixed or it will be removed. - Core tests Change-Id: I1ff641e503b2161baf415355452f86b6c8bfb15b Reviewed-on: http://gerrit.cloudera.org:8080/15991 Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
53 lines
2.1 KiB
CMake
53 lines
2.1 KiB
CMake
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# If Impala is built with the toolchain, change compiler and link paths
|
|
set(GCC_ROOT $ENV{IMPALA_TOOLCHAIN_PACKAGES_HOME}/gcc-$ENV{IMPALA_GCC_VERSION})
|
|
|
|
# Use the appropriate LLVM version to build ASAN.
|
|
set(LLVM_ASAN_ROOT
|
|
$ENV{IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-$ENV{IMPALA_LLVM_ASAN_VERSION})
|
|
|
|
set(LLVM_ROOT $ENV{IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-$ENV{IMPALA_LLVM_VERSION})
|
|
|
|
if ("${CMAKE_BUILD_TYPE}" STREQUAL "ADDRESS_SANITIZER")
|
|
set(CMAKE_C_COMPILER ${LLVM_ASAN_ROOT}/bin/clang)
|
|
else()
|
|
set(CMAKE_C_COMPILER ${LLVM_ROOT}/bin/clang)
|
|
endif()
|
|
|
|
# Use clang to build unless overridden by environment.
|
|
if($ENV{IMPALA_CXX_COMPILER} STREQUAL "default")
|
|
if ("${CMAKE_BUILD_TYPE}" STREQUAL "ADDRESS_SANITIZER")
|
|
set(CMAKE_CXX_COMPILER ${LLVM_ASAN_ROOT}/bin/clang++)
|
|
else()
|
|
set(CMAKE_CXX_COMPILER ${LLVM_ROOT}/bin/clang++)
|
|
endif()
|
|
else()
|
|
set(CMAKE_CXX_COMPILER $ENV{IMPALA_CXX_COMPILER})
|
|
endif()
|
|
|
|
# Add the GCC root location to the compiler flags
|
|
set(CXX_COMMON_FLAGS "--gcc-toolchain=${GCC_ROOT}")
|
|
|
|
# The rpath is needed to be able to run the binaries produced by the toolchain without
|
|
# specifying an LD_LIBRARY_PATH
|
|
set(TOOLCHAIN_LINK_FLAGS "-Wl,-rpath,${GCC_ROOT}/lib64")
|
|
set(TOOLCHAIN_LINK_FLAGS "${TOOLCHAIN_LINK_FLAGS} -L${GCC_ROOT}/lib64")
|
|
|
|
message(STATUS "Setup toolchain link flags ${TOOLCHAIN_LINK_FLAGS}")
|