mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
780e6683a2
This commit contains the simpler parts from https://gerrit.cloudera.org/#/c/20602 This mainly means accessors for the header of the binary format and bounding box check (st_envIntersects). New tests for not yet covered functions / overloads are also added. For details of the binary format see be/src/exprs/geo/shape-format.h Differences from the PR above: Only a subset of functions are added. The criteria was: 1. the native function must be fully compatible with the Java version* 2. must not rely on (de)serializing the full geometry 3. the function must be tested 1 implies 2 because (de)serialization is not implemented yet in the original patch for >2d geometries, which would break compatibility for the Java version for ZYZ/XYM/XYZM geometries. *: there are 2 known differences: 1. NULL handling: the Java functions return error instead of NULL when getting a NULL parameter 2. st_envIntersects() doesn't check if the SRID matches - the Java library looks inconsistant about this Because the native functions are fairly safe replacements for the Java ones, they are always used when geospatial_library=HIVE_ESRI. Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Reviewed-on: http://gerrit.cloudera.org:8080/23700 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
46 lines
1.8 KiB
Python
46 lines
1.8 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
import pytest
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.common.skip import SkipIfApacheHive
|
|
|
|
ST_POINT_SIGNATURE = "BINARY\tst_point(STRING)\tJAVA\ttrue"
|
|
ST_X_SIGNATURE_BUILTIN = "DOUBLE\tst_x(BINARY)\tBUILTIN\ttrue"
|
|
SHOW_FUNCTIONS = "show functions in _impala_builtins"
|
|
|
|
|
|
class TestGeospatialLibrary(CustomClusterTestSuite):
|
|
"""Tests the geospatial_library backend flag"""
|
|
|
|
@CustomClusterTestSuite.with_args(start_args='--geospatial_library=NONE')
|
|
@SkipIfApacheHive.feature_not_supported
|
|
@pytest.mark.execute_serially
|
|
def test_disabled(self):
|
|
result = self.execute_query(SHOW_FUNCTIONS)
|
|
assert ST_POINT_SIGNATURE not in result.data
|
|
assert ST_X_SIGNATURE_BUILTIN not in result.data
|
|
|
|
@SkipIfApacheHive.feature_not_supported
|
|
@pytest.mark.execute_serially
|
|
def test_enabled(self):
|
|
result = self.execute_query(SHOW_FUNCTIONS)
|
|
assert ST_POINT_SIGNATURE in result.data
|
|
assert ST_X_SIGNATURE_BUILTIN in result.data
|