mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
f98b697c7b
This change adds get_workload() to ImpalaTestSuite and removes it from all test suites that already returned 'functional-query'. get_workload() is also removed from CustomClusterTestSuite which used to return 'tpch'. All other changes besides impala_test_suite.py and custom_cluster_test_suite.py are just mass removals of get_workload() functions. The behavior is only changed in custom cluster tests that didn't override get_workload(). By returning 'functional-query' instead of 'tpch', exploration_strategy() will no longer return 'core' in 'exhaustive' test runs. See IMPALA-3947 on why workload affected exploration_strategy. An example for affected test is TestCatalogHMSFailures which was skipped both in core and exhaustive runs before this change. get_workload() functions that return a different workload than 'functional-query' are not changed - it is possible that some of these also don't handle exploration_strategy() as expected, but individually checking these tests is out of scope in this patch. Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Reviewed-on: http://gerrit.cloudera.org:8080/22726 Reviewed-by: Riza Suminto <riza.suminto@cloudera.com> Reviewed-by: Daniel Becker <daniel.becker@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
51 lines
2.2 KiB
Python
51 lines
2.2 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
import pytest
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
|
|
|
|
class TestIcebergStrictDataFileLocation(CustomClusterTestSuite):
|
|
"""Tests for checking the behaviour of startup flag
|
|
'iceberg_allow_datafiles_in_table_location_only'."""
|
|
|
|
SELECT_STATEMENT = "SELECT COUNT(1) FROM " \
|
|
"functional_parquet.iceberg_multiple_storage_locations"
|
|
EXCEPTION = "IcebergTableLoadingException: " \
|
|
"Error loading metadata for Iceberg table"
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
catalogd_args='--iceberg_allow_datafiles_in_table_location_only=true')
|
|
@pytest.mark.execute_serially
|
|
def test_restricted_location(self, vector):
|
|
"""If the flag is enabled, tables with multiple storage locations will fail
|
|
to load their datafiles."""
|
|
result = self.execute_query_expect_failure(self.client, self.SELECT_STATEMENT)
|
|
assert self.EXCEPTION in str(result)
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
catalogd_args='--iceberg_allow_datafiles_in_table_location_only=false')
|
|
@pytest.mark.execute_serially
|
|
def test_disabled(self, vector):
|
|
"""If the flag is disabled, and tables with multiple storage locations
|
|
are configured properly, the tables load successfully."""
|
|
result = self.execute_query_expect_success(self.client, self.SELECT_STATEMENT)
|
|
assert '9' in result.data
|
|
self.run_test_case('QueryTest/iceberg-multiple-storage-locations-table', vector)
|