Files
impala/tests/query_test/test_ext_data_sources.py
Csaba Ringhofer f98b697c7b IMPALA-13929: Make 'functional-query' the default workload in tests
This change adds get_workload() to ImpalaTestSuite and removes it
from all test suites that already returned 'functional-query'.
get_workload() is also removed from CustomClusterTestSuite which
used to return 'tpch'.

All other changes besides impala_test_suite.py and
custom_cluster_test_suite.py are just mass removals of
get_workload() functions.

The behavior is only changed in custom cluster tests that didn't
override get_workload(). By returning 'functional-query' instead
of 'tpch', exploration_strategy() will no longer return 'core' in
'exhaustive' test runs. See IMPALA-3947 on why workload affected
exploration_strategy. An example for affected test is
TestCatalogHMSFailures which was skipped both in core and exhaustive
runs before this change.

get_workload() functions that return a different workload than
'functional-query' are not changed - it is possible that some of
these also don't handle exploration_strategy() as expected, but
individually checking these tests is out of scope in this patch.

Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115
Reviewed-on: http://gerrit.cloudera.org:8080/22726
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
Reviewed-by: Daniel Becker <daniel.becker@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
2025-04-08 07:12:55 +00:00

74 lines
3.2 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import absolute_import, division, print_function
import re
from tests.common.impala_test_suite import ImpalaTestSuite
from tests.common.test_dimensions import (create_uncompressed_text_dimension,
create_exec_option_dimension)
class TestExtDataSources(ImpalaTestSuite):
"""Impala query tests for external data sources."""
@classmethod
def add_test_dimensions(cls):
super(TestExtDataSources, cls).add_test_dimensions()
cls.ImpalaTestMatrix.add_dimension(
create_exec_option_dimension(exec_single_node_option=[0, 100]))
cls.ImpalaTestMatrix.add_dimension(
create_uncompressed_text_dimension(cls.get_workload()))
def _get_tbl_properties(self, table_name):
"""Extracts the table properties mapping from the output of DESCRIBE FORMATTED"""
return self._get_properties('Table Parameters:', table_name)
def test_verify_jdbc_table_properties(self, vector):
jdbc_tbl_name = "functional.alltypes_jdbc_datasource"
properties = self._get_tbl_properties(jdbc_tbl_name)
# Verify table properties specific for external JDBC table
assert properties['__IMPALA_DATA_SOURCE_NAME'] == 'impalajdbcdatasource'
assert properties['database.type'] == 'POSTGRES'
assert properties['jdbc.driver'] == 'org.postgresql.Driver'
assert properties['dbcp.username'] == 'hiveuser'
assert properties['table'] == 'alltypes'
# Verify dbcp.password is masked in the output of DESCRIBE FORMATTED command
assert properties['dbcp.password'] == '******'
# Verify dbcp.password is masked in the output of SHOW CREATE TABLE command
result = self.client.execute("SHOW CREATE TABLE {0}".format(jdbc_tbl_name))
match = False
for row in result.data:
if "'dbcp.password'='******'" in row:
match = True
break
assert match, result.data
def test_data_source_tables(self, vector, unique_database, unique_name):
self.run_test_case('QueryTest/data-source-tables', vector, use_db=unique_database,
test_file_vars={'$UNIQUE_DATASOURCE': unique_name})
def test_jdbc_data_source(self, vector, unique_database):
self.run_test_case('QueryTest/jdbc-data-source', vector, use_db=unique_database)
def test_jdbc_data_source_with_keystore(self, vector, unique_database):
# Impala query tests for external data sources with keystore.
self.run_test_case('QueryTest/jdbc-data-source-with-keystore', vector,
use_db=unique_database)