Files
impala/tests/query_test/test_scratch_limit.py
Csaba Ringhofer f98b697c7b IMPALA-13929: Make 'functional-query' the default workload in tests
This change adds get_workload() to ImpalaTestSuite and removes it
from all test suites that already returned 'functional-query'.
get_workload() is also removed from CustomClusterTestSuite which
used to return 'tpch'.

All other changes besides impala_test_suite.py and
custom_cluster_test_suite.py are just mass removals of
get_workload() functions.

The behavior is only changed in custom cluster tests that didn't
override get_workload(). By returning 'functional-query' instead
of 'tpch', exploration_strategy() will no longer return 'core' in
'exhaustive' test runs. See IMPALA-3947 on why workload affected
exploration_strategy. An example for affected test is
TestCatalogHMSFailures which was skipped both in core and exhaustive
runs before this change.

get_workload() functions that return a different workload than
'functional-query' are not changed - it is possible that some of
these also don't handle exploration_strategy() as expected, but
individually checking these tests is out of scope in this patch.

Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115
Reviewed-on: http://gerrit.cloudera.org:8080/22726
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
Reviewed-by: Daniel Becker <daniel.becker@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
2025-04-08 07:12:55 +00:00

135 lines
5.6 KiB
Python

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from __future__ import absolute_import, division, print_function
from tests.common.impala_connection import IMPALA_CONNECTION_EXCEPTION
from tests.common.impala_test_suite import ImpalaTestSuite
from tests.common.test_dimensions import create_single_exec_option_dimension
from tests.common.test_dimensions import create_uncompressed_text_dimension
class TestScratchLimit(ImpalaTestSuite):
"""
This class tests the functionality of setting the scratch limit as a query option
"""
spilling_sort_query = """
select o_orderdate, o_custkey, o_comment
from tpch.orders
order by o_orderdate
"""
spilling_agg_query = """
select count(*) from (
select distinct o_orderdate, o_custkey, o_comment
from tpch_parquet.orders) v;
"""
spilling_join_query = """
select count(*)
from tpch_parquet.lineitem join tpch_parquet.orders on l_orderkey = o_orderkey
"""
# The analytic function in this query spills, but the sort generally spills first.
# Ideally we would have a spilling analytic without a sort to exercise it in isolation.
spilling_analytic_query = """
SELECT i_item_sk, i_current_price,
SUM (i_current_price)
OVER (ORDER BY i_item_sk rows between 500000 preceding and 500000 following) running_total
FROM tpcds_parquet.item
ORDER BY i_brand, i_item_sk;
"""
spilling_queries = [spilling_sort_query, spilling_agg_query, spilling_join_query,
spilling_analytic_query]
# Buffer pool limit that is low enough to force Impala to spill to disk when executing
# spill_query.
buffer_pool_limit = "32m"
@classmethod
def add_test_dimensions(cls):
super(TestScratchLimit, cls).add_test_dimensions()
# There is no reason to run these tests using all dimensions.
cls.ImpalaTestMatrix.add_dimension(create_single_exec_option_dimension())
cls.ImpalaTestMatrix.add_dimension(
create_uncompressed_text_dimension(cls.get_workload()))
def test_with_high_scratch_limit(self, vector):
"""
Sort query runs to completion with a scratch limit well above
its required scratch space which in this case is 128m.
"""
exec_option = vector.get_value('exec_option')
exec_option['buffer_pool_limit'] = self.buffer_pool_limit
exec_option['scratch_limit'] = '500m'
self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
def test_with_low_scratch_limit(self, vector):
"""
Sort query throws the appropriate exception with a scratch limit well below
its required scratch space which in this case is 128m.
"""
exec_option = vector.get_value('exec_option')
exec_option['buffer_pool_limit'] = self.buffer_pool_limit
exec_option['scratch_limit'] = '24m'
expected_error = 'Scratch space limit of %s bytes exceeded'
scratch_limit_in_bytes = 24 * 1024 * 1024
try:
self.execute_query(self.spilling_sort_query, exec_option)
assert False, "Query was expected to fail"
except IMPALA_CONNECTION_EXCEPTION as e:
assert expected_error % scratch_limit_in_bytes in str(e)
def test_with_zero_scratch_limit(self, vector):
"""
Queries throws the appropriate exception with a scratch limit of
zero which means no scratch space can be allocated.
"""
exec_option = vector.get_value('exec_option')
exec_option['buffer_pool_limit'] = self.buffer_pool_limit
exec_option['scratch_limit'] = '0'
for query in self.spilling_queries:
self.execute_query_expect_failure(query, exec_option)
def test_with_unlimited_scratch_limit(self, vector):
"""
Sort query runs to completion with a scratch Limit of -1 means default/no limit.
"""
exec_option = vector.get_value('exec_option')
exec_option['buffer_pool_limit'] = self.buffer_pool_limit
exec_option['scratch_limit'] = '-1'
self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
def test_without_specifying_scratch_limit(self, vector):
"""
Sort query runs to completion with the default setting of no scratch limit.
"""
exec_option = vector.get_value('exec_option')
exec_option['buffer_pool_limit'] = self.buffer_pool_limit
self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
def test_with_zero_scratch_limit_no_memory_limit(self, vector):
"""
Queries run to completion without spilling as there is no limit on block memory manger.
Scratch limit of zero ensures spilling is disabled.
"""
exec_option = vector.get_value('exec_option')
exec_option['scratch_limit'] = '0'
for query in self.spilling_queries:
self.execute_query_expect_success(self.client, query, exec_option)
def test_result_spooling_and_varying_scratch_limit(self, vector):
"""
IMPALA-9856 make result spooling default. Since result spooling depends on ability to
spill to disk, query option scratch_limit may affect memory configuration of result
spooling feature. This test vary scratch_limit and verify the memory adjustment.
"""
self.run_test_case('QueryTest/scratch-limit', vector)