mirror of
https://github.com/apache/impala.git
synced 2026-01-19 18:01:45 -05:00
00aef7f79e
When versions change in shell/ext-py/*, there can be leftover directories when developers rebase. These leftover directories are usually empty and unbuildable, so make_shell_tarball.sh will fail with an error message like: Creating an egg for .../Impala/shell/ext-py/bitarray-0.9.0 Traceback (most recent call last): File "<string>", line 1, in <module> IOError: [Errno 2] No such file or directory: 'setup.py' ... This changes the build logic to only build directories that are tracked in git. When a version of an ext-py package changes, the directory for the old version may stick around, but it is gone from the git repository and won't be built. The downside is that when a developer is adding a new package version, it won't be built until it is added in git. This logic is disabled if IMPALA_HOME is not a git repository, which can happen when building from release tarballs. Testing: - Added an empty directory in shell/ext-py that was not tracked in git. Verified it is not built (and would fail before). - Tested the command detecting IMPALA_HOME as a git repository on a non-repository directory. Change-Id: Ibb70ef2d5048d5cfeb260ce62c34f04835c7132d Reviewed-on: http://gerrit.cloudera.org:8080/15886 Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>