mirror of
https://github.com/apache/impala.git
synced 2025-12-25 02:03:09 -05:00
013bcc127f
test_pool_config_change_while_queued now consistently pass in TestAdmissionController and fail in TestAdmissionControllerWithACService. The root cause of this issue is because copy-mem-limit-test-llama-site.xml is only copied once for both tests. TestAdmissionController left max-query-mem-limit of invalidTestPool at 25MB without resetting it back to 0, which then cause test failure at TestAdmissionControllerWithACService. This patch improve the test by always setting max-query-mem-limit of invalidTestPool at 0 both in the beginning and the end of test. Change ResourcePoolConfig to use mem_limit_coordinators and mem_limit_executors because, unlike mem_limit option, they are not subject to pool-level memory clamping. Disable --clamp_query_mem_limit_backend_mem_limit flag so that coord_backend_mem_limit is not clamped to coordinator's process limit. Removed make_copy parameter in test_pool_mem_limit_configs since it does not mutate the config files. Added more log details in admission-controller.cc to help make better association. Testing: - Loop and pass the test in ARM build. Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Reviewed-on: http://gerrit.cloudera.org:8080/23106 Reviewed-by: Yida Wu <wydbaggio000@gmail.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>