mirror of
https://github.com/apache/impala.git
synced 2026-01-01 18:00:30 -05:00
e01ab4f1b2
FunctionContext::Allocate(), FunctionContextImpl::AllocateLocal() and FunctionContext::Reallocate() allocate memory without taking memory limits into account. The problem is that these functions invoke FreePool::Allocate() which may call MemPool::Allocate() that doesn't check against the memory limits. This patch fixes the problem by making these FunctionContext functions check for memory limits and set an error in the FunctionContext object if memory limits are exceeded. An alternative would be for these functions to call MemPool::TryAllocate() instead and return NULL if memory limits are exceeded. However, this may break some existing external UDAs which don't check for allocation failures, leading to unexpected crashes of Impala. Therefore, we stick with this ad hoc approach until the UDF/UDA interfaces are updated in the future releases. Callers of these FunctionContext functions are also updated to handle potential failed allocations instead of operating on NULL pointers. The query status will be polled at various locations and terminate the query. This patch also fixes MemPool to handle the case in which malloc may return NULL. It propagates the failure to the callers instead of continuing to run with NULL pointers. In addition, errors during aggregate functions' initialization are now properly propagated. Change-Id: Icefda795cd685e5d0d8a518cbadd37f02ea5e733 Reviewed-on: http://gerrit.cloudera.org:8080/1445 Reviewed-by: Michael Ho <kwho@cloudera.com> Tested-by: Internal Jenkins
79 lines
1.7 KiB
Plaintext
79 lines
1.7 KiB
Plaintext
====
|
|
---- QUERY
|
|
#Due to somewhat non-determinstic way memory allocation happens in Impala now,
|
|
#we will just check to make sure the exception is a memory allocation failure.
|
|
select group_concat(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select ndv(int_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select min(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select max(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select sample(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select distinctpc(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select distinctpcsa(string_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select rank() over (partition by month order by year) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select extract(year from timestamp_col) from functional.alltypes limit 10
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select trunc(timestamp_col, 'YEAR') from functional.alltypes limit 10
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select first_value(string_col) over (partition by month order by year) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select last_value(string_col) over (partition by month order by year) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select rand() from functional.alltypes;
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select cast(string_col as char(120)) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|
|
---- QUERY
|
|
select appx_median(int_col) from functional.alltypes
|
|
---- CATCH
|
|
failed to allocate
|
|
====
|