mirror of
https://github.com/apache/impala.git
synced 2026-02-01 03:00:22 -05:00
fd35cee887
This patch does a few things: 1) Move the metadata tests into their own folder under tests/. I think it's useful to loosely categorize them so it's easier to run a subset of the tests that are most useful for the changes you are making. 2) Reduce the test vectors for query_tests. We should have identical coverage in the daily exhaustive runs but the normal runs should be much better. In particular, deemphasizing scanner tests since that code is more stable now. 3) Misc test cleanup/consolidate python test files/etc. Change-Id: I03c2f34877aed192c2a50665bd5e15fa85e12f1e Reviewed-on: http://gerrit.sjc.cloudera.com:8080/3831 Tested-by: jenkins Reviewed-by: Nong Li <nong@cloudera.com>
73 lines
2.9 KiB
Python
73 lines
2.9 KiB
Python
#!/usr/bin/env python
|
|
# Copyright (c) 2012 Cloudera, Inc. All rights reserved.
|
|
# Validates limit on scan nodes
|
|
#
|
|
import logging
|
|
import pytest
|
|
from copy import copy
|
|
from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
|
|
from tests.common.impala_test_suite import ImpalaTestSuite
|
|
from tests.common.test_vector import *
|
|
from tests.util.test_file_parser import QueryTestSectionReader
|
|
|
|
class TestLimit(ImpalaTestSuite):
|
|
LIMIT_VALUES = [1, 2, 3, 4, 5, 10, 100, 5000]
|
|
LIMIT_VALUES_CORE = [1, 5, 10, 5000]
|
|
QUERIES = ["select * from lineitem limit %d"]
|
|
|
|
# TODO: we should be able to run count(*) in setup rather than hardcoding the values
|
|
# but I have no idea how to do this with this framework.
|
|
TOTAL_ROWS = 6001215
|
|
|
|
@classmethod
|
|
def get_workload(self):
|
|
return 'tpch'
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestLimit, cls).add_test_dimensions()
|
|
|
|
# Add two more dimensions
|
|
if cls.exploration_strategy() == 'core':
|
|
cls.TestMatrix.add_dimension(
|
|
TestDimension('limit_value', *TestLimit.LIMIT_VALUES_CORE))
|
|
else:
|
|
cls.TestMatrix.add_dimension(
|
|
TestDimension('limit_value', *TestLimit.LIMIT_VALUES))
|
|
cls.TestMatrix.add_dimension(TestDimension('query', *TestLimit.QUERIES))
|
|
|
|
# Don't run with large limits and tiny batch sizes. This generates excessive
|
|
# network traffic and makes the machine run very slowly.
|
|
cls.TestMatrix.add_constraint(lambda v:\
|
|
v.get_value('limit_value') < 100 or v.get_value('exec_option')['batch_size'] == 0)
|
|
# TPCH is not generated in hbase format.
|
|
# TODO: Add test coverage for hbase.
|
|
cls.TestMatrix.add_constraint(lambda v:\
|
|
v.get_value('table_format').file_format != "hbase")
|
|
|
|
def test_limit(self, vector):
|
|
# We can't validate the rows that are returned since that is non-deterministic.
|
|
# This is why this is a python test rather than a .test.
|
|
limit = vector.get_value('limit_value')
|
|
expected_num_rows = min(limit, TestLimit.TOTAL_ROWS)
|
|
query_string = vector.get_value('query') % limit
|
|
result = self.execute_query(query_string, vector.get_value('exec_option'),
|
|
table_format=vector.get_value('table_format'))
|
|
assert(len(result.data) == expected_num_rows)
|
|
|
|
# Base class for TestLimit
|
|
class TestLimitBase(ImpalaTestSuite):
|
|
def exec_query_validate(self, query, exec_options, should_succeed, expected_rows,
|
|
expected_error):
|
|
"""Executes a query and validates the results"""
|
|
try:
|
|
result = self.execute_query(query, exec_options)
|
|
assert should_succeed, 'Query was expected to fail'
|
|
assert len(result.data) == expected_rows,\
|
|
'Wrong number of rows returned %d' % len(result.data)
|
|
except ImpalaBeeswaxException as e:
|
|
assert not should_succeed, 'Query was not expected to fail: %s' % e
|
|
if (expected_error not in str(e)):
|
|
print str(e)
|
|
assert expected_error in str(e)
|