mirror of
https://github.com/apache/impala.git
synced 2025-12-30 12:02:10 -05:00
35dada4656
IMPALA-11384 broke incremental builds because:
* added a custom target that always rewrites a few generated
header files
** The files are getting included directly/indirectly in most files,
so we always need to recompile a large part of the project
* Didn't remove ${THRIFT_FILE_WE}_constants.cpp/h dependency from
common/thrift/CMakeLists.txt
** These files are not generated anymore, so the build system always
reconstruct all the generated files (because *_constant.cpp/h is
always missing), and then builds every target that depend on them.
IMPALA-11415 fixes a sporadic error during data loading, but it only
hides the root cause, i.e. unnecessary recreation of thrift files.
This patch reverts IMPALA-11415 because:
* to make data-load more parallel
* to not hide similar issues in the future
Testing
* Tested locally that the thrift files are not getting regenerated
Change-Id: Ieb0e2007f3fa0cc721bd7b272956ce206ac65b0e
Reviewed-on: http://gerrit.cloudera.org:8080/18708
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>