Files
impala/bin/generate_xml_config.py
Laszlo Gaal 2cf5777892 IMPALA-13826: Migrate from imp to importlib in the config generator
Python has deprecated the 'imp' package in Python 3.4, and removed it in
Python 3.12. The deprecation has also started throwing warnings in
versions before 3.12.

The template generator used a single call to imp.load_source to load the
template Python file. This is now replaced with code snippet published
in Python's official documentation.

Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031
Reviewed-on: http://gerrit.cloudera.org:8080/22582
Reviewed-by: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Tested-by: Laszlo Gaal <laszlo.gaal@cloudera.com>
2025-03-28 13:40:38 +00:00

152 lines
4.8 KiB
Python
Executable File

#!/usr/bin/env python
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""
Script which uses a Python "template" to generate a Hadoop-style XML
configuration file.
The "template" is a Python module which should export a global variable called
'CONFIG'. This variable should be a dictionary of keys/values. The values may
use the special syntax '${FOO}' to substitute an environment variable (as a
convenience over manually implementing the same).
If you have an existing XML configuration and want to see it in convenient
python form, you can use a snippet like the following from within the Python
REPL:
import xml.etree.ElementTree as ET
import pprint
def convert(path):
e = ET.parse(path)
c = dict([(property.findtext('name'), property.findtext('value'))
for property in e.getroot()])
pprint.pprint(c, stream=file(path + ".py", "w"))
"""
from __future__ import absolute_import, division, print_function
import os
import re
import sys
from textwrap import dedent
from xml.sax.saxutils import escape as xmlescape
ENV_VAR_RE = re.compile(r'\${(.+?)\}')
def _substitute_env_vars(s):
""" Substitute ${FOO} with the $FOO environment variable in 's' """
def lookup_func(match):
return os.environ[match.group(1)]
return ENV_VAR_RE.sub(lookup_func, s)
def dump_config(d, source_path, out):
"""
Dump a Hadoop-style XML configuration file.
'd': a dictionary of name/value pairs.
'source_path': the path where 'd' was parsed from.
'out': stream to write to
"""
header = """\
<?xml version="1.0"?>
<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
<!--
NOTE: THIS FILE IS AUTO-GENERATED FROM:
{source_path}
EDITS BY HAND WILL BE LOST!
-->
<configuration>""".format(source_path=os.path.abspath(source_path))
print(dedent(header), file=out)
for k, v in sorted(d.items()):
try:
k_new = _substitute_env_vars(k)
if isinstance(v, int):
v = str(v)
v_new = _substitute_env_vars(v)
except KeyError as e:
raise Exception("failed environment variable substitution for value {k}: {e}"
.format(k=k, e=e))
print("""\
<property>
<name>{name}</name>
<value>{value}</value>
</property>""".format(name=xmlescape(k_new), value=xmlescape(v_new)), file=out)
print("</configuration>", file=out)
def load_source_with_importlib(modname, filename):
""""Emulate imp.load_source() of Python2 for Python3 using importlib
Code taken from published Python documentation, see
https://docs.python.org/3/whatsnew/3.12.html#imp"""
import importlib.util
import importlib.machinery
loader = importlib.machinery.SourceFileLoader(modname, filename)
spec = importlib.util.spec_from_file_location(modname, filename, loader=loader)
module = importlib.util.module_from_spec(spec)
# The module is always executed and not cached in sys.modules.
# Uncomment the following line to cache the module.
# sys.modules[module.__name__] = module
loader.exec_module(module)
return module
def import_template(name, module_path):
"""Handle module import differences between Python2 and Python3"""
mod = None
if sys.version_info.major < 3:
import imp
mod = imp.load_source('template', module_path)
else:
mod = load_source_with_importlib(name, module_path)
return mod
def main():
if len(sys.argv) != 3:
print("usage: {prog} <template> <out>".format(prog=sys.argv[0]), file=sys.stderr)
sys.exit(1)
_, in_path, out_path = sys.argv
try:
mod = import_template('template', in_path)
except: # noqa
print("Unable to load template: %s" % in_path, file=sys.stderr)
raise
conf = mod.__dict__.get('CONFIG')
if not isinstance(conf, dict):
raise Exception("module in '{path}' should define a dict named CONFIG"
.format(path=in_path))
tmp_path = out_path + ".tmp"
with open(tmp_path, "w") as out:
try:
dump_config(conf, in_path, out)
except: # noqa
os.unlink(tmp_path)
raise
os.rename(tmp_path, out_path)
if __name__ == "__main__":
main()