mirror of
https://github.com/apache/impala.git
synced 2026-01-10 00:00:16 -05:00
d79e01ef9f
If Impala was built with --build_shared_libs, some thirdparty libraries were still statically linked; this could cause runtime errors if the libraries were also linked into a .so. This patch fixes that issue (for gflags, glog and protobuf at least) by ensuring that build_shared_libs is respected for those libraries. * Standardize thirdparty library handling w/CMake by adding IMPALA_ADD_THIRDPARTY_LIB. This creates a symbolic name for each library, allowing us to switch the underlying library files (e.g. change from static to dynamic linking) without having to individually change the link clauses for each target. * Remove most cases of add_library() from cmake_modules/* - that is all handled by IMPALA_ADD_THIRDPARTY_LIB. * Add shared library detection for a couple of thirdparty dependencies (many only detect static libraries), just to prove the concept. * All thirdparty libraries now print a standard set of messages. For example: -- ----------> Adding thirdparty library protoc. <---------- -- Header files: /data/henry/src/cloudera/impala-toolchain/protobuf-2.6.1/include -- Added shared library dependency protoc: /data/henry/src/cloudera/impala-toolchain/protobuf-2.6.1/lib/libprotoc.so -- ----------> Adding thirdparty library libev. <---------- -- Header files: /data/henry/src/cloudera/impala-toolchain/libev-4.20/include -- Added shared library dependency libev: /data/henry/src/cloudera/impala-toolchain/libev-4.20/lib/libev.so * Some libraries don't quite fit this pattern (LLVM and Boost) - leave them as is for now. * Remove FindOpenSSL.cmake - the toolchain one is more modern. Change-Id: Ib7a6bc5610aaf2450f91348d94cfb984c6a4b78d Reviewed-on: http://gerrit.cloudera.org:8080/7418 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
64 lines
2.3 KiB
CMake
64 lines
2.3 KiB
CMake
##############################################################################
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
##############################################################################
|
|
|
|
# - Find GFLAGS (gflags.h, libgflags.a, libgflags.so, and libgflags.so.0) with
|
|
# GFLAGS_ROOT hinting a location
|
|
#
|
|
# This module defines
|
|
# GFLAGS_INCLUDE_DIR, directory containing headers
|
|
# GFLAGS_LIBS, directory containing gflag libraries
|
|
# GFLAGS_STATIC_LIB, path to libgflags.a
|
|
# GFLAGS_SHARED_LIB, path to libgflags.so
|
|
|
|
set(GFLAGS_SEARCH_HEADER_PATHS
|
|
${GFLAGS_ROOT}/include
|
|
$ENV{IMPALA_HOME}/thirdparty/gflags-$ENV{IMPALA_GFLAGS_VERSION}/src
|
|
)
|
|
|
|
set(GFLAGS_SEARCH_LIB_PATH
|
|
${GFLAGS_ROOT}/lib
|
|
$ENV{IMPALA_HOME}/thirdparty/gflags-$ENV{IMPALA_GFLAGS_VERSION}/.libs
|
|
)
|
|
|
|
find_path(GFLAGS_INCLUDE_DIR gflags/gflags.h PATHS
|
|
${GFLAGS_SEARCH_HEADER_PATHS}
|
|
# make sure we don't accidentally pick up a different version
|
|
NO_DEFAULT_PATH
|
|
)
|
|
|
|
find_library(GFLAGS_LIBS NAMES gflags PATHS ${GFLAGS_SEARCH_LIB_PATH})
|
|
find_library(GFLAGS_STATIC_LIB NAMES libgflags.a PATHS ${GFLAGS_SEARCH_LIB_PATH})
|
|
find_library(GFLAGS_SHARED_LIB NAMES libgflags.so PATHS ${GFLAGS_SEARCH_LIB_PATH})
|
|
|
|
if (NOT GFLAGS_LIBS OR NOT GFLAGS_STATIC_LIB OR NOT GFLAGS_SHARED_LIB)
|
|
message(FATAL_ERROR "GFlags includes and libraries NOT found. "
|
|
"Looked for headers in ${GFLAGS_SEARCH_HEADER_PATHS}, "
|
|
"and for libs in ${GFLAGS_SEARCH_LIB_PATH}")
|
|
set(GFLAGS_FOUND FALSE)
|
|
else()
|
|
set(GFLAGS_FOUND TRUE)
|
|
endif ()
|
|
|
|
mark_as_advanced(
|
|
GFLAGS_INCLUDE_DIR
|
|
GFLAGS_LIBS
|
|
GFLAGS_STATIC_LIB
|
|
GFLAGS_SHARED_LIB
|
|
)
|