mirror of
https://github.com/apache/impala.git
synced 2025-12-23 21:08:39 -05:00
5dccf8024b
convert_legacy_hive_parquet_utc_timestamps and use_local_tz_for_unix_timestamp_conversions were controllable only by flags until now. After this change the old flags are only used on the Coordinator to set the defaults for the query options. If default_query_options also sets these query options, it will take precedence over the old flags. Possible follow up work: - the old flags could be deprecated, as default_query_options can be used to set this on a server level - testing these functionalities no longer needs custom cluster tests - rewriting the existing tests could speed up test execution Testing: - expr-test was rewritten to use the query option instead of the flag - extended the custom cluster tests for the old flags to also use the query options - ran related tests Change-Id: I5c4252d1c8f8e224c1d0e8234f09374bcc0c6f68 Reviewed-on: http://gerrit.cloudera.org:8080/16469 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
76 lines
3.5 KiB
Python
76 lines
3.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import pytest
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.common.impala_test_suite import ImpalaTestSuite
|
|
from tests.common.test_vector import ImpalaTestDimension
|
|
from tests.common.skip import SkipIfABFS, SkipIfADLS, SkipIfS3
|
|
from tests.common.test_dimensions import create_exec_option_dimension
|
|
|
|
class TestLocalTzConversion(CustomClusterTestSuite):
|
|
"""Tests for --use_local_tz_for_unix_timestamp_conversions"""
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestLocalTzConversion, cls).add_test_dimensions()
|
|
cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension(
|
|
cluster_sizes=[0], disable_codegen_options=[False, True], batch_sizes=[0]))
|
|
# Test with and without expr rewrites to cover regular expr evaluations
|
|
# as well as constant folding, in particular, timestamp literals.
|
|
cls.ImpalaTestMatrix.add_dimension(
|
|
ImpalaTestDimension('enable_expr_rewrites', *[0,1]))
|
|
|
|
@classmethod
|
|
def add_custom_cluster_constraints(cls):
|
|
# Do not call the super() implementation because this class needs to relax the
|
|
# set of constraints.
|
|
cls.ImpalaTestMatrix.add_constraint(lambda v:
|
|
v.get_value('table_format').file_format == 'text' and
|
|
v.get_value('table_format').compression_codec == 'none')
|
|
|
|
@classmethod
|
|
def get_workload(self):
|
|
return 'functional-query'
|
|
|
|
@SkipIfABFS.hbase
|
|
@SkipIfADLS.hbase
|
|
@SkipIfS3.hbase
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args("--use_local_tz_for_unix_timestamp_conversions=true")
|
|
def test_timestamp_functions(self, vector):
|
|
"""Tests timestamp functions with --use_local_tz_for_unix_timestamp_conversions=true
|
|
TODO: this test can be probably removed as a query option is created for
|
|
use_local_tz_for_unix_timestamp_conversions in IMPALA-10171
|
|
"""
|
|
vector.get_value('exec_option')['enable_expr_rewrites'] = \
|
|
vector.get_value('enable_expr_rewrites')
|
|
|
|
# Tests for UTC timestamp functions, i.e. functions that do not depend on the
|
|
# behavior of the flag --use_local_tz_for_unix_timestamp_conversions. These tests
|
|
# are also executed in test_exprs.py to ensure the same behavior when running
|
|
# without the gflag set.
|
|
self.run_test_case('QueryTest/utc-timestamp-functions', vector)
|
|
|
|
# Tests for local timestamp functions, i.e. functions that depend on the
|
|
# behavior of the flag --use_local_tz_for_unix_timestamp_conversions.
|
|
self.run_test_case('QueryTest/local-timestamp-functions', vector)
|
|
|
|
# Test that scanning of different file formats is not affected by flag
|
|
# use_local_tz_for_unix_timestamp_conversions.
|
|
self.run_test_case('QueryTest/file-formats-with-local-tz-conversion', vector)
|