mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
1f473f365a
Enables the clang-tidy performance-unnecessary-value-param check and fixes any issues found with run_clang_tidy.sh. Updates based on how values are used: - constructors and functions that take ownership of a value accept by value and move into place to efficiently handle literal values - others take a const& of the value GetUsernameFromBasicAuthHeader was updated to make a copy closer to where it's needed, rather than relying on the caller setting it up. Updates CodegenNullPhiNode to use its 'name' parameter. Only impacts two calls in filter-context.cc. Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Reviewed-on: http://gerrit.cloudera.org:8080/20494 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
63 lines
1.8 KiB
YAML
63 lines
1.8 KiB
YAML
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
---
|
|
Checks: "-*,clang*,\
|
|
-clang-analyzer-alpha*,\
|
|
-clang-analyzer-core.CallAndMessage,\
|
|
-clang-analyzer-core.NonNullParamChecker,\
|
|
-clang-analyzer-core.NullDereference,\
|
|
-clang-analyzer-core.UndefinedBinaryOperatorResult,\
|
|
-clang-analyzer-core.uninitialized.ArraySubscript,\
|
|
-clang-analyzer-core.uninitialized.Assign,\
|
|
-clang-analyzer-core.uninitialized.Branch,\
|
|
-clang-analyzer-cplusplus.NewDelete,\
|
|
-clang-analyzer-cplusplus.NewDeleteLeaks,\
|
|
-clang-analyzer-deadcode.DeadStores,\
|
|
-clang-analyzer-optin.performance.Padding,\
|
|
-clang-analyzer-unix.Malloc,\
|
|
-clang-analyzer-unix.MallocSizeof,\
|
|
-clang-diagnostic-sign-compare,\
|
|
-clang-diagnostic-return-type-c-linkage,\
|
|
-clang-diagnostic-unused-local-typedef,\
|
|
-clang-diagnostic-unused-parameter,\
|
|
performance-*"
|
|
|
|
# Ignore warnings in gutil
|
|
|
|
HeaderFilterRegex: "be/src/\
|
|
(benchmarks\
|
|
|catalog\
|
|
|codegen\
|
|
|common\
|
|
|exec\
|
|
|experiments\
|
|
|exprs\
|
|
|resourcebroker\
|
|
|rpc\
|
|
|runtime\
|
|
|scheduling\
|
|
|service\
|
|
|statestore\
|
|
|testutil\
|
|
|thirdparty\
|
|
|transport\
|
|
|udf\
|
|
|udf_samples\
|
|
|util)"
|
|
|
|
AnalyzeTemporaryDtors: true
|