mirror of
https://github.com/apache/impala.git
synced 2025-12-19 09:58:28 -05:00
ba4cb95b62
This fixes a few different CMake warnings:
1. This removes cmake_minimum_required invocations except for the
top-most CMakeLists.txt. This eliminates the warnings like this:
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
Moving to a later version also required setting CMAKE_ENABLE_EXPORTS
to continue exporting symbols.
2. This modifies the module names so that they match the corresponding
module names from Find*.cmake. This is mostly dealing with case
differences. This address warnings like:
The package name passed to `find_package_handle_standard_args` (PROTOBUF)
does not match the name of the calling package (Protobuf). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
This fixed the detection logic for KerberosPrograms, and so it required
adding more Kerberos packages to bin/bootstrap_build.sh.
3. This adds a missing .cc suffix. This addresses the following warning:
CMake Warning (dev) at be/src/util/CMakeLists.txt:141 (add_library):
Policy CMP0115 is not set: Source file extensions must be explicit. Run
"cmake --help-policy CMP0115" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
These fixes mostly match how these warnings were handled in
Apache Kudu.
Testing:
- Ran GVO
Change-Id: I2a97dd07cdd0831e90882a2035415ac71d670147
Reviewed-on: http://gerrit.cloudera.org:8080/18444
Reviewed-by: Joe McDonnell <joemcdonnell@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
237 lines
9.3 KiB
CMake
237 lines
9.3 KiB
CMake
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
#=============================================================================
|
|
# This file is heavily modified/rewritten from FindProtobuf.cmake from the
|
|
# CMake project:
|
|
#
|
|
# Copyright 2011 Kirill A. Korinskiy <catap@catap.ru>
|
|
# Copyright 2009 Kitware, Inc.
|
|
# Copyright 2009 Philip Lowman <philip@yhbt.com>
|
|
# Copyright 2008 Esben Mose Hansen, Ange Optimization ApS
|
|
#
|
|
# Distributed under the OSI-approved BSD License (the "License"):
|
|
#
|
|
# CMake - Cross Platform Makefile Generator
|
|
# Copyright 2000-2015 Kitware, Inc.
|
|
# Copyright 2000-2011 Insight Software Consortium
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
#
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution.
|
|
#
|
|
# * Neither the names of Kitware, Inc., the Insight Software Consortium,
|
|
# nor the names of their contributors may be used to endorse or promote
|
|
# products derived from this software without specific prior written
|
|
# permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
#=============================================================================
|
|
|
|
#########
|
|
# Local rewrite of the protobuf support in cmake.
|
|
#
|
|
# Supports cross-module protobuf dependencies and protobufs inside
|
|
# packages much better than the one built into cmake.
|
|
#########
|
|
#
|
|
# Locate and configure the Google Protocol Buffers library.
|
|
# Defines the following variables:
|
|
#
|
|
# PROTOBUF_INCLUDE_DIR - the include directory for protocol buffers
|
|
# PROTOBUF_SHARED_LIBRARY - path to protobuf's shared library
|
|
# PROTOBUF_STATIC_LIBRARY - path to protobuf's static library
|
|
# PROTOBUF_PROTOC_SHARED_LIBRARY - path to protoc's shared library
|
|
# PROTOBUF_PROTOC_STATIC_LIBRARY - path to protoc's static library
|
|
# PROTOBUF_PROTOC_EXECUTABLE - the protoc compiler
|
|
# PROTOBUF_FOUND - whether the Protocol Buffers library has been found
|
|
#
|
|
# ====================================================================
|
|
# Example:
|
|
#
|
|
# find_package(Protobuf REQUIRED)
|
|
# include_directories(${PROTOBUF_INCLUDE_DIR})
|
|
#
|
|
# include_directories(${CMAKE_CURRENT_BINARY_DIR})
|
|
# PROTOBUF_GENERATE_CPP(PROTO_SRCS PROTO_HDRS PROTO_TGTS
|
|
# [SOURCE_ROOT <root from which source is found>]
|
|
# [BINARY_ROOT <root into which binaries are built>]
|
|
# PROTO_FILES foo.proto)
|
|
# add_executable(bar bar.cc ${PROTO_SRCS} ${PROTO_HDRS})
|
|
# target_link_libraries(bar ${PROTOBUF_SHARED_LIBRARY})
|
|
#
|
|
# NOTE: You may need to link against pthreads, depending
|
|
# on the platform.
|
|
# ====================================================================
|
|
#
|
|
# PROTOBUF_GENERATE_CPP (public function)
|
|
# SRCS = Variable to define with autogenerated
|
|
# source files
|
|
# HDRS = Variable to define with autogenerated
|
|
# header files
|
|
# TGTS = Variable to define with autogenerated
|
|
# custom targets; if SRCS/HDRS need to be used in multiple
|
|
# libraries, those libraries should depend on these targets
|
|
# in order to "serialize" the protoc invocations
|
|
# ====================================================================
|
|
|
|
function(PROTOBUF_GENERATE_CPP SRCS HDRS TGTS)
|
|
if(NOT ARGN)
|
|
message(SEND_ERROR "Error: PROTOBUF_GENERATE_CPP() called without any proto files")
|
|
return()
|
|
endif(NOT ARGN)
|
|
|
|
set(options)
|
|
set(one_value_args SOURCE_ROOT BINARY_ROOT)
|
|
set(multi_value_args EXTRA_PROTO_PATHS PROTO_FILES)
|
|
cmake_parse_arguments(ARG "${options}" "${one_value_args}" "${multi_value_args}" ${ARGN})
|
|
if(ARG_UNPARSED_ARGUMENTS)
|
|
message(SEND_ERROR "Error: unrecognized arguments: ${ARG_UNPARSED_ARGUMENTS}")
|
|
endif()
|
|
|
|
set(${SRCS})
|
|
set(${HDRS})
|
|
set(${TGTS})
|
|
|
|
set(EXTRA_PROTO_PATH_ARGS)
|
|
foreach(PP ${ARG_EXTRA_PROTO_PATHS})
|
|
set(EXTRA_PROTO_PATH_ARGS ${EXTRA_PROTO_PATH_ARGS} --proto_path ${PP})
|
|
endforeach()
|
|
|
|
if("${ARG_SOURCE_ROOT}" STREQUAL "")
|
|
SET(ARG_SOURCE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}")
|
|
endif()
|
|
GET_FILENAME_COMPONENT(ARG_SOURCE_ROOT ${ARG_SOURCE_ROOT} ABSOLUTE)
|
|
|
|
if("${ARG_BINARY_ROOT}" STREQUAL "")
|
|
SET(ARG_BINARY_ROOT "${CMAKE_CURRENT_BINARY_DIR}")
|
|
endif()
|
|
GET_FILENAME_COMPONENT(ARG_BINARY_ROOT ${ARG_BINARY_ROOT} ABSOLUTE)
|
|
GET_FILENAME_COMPONENT(PROTO_LIB_DIR ${PROTOBUF_SHARED_LIBRARY} DIRECTORY)
|
|
|
|
foreach(FIL ${ARG_PROTO_FILES})
|
|
get_filename_component(ABS_FIL ${FIL} ABSOLUTE)
|
|
get_filename_component(FIL_WE ${FIL} NAME_WE)
|
|
|
|
# Ensure that the protobuf file is within the source root.
|
|
# This is a requirement of protoc.
|
|
FILE(RELATIVE_PATH PROTO_REL_TO_ROOT "${ARG_SOURCE_ROOT}" "${ABS_FIL}")
|
|
|
|
GET_FILENAME_COMPONENT(REL_DIR "${PROTO_REL_TO_ROOT}" PATH)
|
|
|
|
if(NOT REL_DIR STREQUAL "")
|
|
SET(REL_DIR "${REL_DIR}/")
|
|
endif()
|
|
|
|
set(PROTO_CC_OUT "${ARG_BINARY_ROOT}/${REL_DIR}${FIL_WE}.pb.cc")
|
|
set(PROTO_H_OUT "${ARG_BINARY_ROOT}/${REL_DIR}${FIL_WE}.pb.h")
|
|
list(APPEND ${SRCS} "${PROTO_CC_OUT}")
|
|
list(APPEND ${HDRS} "${PROTO_H_OUT}")
|
|
|
|
add_custom_command(
|
|
OUTPUT "${PROTO_CC_OUT}" "${PROTO_H_OUT}"
|
|
COMMAND ${CMAKE_COMMAND}
|
|
-E env "LD_LIBRARY_PATH=${PROTO_LIB_DIR}:$ENV{LD_LIBRARY_PATH}"
|
|
${PROTOBUF_PROTOC_EXECUTABLE}
|
|
ARGS
|
|
--plugin $<TARGET_FILE:protoc-gen-insertions>
|
|
--cpp_out ${ARG_BINARY_ROOT}
|
|
--insertions_out ${ARG_BINARY_ROOT}
|
|
--proto_path ${ARG_SOURCE_ROOT}
|
|
# Used to find built-in .proto files (e.g. FileDescriptorProto)
|
|
--proto_path ${PROTOBUF_INCLUDE_DIR}
|
|
${EXTRA_PROTO_PATH_ARGS} ${ABS_FIL}
|
|
DEPENDS ${ABS_FIL} protoc-gen-insertions
|
|
COMMENT "Running C++ protocol buffer compiler on ${FIL}"
|
|
VERBATIM )
|
|
|
|
# This custom target enforces that there's just one invocation of protoc
|
|
# when there are multiple consumers of the generated files. The target name
|
|
# must be unique; adding parts of the filename helps ensure this.
|
|
set(TGT_NAME PROTO_${REL_DIR}${FIL})
|
|
string(REPLACE "/" "-" TGT_NAME ${TGT_NAME})
|
|
add_custom_target(${TGT_NAME}
|
|
DEPENDS "${PROTO_CC_OUT}" "${PROTO_H_OUT}")
|
|
list(APPEND ${TGTS} "${TGT_NAME}")
|
|
endforeach()
|
|
|
|
set_source_files_properties(${${SRCS}} ${${HDRS}} PROPERTIES GENERATED TRUE)
|
|
set(${SRCS} ${${SRCS}} PARENT_SCOPE)
|
|
set(${HDRS} ${${HDRS}} PARENT_SCOPE)
|
|
set(${TGTS} ${${TGTS}} PARENT_SCOPE)
|
|
endfunction()
|
|
|
|
|
|
find_path(PROTOBUF_INCLUDE_DIR google/protobuf/service.h
|
|
PATHS ${PROTOBUF_ROOT}/include
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
find_library(PROTOBUF_SHARED_LIBRARY protobuf
|
|
PATHS ${PROTOBUF_ROOT}/lib
|
|
DOC "The Google Protocol Buffers Library"
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
find_library(PROTOBUF_STATIC_LIBRARY libprotobuf.a
|
|
PATHS ${PROTOBUF_ROOT}/lib
|
|
DOC "Static version of the Google Protocol Buffers Library"
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
find_library(PROTOBUF_PROTOC_SHARED_LIBRARY protoc
|
|
PATHS ${PROTOBUF_ROOT}/lib
|
|
DOC "The Google Protocol Buffers Compiler Library"
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
find_library(PROTOBUF_PROTOC_STATIC_LIBRARY libprotoc.a
|
|
PATHS ${PROTOBUF_ROOT}/lib
|
|
DOC "Static version of the Google Protocol Buffers Compiler Library"
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
find_program(PROTOBUF_PROTOC_EXECUTABLE protoc
|
|
PATHS ${PROTOBUF_ROOT}/bin
|
|
DOC "The Google Protocol Buffers Compiler"
|
|
NO_CMAKE_SYSTEM_PATH
|
|
NO_SYSTEM_ENVIRONMENT_PATH)
|
|
|
|
include(FindPackageHandleStandardArgs)
|
|
find_package_handle_standard_args(Protobuf REQUIRED_VARS
|
|
PROTOBUF_SHARED_LIBRARY PROTOBUF_STATIC_LIBRARY
|
|
PROTOBUF_PROTOC_SHARED_LIBRARY PROTOBUF_PROTOC_STATIC_LIBRARY
|
|
PROTOBUF_INCLUDE_DIR PROTOBUF_PROTOC_EXECUTABLE)
|