mirror of
https://github.com/apache/impala.git
synced 2026-01-16 09:00:38 -05:00
This patch avoids a few unecessary memory allocations, locks and atomics that can become a bottleneck when executing subplans. On the following benchmark the end-to-end runtime of a subplan-heavy query was improved from 37s to 27s. Benchmark: select count(*) from huge_customer c, c.c_orders o, o.o_lineitems The huge_customer table had 48 files totalling 6.5GB. The table was created by copying the files of tpch_nested_parquet.customer several times into the huge_customer table. I ran the benchmark with a single impalad. There are still several easy opportunities for improving the performance of subplan execution. Change-Id: I9fce1c2857a8f8e6ed3f1b4842d07fd80c11296a Reviewed-on: http://gerrit.cloudera.org:8080/894 Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com> Tested-by: Internal Jenkins
208 lines
5.7 KiB
C++
208 lines
5.7 KiB
C++
// Copyright 2013 Cloudera Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <string>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "runtime/mem-tracker.h"
|
|
#include "util/metrics.h"
|
|
|
|
#include "common/names.h"
|
|
|
|
namespace impala {
|
|
|
|
TEST(MemTestTest, SingleTrackerNoLimit) {
|
|
MemTracker t;
|
|
EXPECT_FALSE(t.has_limit());
|
|
t.Consume(10);
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
t.Consume(10);
|
|
EXPECT_EQ(t.consumption(), 20);
|
|
t.Release(15);
|
|
EXPECT_EQ(t.consumption(), 5);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
}
|
|
|
|
TEST(MemTestTest, SingleTrackerWithLimit) {
|
|
MemTracker t(11);
|
|
EXPECT_TRUE(t.has_limit());
|
|
t.Consume(10);
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
t.Consume(10);
|
|
EXPECT_EQ(t.consumption(), 20);
|
|
EXPECT_TRUE(t.LimitExceeded());
|
|
t.Release(15);
|
|
EXPECT_EQ(t.consumption(), 5);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
}
|
|
|
|
TEST(MemTestTest, ConsumptionMetric) {
|
|
TMetricDef md;
|
|
md.__set_key("test");
|
|
md.__set_units(TUnit::BYTES);
|
|
md.__set_kind(TMetricKind::GAUGE);
|
|
UIntGauge metric(md, 0);
|
|
EXPECT_EQ(metric.value(), 0);
|
|
|
|
MemTracker t(&metric, 100, -1, "");
|
|
EXPECT_TRUE(t.has_limit());
|
|
EXPECT_EQ(t.consumption(), 0);
|
|
|
|
// Consume()/Release() arguments have no effect
|
|
t.Consume(150);
|
|
EXPECT_EQ(t.consumption(), 0);
|
|
EXPECT_EQ(t.peak_consumption(), 0);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
t.Release(5);
|
|
EXPECT_EQ(t.consumption(), 0);
|
|
EXPECT_EQ(t.peak_consumption(), 0);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
metric.Increment(10);
|
|
// consumption_ is only updated with consumption_metric_ after calls to
|
|
// Consume()/Release() with a non-zero value
|
|
t.Consume(1);
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
EXPECT_EQ(t.peak_consumption(), 10);
|
|
metric.Increment(-5);
|
|
t.Consume(-1);
|
|
EXPECT_EQ(t.consumption(), 5);
|
|
EXPECT_EQ(t.peak_consumption(), 10);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
metric.Increment(150);
|
|
t.Consume(1);
|
|
EXPECT_EQ(t.consumption(), 155);
|
|
EXPECT_EQ(t.peak_consumption(), 155);
|
|
EXPECT_TRUE(t.LimitExceeded());
|
|
metric.Increment(-150);
|
|
t.Consume(-1);
|
|
EXPECT_EQ(t.consumption(), 5);
|
|
EXPECT_EQ(t.peak_consumption(), 155);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
// consumption_ is not updated when Consume()/Release() is called with a zero value
|
|
metric.Increment(10);
|
|
t.Consume(0);
|
|
EXPECT_EQ(t.consumption(), 5);
|
|
EXPECT_EQ(t.peak_consumption(), 155);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
}
|
|
|
|
TEST(MemTestTest, TrackerHierarchy) {
|
|
MemTracker p(100);
|
|
MemTracker c1(80, -1, "", &p);
|
|
MemTracker c2(50, -1, "", &p);
|
|
|
|
// everything below limits
|
|
c1.Consume(60);
|
|
EXPECT_EQ(c1.consumption(), 60);
|
|
EXPECT_FALSE(c1.LimitExceeded());
|
|
EXPECT_FALSE(c1.AnyLimitExceeded());
|
|
EXPECT_EQ(c2.consumption(), 0);
|
|
EXPECT_FALSE(c2.LimitExceeded());
|
|
EXPECT_FALSE(c2.AnyLimitExceeded());
|
|
EXPECT_EQ(p.consumption(), 60);
|
|
EXPECT_FALSE(p.LimitExceeded());
|
|
EXPECT_FALSE(p.AnyLimitExceeded());
|
|
|
|
// p goes over limit
|
|
c2.Consume(50);
|
|
EXPECT_EQ(c1.consumption(), 60);
|
|
EXPECT_FALSE(c1.LimitExceeded());
|
|
EXPECT_TRUE(c1.AnyLimitExceeded());
|
|
EXPECT_EQ(c2.consumption(), 50);
|
|
EXPECT_FALSE(c2.LimitExceeded());
|
|
EXPECT_TRUE(c2.AnyLimitExceeded());
|
|
EXPECT_EQ(p.consumption(), 110);
|
|
EXPECT_TRUE(p.LimitExceeded());
|
|
|
|
// c2 goes over limit, p drops below limit
|
|
c1.Release(20);
|
|
c2.Consume(10);
|
|
EXPECT_EQ(c1.consumption(), 40);
|
|
EXPECT_FALSE(c1.LimitExceeded());
|
|
EXPECT_FALSE(c1.AnyLimitExceeded());
|
|
EXPECT_EQ(c2.consumption(), 60);
|
|
EXPECT_TRUE(c2.LimitExceeded());
|
|
EXPECT_TRUE(c2.AnyLimitExceeded());
|
|
EXPECT_EQ(p.consumption(), 100);
|
|
EXPECT_FALSE(p.LimitExceeded());
|
|
}
|
|
|
|
class GcFunctionHelper {
|
|
public:
|
|
static const int NUM_RELEASE_BYTES = 1;
|
|
|
|
GcFunctionHelper(MemTracker* tracker) : tracker_(tracker) { }
|
|
|
|
void GcFunc() { tracker_->Release(NUM_RELEASE_BYTES); }
|
|
|
|
private:
|
|
MemTracker* tracker_;
|
|
};
|
|
|
|
TEST(MemTestTest, GcFunctions) {
|
|
MemTracker t(10);
|
|
ASSERT_TRUE(t.has_limit());
|
|
|
|
t.Consume(9);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
// Test TryConsume()
|
|
EXPECT_FALSE(t.TryConsume(2));
|
|
EXPECT_EQ(t.consumption(), 9);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
// Attach GcFunction that releases 1 byte
|
|
GcFunctionHelper gc_func_helper(&t);
|
|
t.AddGcFunction(boost::bind(&GcFunctionHelper::GcFunc, &gc_func_helper));
|
|
EXPECT_TRUE(t.TryConsume(2));
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
// GcFunction will be called even though TryConsume() fails
|
|
EXPECT_FALSE(t.TryConsume(2));
|
|
EXPECT_EQ(t.consumption(), 9);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
// GcFunction won't be called
|
|
EXPECT_TRUE(t.TryConsume(1));
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
|
|
// Test LimitExceeded()
|
|
t.Consume(1);
|
|
EXPECT_EQ(t.consumption(), 11);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
|
|
// Add more GcFunctions, test that we only call them until the limit is no longer
|
|
// exceeded
|
|
GcFunctionHelper gc_func_helper2(&t);
|
|
t.AddGcFunction(boost::bind(&GcFunctionHelper::GcFunc, &gc_func_helper2));
|
|
GcFunctionHelper gc_func_helper3(&t);
|
|
t.AddGcFunction(boost::bind(&GcFunctionHelper::GcFunc, &gc_func_helper3));
|
|
t.Consume(1);
|
|
EXPECT_EQ(t.consumption(), 11);
|
|
EXPECT_FALSE(t.LimitExceeded());
|
|
EXPECT_EQ(t.consumption(), 10);
|
|
}
|
|
|
|
}
|
|
|
|
int main(int argc, char **argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|