mirror of
https://github.com/apache/impala.git
synced 2025-12-20 02:20:11 -05:00
155ffd64ee
Adds a new section to the host profiles that includes JVM GC related
metrics. These metrics are taken from JMX and the JvmPauseMonitor.
The host profiles will now include a section like below:
JVM:
- GcCount: 19
- GcNumInfoThresholdExceeded: 0
- GcNumWarnThresholdExceeded: 0
- GcTimeMillis: 17s476ms
- GcTotalExtraSleepTimeMillis: 380
GcNumInfoThresholdExceeded, GcNumWarnThresholdExceeded, and
GcTotalExtraSleepTimeMillis are all taken from JvmPauseMonitor.
GcCount and GcTimeMillis are taken from JMX (specifically,
GarbageCollectorMXBean).
The counters themselves are derived from the impalad host-level metrics.
Changed the 'lock_' in JvmMetricCache (in memory-metrics.h) from a mutex
to a shared_mutex. Most accessors of the JvmMetricCache member variables
are read-only. A write only occurs lazily at most every second. This
should help reduce lock contention on JvmMetricCache now that all
queries will start accessing info stored by the JvmMetricCache.
Testing:
* Ran core tests
* Added a test that runs Java UDF, which triggers JVM GC
Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b
Reviewed-on: http://gerrit.cloudera.org:8080/16414
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Reviewed-by: Sahil Takiar <stakiar@cloudera.com>
Tested-by: Sahil Takiar <stakiar@cloudera.com>
50 lines
2.0 KiB
Python
50 lines
2.0 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import pytest
|
|
import re
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.util.filesystem_utils import get_fs_path
|
|
from tests.util.parse_util import parse_duration_string_ms
|
|
|
|
|
|
class TestObservability(CustomClusterTestSuite):
|
|
@classmethod
|
|
def get_workload(self):
|
|
return 'functional-query'
|
|
|
|
@pytest.mark.execute_serially
|
|
def test_host_profile_jvm_gc_metrics(self, unique_database):
|
|
self.execute_query_expect_success(self.client,
|
|
"create function {0}.gc(int) returns int location '{1}' \
|
|
symbol='org.apache.impala.JavaGcUdfTest'".format(
|
|
unique_database, get_fs_path('/test-warehouse/impala-hive-udfs.jar')))
|
|
profile = self.execute_query_expect_success(self.client,
|
|
"select {0}.gc(int_col) from functional.alltypes limit 1000".format(
|
|
unique_database)).runtime_profile
|
|
|
|
gc_count_regex = "GcCount:.*\((.*)\)"
|
|
gc_count_match = re.search(gc_count_regex, profile)
|
|
assert gc_count_match, profile
|
|
assert int(gc_count_match.group(1)) > 0, profile
|
|
|
|
gc_time_millis_regex = "GcTimeMillis: (.*)"
|
|
gc_time_millis_match = re.search(gc_time_millis_regex, profile)
|
|
assert gc_time_millis_match, profile
|
|
assert parse_duration_string_ms(gc_time_millis_match.group(1)) > 0
|