mirror of
https://github.com/apache/impala.git
synced 2025-12-20 02:20:11 -05:00
a47700ed79
This patch adds a wrapper around ThriftDebugString method provided in the Thrift library. The thrift's method can throw exceptions like (bad_alloc or TProtocolException) when the object cannot be serialized into a string representation. This exception is not caught on the catalogd side and it crashes the catalogd. The error was specifically seen in the catalogd's debug UI which provides a way to display a Table object. An exception thrown when rendering the table on the UI would have crashed the catalogd before the patch. In order to simulate this crash a new debug action called EXCEPTION was added. A new custom cluster test was added which simulates a exception thrown in this method and makes sure that fetching the table from catalogd's debug UI does not crash the catalogd. Tests: 1. Added a new custom cluster test which reproduces the crash. 2. Created a large table which has ~270K partitions and reduced the memory of the catalogd to 16GB. This configuration throws bad_alloc exception in the ThriftDebugString method and crashes the catalogd. After the patch the crash is averted and we see a error message on the debug UI instead. I also looped around the catalog web UI call for more than an hour to see if there are any other stability issues. I could not see any problems. Change-Id: I42cee6186a3d5bacc1117bae5961ac60ac9f7a66 Reviewed-on: http://gerrit.cloudera.org:8080/17110 Reviewed-by: Vihang Karajgaonkar <vihang@cloudera.com> Tested-by: Vihang Karajgaonkar <vihang@cloudera.com>
52 lines
2.3 KiB
Python
52 lines
2.3 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
|
|
|
|
class TestThriftDebugStringExceptions(CustomClusterTestSuite):
|
|
"""Regression tests for IMPALA-10450"""
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
catalogd_args="--debug_actions=THRIFT_DEBUG_STRING:EXCEPTION@bad_alloc")
|
|
def test_thrift_debug_str_bad_alloc(self):
|
|
"""The test executes a API call to get a catalog object from the debug UI and makes
|
|
sure that catalogd does not crash if the ThriftDebugString throws bad_alloc
|
|
exception."""
|
|
obj = self._get_catalog_object()
|
|
assert "Unexpected exception received" in obj
|
|
|
|
@CustomClusterTestSuite.with_args(
|
|
catalogd_args="--debug_actions=THRIFT_DEBUG_STRING:EXCEPTION@TException")
|
|
def test_thrift_debug_str_texception(self):
|
|
"""The test executes a API call to get a catalog object from the debug UI and makes
|
|
sure that catalogd does not crash if the ThriftDebugString throws a TException."""
|
|
obj = self._get_catalog_object()
|
|
assert "Unexpected exception received" in obj
|
|
|
|
@CustomClusterTestSuite.with_args()
|
|
def test_thrift_debug_str(self):
|
|
"""Sanity test which executes API call to get a catalog object and make sure that
|
|
it does not return a error message under normal circumstances."""
|
|
obj = self._get_catalog_object()
|
|
assert "Unexpected exception received" not in obj
|
|
|
|
def _get_catalog_object(self):
|
|
""" Return the catalog object of functional.alltypes serialized to string. """
|
|
return self.cluster.catalogd.service.read_debug_webpage(
|
|
"catalog_object?object_type=TABLE&object_name=functional.alltypes")
|