mirror of
https://github.com/apache/impala.git
synced 2026-01-03 15:00:52 -05:00
7e0cbaf1a0
It was previously thought that PURGE had no effect on S3. However, the Hive Metastore actually created a .Trash directory and copied the files there when a DROP TABLE was conducted from Impala. This patch just enables the existing PURGE tests for S3. There were a few reasons this wasn't working before. The paths given to the S3 client (boto3) should not have a leading "/". This has been fixed as it doesn't make a difference for HDFS if that exists or not. Also, PURGE is a pure delete whereas a regular DROP is a copy. A copy is consistent whereas a delete is only eventually consistent, so when we PURGE a table or partition, the files will still be visible for sometime after the query has completed. The tests have been modified to accomodate for this case as well. Change-Id: I52d2451e090b00ae2fd9a879c28defa6c940047c Reviewed-on: http://gerrit.cloudera.org:8080/3036 Reviewed-by: Sailesh Mukil <sailesh@cloudera.com> Tested-by: Internal Jenkins